ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-25 11:51:26 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Improve ansible-test completion and messaging. (#19627)

Browse source 
* Simplify type annotation of args.docker_util.
* Improve error messaging for ansible-doc test.
* Add completion for docker, remote and windows.
This commit is contained in:
Matt Clay 2016-12-22 09:57:17 -08:00 • committed by GitHub
parent 6f5ecb7efd
commit dac226de4a
5 changed files with 66 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/runner/lib/executor.py
View file

@ -723,7 +723,7 @@ def command_sanity_ansible_doc(args, targets, python_version):
stdout, stderr = intercept_command(args, cmd, env=env, capture=True, python_version=python_version)
if stderr:
# consider any output on stderr an error, even though the return code is zero
display.error('Output on stderr from ansible-doc is considered an error.')
raise SubprocessError(cmd, stderr=stderr)
if stdout:
@ -927,8 +927,8 @@ def detect_changes_local(args):
def docker_qualify_image(name):
"""
:type name: str | None
:rtype: str | None
:type name: str
:rtype: str
"""
if not name or any((c in name) for c in ('/', ':')):
return name
@ -1105,7 +1105,7 @@ class EnvironmentConfig(CommonConfig):
self.remote = args.remote # type: str
self.docker_privileged = args.docker_privileged if 'docker_privileged' in args else False # type: bool
self.docker_util = docker_qualify_image(args.docker_util if 'docker_util' in args else None) # type: str | None
self.docker_util = docker_qualify_image(args.docker_util if 'docker_util' in args else '') # type: str
self.docker_pull = args.docker_pull if 'docker_pull' in args else False # type: bool
self.tox_sitepackages = args.tox_sitepackages # type: bool