fix nxos_hsrp issues (#38410)

* fix nxos_hsrp issues

* shippable fix

* add examples for md5 auth

test/integration/targets/nxos_hsrp/tests/common/sanity.yaml

@@ -4,7 +4,8 @@
   when: ansible_connection == "local"
 
 # Select interface for test
-- set_fact: intname="{{ nxos_int1 }}"
+- set_fact: intname1="{{ nxos_int1 }}"
+- set_fact: intname2="{{ nxos_int2 }}"
 
 - block:
   - name: "Enable feature hsrp"
@@ -13,25 +14,34 @@
       state: enabled
       provider: "{{ connection }}"
 
-  - name: "change interface mode"
+  - name: "change int1 mode"
     nxos_config:
       commands:
         - no switchport
       parents:
-        - "interface {{ intname }}"
+        - "interface {{ intname1 }}"
+      match: none
+      provider: "{{ connection }}"
+
+  - name: "change int2 mode"
+    nxos_config:
+      commands:
+        - no switchport
+      parents:
+        - "interface {{ intname2 }}"
       match: none
       provider: "{{ connection }}"
 
   - name: "configure nxos_hsrp"
-    nxos_hsrp: &configure
-      group: 10
+    nxos_hsrp: &conf1000
+      group: 1000
       version: 2
       vip: 10.1.1.1
       priority: 150
-      interface: "{{ intname }}"
+      interface: "{{ intname1 }}"
       preempt: enabled
-      auth_type: text
-      auth_string: CISCO
+      auth_type: md5
+      auth_string: "7 1234"
       provider: "{{ connection }}"
     register: result
 
@@ -40,24 +50,97 @@
         - "result.changed == true"
 
   - name: "Conf Idempotence"
-    nxos_hsrp: *configure
+    nxos_hsrp: *conf1000
     register: result
 
   - assert: &false
       that:
         - "result.changed == false"
 
+  - name: "configure group 100"
+    nxos_hsrp: &conf100
+      group: 100
+      version: 2
+      vip: 2.2.2.2
+      priority: 25
+      interface: "{{ intname1 }}"
+      preempt: enabled
+      auth_type: md5
+      auth_string: "0 1234"
+      provider: "{{ connection }}"
+    register: result
+
+  - assert: *true
+
+  - name: "Conf Idempotence"
+    nxos_hsrp: *conf100
+    register: result
+
+  - assert: *false
+
+  - name: "change group 100"
+    nxos_hsrp: &chg100
+      group: 100
+      version: 2
+      vip: default
+      priority: default
+      interface: "{{ intname1 }}"
+      preempt: disabled
+      auth_type: md5
+      auth_string: "0 1234"
+      provider: "{{ connection }}"
+    register: result
+
+  - assert: *true
+
+  - name: "Conf Idempotence"
+    nxos_hsrp: *chg100
+    register: result
+
+  - assert: *false
+
+  - name: "configure group 200"
+    nxos_hsrp: &conf200
+      group: 200
+      vip: 3.3.3.3
+      version: 1
+      interface: "{{ intname2 }}"
+      auth_type: text
+      auth_string: "1234"
+      provider: "{{ connection }}"
+    register: result
+
+  - assert: *true
+
+  - name: "Conf Idempotence"
+    nxos_hsrp: *conf200
+    register: result
+
+  - assert: *false
+
+  - name: "change group 200"
+    nxos_hsrp: &chg200
+      group: 200
+      vip: 3.3.3.3
+      version: 2
+      interface: "{{ intname2 }}"
+      auth_type: text
+      auth_string: default
+      provider: "{{ connection }}"
+    register: result
+
+  - assert: *true
+
+  - name: "Conf Idempotence"
+    nxos_hsrp: *chg200
+    register: result
+
+  - assert: *false
+
   - name: "remove nxos_hsrp"
     nxos_hsrp: &remove
-      group: 10
-      version: 2
-      vip: 10.1.1.1
-      priority: 150
-      interface: "{{ intname }}"
-      preempt: enabled
-      auth_type: text
-      auth_string: CISCO
-      provider: "{{ connection }}"
+      group: 1000
+      interface: "{{ intname1 }}"
       state: absent
     register: result
 
@@ -70,20 +153,6 @@
   - assert: *false
 
   always:
-  - name: "remove nxos_hsrp"
-    nxos_hsrp:
-      group: 10
-      version: 2
-      vip: 10.1.1.1
-      priority: 150
-      interface: "{{ intname }}"
-      preempt: enabled
-      auth_type: text
-      auth_string: CISCO
-      provider: "{{ connection }}"
-      state: absent
-    ignore_errors: yes
-
   - name: "Disable feature hsrp"
     nxos_feature: 
       feature: hsrp