ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-22 21:00:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Resolve homebrew and homebrew_cask package name validation issues (#1038) (#1188)

Browse source 
Add basic regression tests
Add changelog
Rename _create_regex_group to better suit function
Fix '-' use in Homebrew validation

(cherry picked from commit 4c379bd3b2)

Co-authored-by: MichaelWasher <mwasher@redhat.com>
This commit is contained in:
patchback[bot] 2020-10-28 06:46:35 +01:00 • committed by GitHub
commit d74680a3c6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 62 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

22
tests/unit/plugins/modules/packaging/os/test_homebrew.py Normal file
View file

@ -0,0 +1,22 @@
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
from ansible_collections.community.general.tests.unit.compat import unittest
from ansible_collections.community.general.plugins.modules.packaging.os.homebrew import Homebrew
class TestHomebrewModule(unittest.TestCase):
def setUp(self):
self.brew_app_names = [
'git-ssh',
'awscli@1',
'bash'
]
def test_valid_package_names(self):
for name in self.brew_app_names:
self.assertTrue(Homebrew.valid_package(name))

21
tests/unit/plugins/modules/packaging/os/test_homebrew_cask.py Normal file
View file

@ -0,0 +1,21 @@
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
from ansible_collections.community.general.tests.unit.compat import unittest
from ansible_collections.community.general.plugins.modules.packaging.os.homebrew_cask import HomebrewCask
class TestHomebrewCaskModule(unittest.TestCase):
def setUp(self):
self.brew_cask_names = [
'visual-studio-code',
'firefox'
]
def test_valid_cask_names(self):
for name in self.brew_cask_names:
self.assertTrue(HomebrewCask.valid_cask(name))