From d385caa73f6fbd4ed1790f49acbee83a5e4540b4 Mon Sep 17 00:00:00 2001
From: "patchback[bot]" <45432694+patchback[bot]@users.noreply.github.com>
Date: Mon, 11 Nov 2024 20:35:25 +0100
Subject: [PATCH] [PR #9114/bafb8aca backport][stable-9] redfish_utils: remove
undocumented default applytime (#9119)
redfish_utils: remove undocumented default applytime (#9114)
* redfish_utils: remove undocumented default applytime
The `@Redfish.OperationApplyTime` parameter is optional as per Redfish
spec version 1.21.0, paragraph 7.11 [1]. Some systems reject the
request rather than ignore it, causing failures that can not be
workarounded.
Removing this default resolves compatibility issues.
[1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0266_1.21.0.html
Signed-off-by: Tan Siewert <tan@siewert.io>
* redfish_utils: fix changelog fragment to bugfix
Signed-off-by: Tan Siewert <tan@siewert.io>
---------
Signed-off-by: Tan Siewert <tan@siewert.io>
(cherry picked from commit bafb8aca292dfb365a6386cc52e4de40f8e6bfc6)
Co-authored-by: Tan Siewert <tom@siewert.io>
---
.../9114-redfish-utils-update-remove-default-applytime.yml | 2 ++
plugins/module_utils/redfish_utils.py | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
create mode 100644 changelogs/fragments/9114-redfish-utils-update-remove-default-applytime.yml
diff --git a/changelogs/fragments/9114-redfish-utils-update-remove-default-applytime.yml b/changelogs/fragments/9114-redfish-utils-update-remove-default-applytime.yml
new file mode 100644
index 0000000000..672545a0a8
--- /dev/null
+++ b/changelogs/fragments/9114-redfish-utils-update-remove-default-applytime.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - redfish_utils module utils - remove undocumented default applytime (https://github.com/ansible-collections/community.general/pull/9114).
diff --git a/plugins/module_utils/redfish_utils.py b/plugins/module_utils/redfish_utils.py
index dfc88eeb7f..895ef15387 100644
--- a/plugins/module_utils/redfish_utils.py
+++ b/plugins/module_utils/redfish_utils.py
@@ -1937,7 +1937,7 @@ class RedfishUtils(object):
update_uri = data['MultipartHttpPushUri']
# Assemble the JSON payload portion of the request
- payload = {"@Redfish.OperationApplyTime": "Immediate"}
+ payload = {}
if targets:
payload["Targets"] = targets
if apply_time: