Add configuration to override location of ansible-connection (#46128)

* Add configuration to override location of ansible-connection

* Check var or argv[0] before $PATH
This commit is contained in:
Nathaniel Case 2018-10-01 14:29:59 -04:00 committed by GitHub
parent d3d812b604
commit cdaf5bd806
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 34 additions and 26 deletions

View file

@ -91,22 +91,20 @@ class Connection(ConnectionBase):
'''
Starts the persistent connection
'''
master, slave = pty.openpty()
candidate_paths = [C.ANSIBLE_CONNECTION_PATH or os.path.dirname(sys.argv[0])]
candidate_paths.extend(os.environ['PATH'].split(os.pathsep))
for dirname in candidate_paths:
ansible_connection = os.path.join(dirname, 'ansible-connection')
if os.path.isfile(ansible_connection):
break
else:
raise AnsibleError("Unable to find location of 'ansible-connection'. "
"Please set or check the value of ANSIBLE_CONNECTION_PATH")
python = sys.executable
def find_file_in_path(filename):
# Check $PATH first, followed by same directory as sys.argv[0]
paths = os.environ['PATH'].split(os.pathsep) + [os.path.dirname(sys.argv[0])]
for dirname in paths:
fullpath = os.path.join(dirname, filename)
if os.path.isfile(fullpath):
return fullpath
raise AnsibleError("Unable to find location of '%s'" % filename)
master, slave = pty.openpty()
p = subprocess.Popen(
[python, find_file_in_path('ansible-connection'), to_text(os.getppid())],
[python, ansible_connection, to_text(os.getppid())],
stdin=slave, stdout=subprocess.PIPE, stderr=subprocess.PIPE
)
os.close(slave)