From cd67a79b2dc4e6d3dd5ea8b5da13fe69cbfaaef2 Mon Sep 17 00:00:00 2001 From: Felix Fontein Date: Mon, 21 Jul 2025 10:24:39 +0200 Subject: [PATCH] Apply suggestions from code review. Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com> --- changelogs/fragments/10400-sysrc.yml | 2 +- plugins/modules/sysrc.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/changelogs/fragments/10400-sysrc.yml b/changelogs/fragments/10400-sysrc.yml index 6eb21104fa..ac5d5a5f3f 100644 --- a/changelogs/fragments/10400-sysrc.yml +++ b/changelogs/fragments/10400-sysrc.yml @@ -1,2 +1,2 @@ bugfixes: - - "sysrc - use shlex to improve parsing of ``sysrc -e -a`` output (https://github.com/ansible-collections/community.general/issues/10394, https://github.com/ansible-collections/community.general/pull/10400)." + - "sysrc - use ``shlex`` to improve parsing of ``sysrc -e -a`` output (https://github.com/ansible-collections/community.general/issues/10394, https://github.com/ansible-collections/community.general/pull/10400)." diff --git a/plugins/modules/sysrc.py b/plugins/modules/sysrc.py index 5aa252d74c..1202883c23 100644 --- a/plugins/modules/sysrc.py +++ b/plugins/modules/sysrc.py @@ -136,7 +136,7 @@ class Sysrc(object): if self.value is None: return self.name in conf else: - return self.name in conf and conf[self.name] == self.value + return conf.get(self.name) == self.value def contains(self): (rc, out, err) = self.run_sysrc('-n', self.name)