ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-28 21:31:26 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Skip top level args that are the same as args in provider in doc<->arg_spec comparisons (#36911)

Browse source
This commit is contained in:
Matt Martz 2018-03-01 10:47:20 -06:00 • committed by GitHub
parent a82043939b
commit ca092b5c26
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 344 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/sanity/validate-modules/main.py
View file

@ -1067,6 +1067,12 @@ class ModuleValidator(Validator):
'should not be marked as required' % arg)
)
if arg in provider_args:
# Provider args are being removed from network module top level
# don't validate docs<->arg_spec checks below
continue
# TODO: needs to recursively traverse suboptions
doc_default = docs.get('options', {}).get(arg, {}).get('default', None)
if data.get('type') == 'bool':
doc_default = maybe_convert_bool(doc_default)
@ -1081,6 +1087,7 @@ class ModuleValidator(Validator):
'documentation (%r)' % (arg_default, arg, doc_default))
)
# TODO: needs to recursively traverse suboptions
doc_type = docs.get('options', {}).get(arg, {}).get('type', 'str')
if 'type' in data and data['type'] == 'bool' and doc_type != 'bool':
self.reporter.error(
@ -1089,6 +1096,7 @@ class ModuleValidator(Validator):
msg='argument_spec for "%s" defines type="bool" but documentation does not' % (arg,)
)
# TODO: needs to recursively traverse suboptions
doc_choices = docs.get('options', {}).get(arg, {}).get('choices', [])
if not compare_unordered_lists(data.get('choices', []), doc_choices):
self.reporter.error(