From 2fca6e615de3e5d54759e3492ff25a9b59dd4aef Mon Sep 17 00:00:00 2001
From: mayabi <mayabi.ahm@gmail.com>
Date: Fri, 31 Jan 2025 15:34:21 +0330
Subject: [PATCH 01/31] add proxmox_backup_schedule module

---
 .github/BOTMETA.yml                           |   2 +
 meta/runtime.yml                              |   3 +-
 plugins/modules/proxmox_backup_schedule.py    | 227 +++++++++++++++++
 .../modules/test_proxmox_backup_schedule.py   | 238 ++++++++++++++++++
 4 files changed, 469 insertions(+), 1 deletion(-)
 create mode 100644 plugins/modules/proxmox_backup_schedule.py
 create mode 100644 tests/unit/plugins/modules/test_proxmox_backup_schedule.py

diff --git a/.github/BOTMETA.yml b/.github/BOTMETA.yml
index 1beb35c57b..1e384687fd 100644
--- a/.github/BOTMETA.yml
+++ b/.github/BOTMETA.yml
@@ -1148,6 +1148,8 @@ files:
     maintainers: IamLunchbox
   $modules/proxmox_backup_info.py:
     maintainers: raoufnezhad mmayabi
+  $modules/proxmox_backup_schedule.py:
+    maintainers: raoufnezhad mmayabi
   $modules/proxmox_nic.py:
     maintainers: Kogelvis krauthosting
   $modules/proxmox_node_info.py:
diff --git a/meta/runtime.yml b/meta/runtime.yml
index d6ffdbec57..904790403a 100644
--- a/meta/runtime.yml
+++ b/meta/runtime.yml
@@ -17,7 +17,8 @@ action_groups:
   proxmox:
     - proxmox
     - proxmox_backup
-    - proxmox_backup_info    
+    - proxmox_backup_info
+    - proxmox_backup_schedule
     - proxmox_disk
     - proxmox_domain_info
     - proxmox_group_info
diff --git a/plugins/modules/proxmox_backup_schedule.py b/plugins/modules/proxmox_backup_schedule.py
new file mode 100644
index 0000000000..a205bcc884
--- /dev/null
+++ b/plugins/modules/proxmox_backup_schedule.py
@@ -0,0 +1,227 @@
+#!/usr/bin/python
+# -*- coding: utf-8 -*-
+#
+# Copyright (c) 2025 Marzieh Raoufnezhad <raoufnezhad@gmail.com>
+# Copyright (c) 2024 Maryam Mayabi <mayabi.ahm at gmail.com>
+# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
+# SPDX-License-Identifier: GPL-3.0-or-later
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type
+
+DOCUMENTATION = """
+---
+module: proxmox_backup_schedule
+
+short_description: Scheduling VM backups and removing it.
+
+version_added: 10.3.0
+
+description: The module modifies backup jobs such as set or delete C(vmid).
+
+author:
+  - "Marzieh Raoufnezhad (@raoufnezhad) <raoufnezhad@gmail.com>"
+  - "Maryam Mayabi (@mmayabi) <mayabi.ahm@gmail.com>"
+
+options:
+  vm_name:
+    description:
+      - The name of the Proxmox VM.
+      - Mutually exclusive with O(vm_id).
+    type: str
+  vm_id:
+    description:
+      - The ID of the Proxmox VM.
+      - Mutually exclusive with O(vm_name).
+    type: str
+  backup_id:
+    description: The backup job ID.
+    type: str
+  backup_action:
+    description:
+        - If V(update_vmid), the module will update backup job with new VM ID.
+        - If V(delete_vmid), the module will remove the VM ID from all backup jobs where the VM ID has existed.
+    required: true
+    choices: [update_vmid, delete_vmid]
+    type: str
+
+extends_documentation_fragment:
+  - community.general.proxmox.documentation
+  - community.general.attributes
+  - community.general.attributes.info_module
+  - community.general.proxmox.actiongroup_proxmox
+"""
+
+EXAMPLES = """
+- name: Scheduling VM Backups based on VM name.
+  proxmox_backup_schedule:
+    api_user: 'myUser@pam'
+    api_password: '*******'
+    api_host: '192.168.20.20'
+    vm_name: 'VM Name'
+    backup_id: 'backup-b2adffdc-316e'
+    backup_action: 'update_vmid'
+
+- name: Scheduling VM Backups based on VM ID.
+  proxmox_backup_schedule:
+    api_user: 'myUser@pam'
+    api_password: '*******'
+    api_host: '192.168.20.20'
+    vm_id: 'VM ID'
+    backup_id: 'backup-b2adffdc-316e'
+    backup_action: 'update_vmid'
+
+- name: Removing backup setting based on VM name.
+  proxmox_backup_schedule:
+    api_user: 'myUser@pam'
+    api_password: '*******'
+    api_host: '192.168.20.20'
+    vm_name: 'VM Name'
+    backup_action: 'delete_vmid'
+
+- name: Removing backup setting based on VM ID.
+  proxmox_backup_schedule:
+    api_user: 'myUser@pam'
+    api_password: '*******'
+    api_host: '192.168.20.20'
+    vm_id: 'VM ID'
+    backup_action: 'delete_vmid'
+"""
+
+RETURN = """
+---
+  backup_schedule:
+  description:
+    - When backup_action is 'update_vmid', the backup_schedule will return True after successfully adding the VM ID to the backup job.
+    - When backup_action is 'delete_vmid', the backup_schedule will return a list of backup job IDs where the VM ID has been removed.
+  returned: always, but can be empty
+  type: bool | list
+  sample:
+    - True
+    - ['backup-job-id1', 'backup-job-id2']
+"""
+
+from ansible.module_utils.basic import AnsibleModule, missing_required_lib
+from ansible_collections.community.general.plugins.module_utils.proxmox import (
+    proxmox_auth_argument_spec, ProxmoxAnsible, HAS_PROXMOXER, PROXMOXER_IMP_ERR)
+
+
+class ProxmoxSetVMBackupAnsible(ProxmoxAnsible):
+    # Getting backup sections
+    def get_cluster_bklist(self):
+        try:
+            backupSections = self.proxmox_api.cluster.backup.get()
+        except Exception as e:
+            self.module.fail_json(msg="Getting backup sections failed: %s" % e)
+        return backupSections
+
+    def get_cluster_specific_bkjobid(self, backup_id):
+        try:
+            specificBackupID = self.proxmox_api.cluster.backup.get(backup_id)
+        except Exception as e:
+            self.module.fail_json(msg="Getting specific backup ID failed: %s" % e)
+        return specificBackupID
+
+    def set_vmid_backup(self, backup_id, bk_id_vmids):
+        try:
+            self.proxmox_api.cluster.backup.put(backup_id, vmid=bk_id_vmids)
+        except Exception as e:
+            self.module.fail_json(msg="Setting vmid backup failed: %s" % e)
+        return
+
+    def get_vms_list(self):
+        try:
+            vms = self.proxmox_api.cluster.resources.get(type='vm')
+        except Exception as e:
+            self.module.fail_json(msg="Getting vms info from cluster failed: %s" % e)
+        return vms
+
+    # convert vm name to vm ID
+    def vmname_2_vmid(self, vmname):
+        vmInfo = self.get_vms_list()
+        vms = [vm for vm in vmInfo if vm['name'] == vmname]
+        return (vms[0]['vmid'])
+
+    # add vmid to backup job
+    def backup_update_vmid(self, vm_id, backup_id):
+        bk_id_info = self.get_cluster_specific_bkjobid(backup_id)
+
+        # If bk_id_info is a list, get the first item (assuming there's only one backup job returned)
+        if isinstance(bk_id_info, list):
+            bk_id_info = bk_id_info[0]  # Access the first item in the list
+        vms_id = bk_id_info['vmid'].split(',')
+        if vm_id not in vms_id:
+            bk_id_vmids = bk_id_info['vmid'] + ',' + str(vm_id)
+            self.set_vmid_backup(backup_id, bk_id_vmids)
+            return True
+
+    # delete vmid from backup job
+    def backup_delete_vmid(self, vm_id):
+        bkID_delvm = []
+        backupList = self.get_cluster_bklist()
+        for backupItem in backupList:
+            vmids = list(backupItem['vmid'].split(','))
+            if vm_id in vmids:
+                if len(vmids) > 1:
+                    vmids.remove(vm_id)
+                    new_vmids = ','.join(map(str, vmids))
+                    self.set_vmid_backup(backupItem['id'], new_vmids)
+                    bkID_delvm.append(backupItem['id'])
+                else:
+                    self.module.fail_json(msg="No more than one vmid is assigned to %s. You just can remove job." % backupItem['id'])
+        return bkID_delvm
+
+
+# main function
+def main():
+    # Define module args
+    args = proxmox_auth_argument_spec()
+    backup_schedule_args = dict(
+        vm_name=dict(type='str'),
+        vm_id=dict(type='str'),
+        backup_id=dict(type='str'),
+        backup_action=dict(type='str', required=True)
+    )
+    args.update(backup_schedule_args)
+
+    module = AnsibleModule(
+        argument_spec=args,
+        mutually_exclusive=[('vm_id', 'vm_name')],
+        supports_check_mode=True
+    )
+
+    # Define (init) result value
+    result = dict(
+        changed=False,
+        message=''
+    )
+
+    # Check if proxmoxer exist
+    if not HAS_PROXMOXER:
+        module.fail_json(msg=missing_required_lib('proxmoxer'), exception=PROXMOXER_IMP_ERR)
+
+    # Start to connect to proxmox to get backup data
+    proxmox = ProxmoxSetVMBackupAnsible(module)
+    vm_name = module.params['vm_name']
+    vm_id = module.params['vm_id']
+    backup_id = module.params['backup_id']
+    backup_action = module.params['backup_action']
+
+    if vm_name:
+        vm_id = proxmox.vmname_2_vmid(vm_name)
+
+    if backup_action == 'update_vmid':
+        result['backup_schedule'] = proxmox.backup_update_vmid(vm_id, backup_id)
+
+    if backup_action == 'delete_vmid':
+        result['backup_schedule'] = proxmox.backup_delete_vmid(vm_id)
+
+    if result['backup_schedule']:
+        result['changed'] = True
+        result['message'] = 'The backup schedule has been changed successfully'
+
+    module.exit_json(**result)
+
+
+if __name__ == '__main__':
+    main()
diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
new file mode 100644
index 0000000000..e042254ae8
--- /dev/null
+++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
@@ -0,0 +1,238 @@
+# -*- coding: utf-8 -*-
+#
+# Copyright (c) 2025 Marzieh Raoufnezhad <raoufnezhad at gmail.com>
+# Copyright (c) 2025 Maryam Mayabi <mayabi.ahm at gmail.com>
+# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
+# SPDX-License-Identifier: GPL-3.0-or-later
+
+from __future__ import absolute_import, division, print_function
+
+__metaclass__ = type
+
+import sys
+import pytest
+
+proxmoxer = pytest.importorskip("proxmoxer")
+mandatory_py_version = pytest.mark.skipif(
+    sys.version_info < (2, 7),
+    reason="The proxmoxer dependency requires python2.7 or higher",
+)
+
+from ansible_collections.community.general.plugins.modules import proxmox_backup_schedule
+from ansible_collections.community.general.tests.unit.compat.mock import patch
+from ansible_collections.community.general.tests.unit.plugins.modules.utils import (
+    AnsibleExitJson,
+    AnsibleFailJson,
+    ModuleTestCase,
+    set_module_args,
+)
+import ansible_collections.community.general.plugins.module_utils.proxmox as proxmox_utils
+
+RESOURCE_LIST = [
+    {
+        "uptime": 0,
+        "diskwrite": 0,
+        "name": "test01",
+        "maxcpu": 0,
+        "node": "NODE1",
+        "mem": 0,
+        "netout": 0,
+        "netin": 0,
+        "maxmem": 0,
+        "diskread": 0,
+        "disk": 0,
+        "maxdisk": 0,
+        "status": "running",
+        "cpu": 0,
+        "id": "qemu/100",
+        "template": 0,
+        "vmid": 100,
+        "type": "qemu"
+    },
+    {
+        "uptime": 0,
+        "diskwrite": 0,
+        "name": "test02",
+        "maxcpu": 0,
+        "node": "NODE1",
+        "mem": 0,
+        "netout": 0,
+        "netin": 0,
+        "maxmem": 0,
+        "diskread": 0,
+        "disk": 0,
+        "maxdisk": 0,
+        "status": "running",
+        "cpu": 0,
+        "id": "qemu/101",
+        "template": 0,
+        "vmid": 101,
+        "type": "qemu"
+    },
+    {
+        "uptime": 0,
+        "diskwrite": 0,
+        "name": "test03",
+        "maxcpu": 0,
+        "node": "NODE2",
+        "mem": 0,
+        "netout": 0,
+        "netin": 0,
+        "maxmem": 0,
+        "diskread": 0,
+        "disk": 0,
+        "maxdisk": 0,
+        "status": "running",
+        "cpu": 0,
+        "id": "qemu/102",
+        "template": 0,
+        "vmid": 102,
+        "type": "qemu"
+    },
+    {
+        "uptime": 0,
+        "diskwrite": 0,
+        "name": "test04",
+        "maxcpu": 0,
+        "node": "NODE3",
+        "mem": 0,
+        "netout": 0,
+        "netin": 0,
+        "maxmem": 0,
+        "diskread": 0,
+        "disk": 0,
+        "maxdisk": 0,
+        "status": "running",
+        "cpu": 0,
+        "id": "qemu/103",
+        "template": 0,
+        "vmid": 103,
+        "type": "qemu"
+    },
+    {
+        "uptime": 0,
+        "diskwrite": 0,
+        "name": "test05",
+        "maxcpu": 0,
+        "node": "NODE3",
+        "mem": 0,
+        "netout": 0,
+        "netin": 0,
+        "maxmem": 0,
+        "diskread": 0,
+        "disk": 0,
+        "maxdisk": 0,
+        "status": "running",
+        "cpu": 0,
+        "id": "qemu/105",
+        "template": 0,
+        "vmid": 105,
+        "type": "qemu"
+    }
+]
+
+BACKUP_JOBS = [
+    {
+        "type": "vzdump",
+        "id": "backup-001",
+        "storage": "local",
+        "vmid": "100,101",
+        "enabled": 1,
+        "next-run": 1735138800,
+        "mailnotification": "always",
+        "schedule": "06,18:30",
+        "mode": "snapshot",
+        "notes-template": "{{guestname}}"
+    },
+    {
+        "schedule": "sat 15:00",
+        "notes-template": "{{guestname}}",
+        "mode": "snapshot",
+        "mailnotification": "always",
+        "next-run": 1735385400,
+        "type": "vzdump",
+        "enabled": 1,
+        "vmid": "101,102,103",
+        "storage": "local",
+        "id": "backup-002",
+    }
+]
+
+BACKUP_JOB_SPECIFIC_BKID = {
+    "enabled": 1,
+    "id": "backup-001",
+    "mailnotification": "always",
+    "mode": "snapshot",
+    "compress": "zstd",
+    "notes-template": "{{guestname}}",
+    "schedule": "06,18:30",
+    "storage": "local",
+    "type": "vzdump",
+    "vmid": "100,101"
+}
+EXPECTED_UPDATE_BACKUP_SCHEDULE = True
+EXPECTED_DEL_BACKUP_SCHEDULE = ["backup-001", "backup-002"]
+
+
+class TestProxmoxBackupScheduleModule(ModuleTestCase):
+    def setUp(self):
+        super(TestProxmoxBackupScheduleModule, self).setUp()
+        proxmox_utils.HAS_PROXMOXER = True
+        self.module = proxmox_backup_schedule
+        self.connect_mock = patch(
+            "ansible_collections.community.general.plugins.module_utils.proxmox.ProxmoxAnsible._connect",
+        ).start()
+        self.connect_mock.return_value.cluster.resources.get.return_value = (
+            RESOURCE_LIST
+        )
+        self.connect_mock.return_value.cluster.backup.get.side_effect = (
+            lambda backup_id=None: BACKUP_JOBS if backup_id is None else [job for job in BACKUP_JOBS if job['id'] == backup_id]
+        )
+
+    def tearDown(self):
+        self.connect_mock.stop()
+        super(TestProxmoxBackupScheduleModule, self).tearDown()
+
+    def test_module_fail_when_required_args_missing(self):
+        with pytest.raises(AnsibleFailJson) as exc_info:
+            set_module_args({})
+            self.module.main()
+
+        result = exc_info.value.args[0]
+        assert result["msg"] == "missing required arguments: api_host, api_user, backup_action"
+
+    def test_update_vmid_in_backup(self):
+        with pytest.raises(AnsibleExitJson) as exc_info:
+            set_module_args({
+                'api_host': 'proxmoxhost',
+                'api_user': 'root@pam',
+                'api_password': 'supersecret',
+                'vm_name': 'test05',
+                'backup_id': 'backup-001',
+                'backup_action': 'update_vmid'
+            })
+            self.module.main()
+
+        result = exc_info.value.args[0]
+
+        assert result['changed'] is True
+        assert result['backup_schedule'] == EXPECTED_UPDATE_BACKUP_SCHEDULE
+
+    def test_delete_vmid_from_backup(self):
+        with pytest.raises(AnsibleExitJson) as exc_info:
+            set_module_args({
+                'api_host': 'proxmoxhost',
+                'api_user': 'root@pam',
+                'api_password': 'supersecret',
+                'vm_id': 101,
+                'backup_action': 'delete_vmid'
+            })
+            self.module.main()
+
+        result = exc_info.value.args[0]
+        assert result['changed'] is True
+        assert result['backup_schedule'] == EXPECTED_DEL_BACKUP_SCHEDULE
+
+
+if __name__ == '__main__':
+    pytest.main([__file__])

From 53b5ce42aef7aee5128f4b8f43b0e7a9dcd4bf7b Mon Sep 17 00:00:00 2001
From: mayabi <mayabi.ahm@gmail.com>
Date: Fri, 31 Jan 2025 15:52:48 +0330
Subject: [PATCH 02/31] resolve nontype error for return documentation

---
 plugins/modules/proxmox_backup_schedule.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/modules/proxmox_backup_schedule.py b/plugins/modules/proxmox_backup_schedule.py
index a205bcc884..37c10b0e20 100644
--- a/plugins/modules/proxmox_backup_schedule.py
+++ b/plugins/modules/proxmox_backup_schedule.py
@@ -90,7 +90,7 @@ EXAMPLES = """
 
 RETURN = """
 ---
-  backup_schedule:
+backup_schedule:
   description:
     - When backup_action is 'update_vmid', the backup_schedule will return True after successfully adding the VM ID to the backup job.
     - When backup_action is 'delete_vmid', the backup_schedule will return a list of backup job IDs where the VM ID has been removed.

From 5a3e20faadb3c56724dbcc734c6320c8730a05e3 Mon Sep 17 00:00:00 2001
From: mayabi <mayabi.ahm@gmail.com>
Date: Fri, 31 Jan 2025 16:04:18 +0330
Subject: [PATCH 03/31] define choices for backup_action in argument_spec

---
 plugins/modules/proxmox_backup_schedule.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/plugins/modules/proxmox_backup_schedule.py b/plugins/modules/proxmox_backup_schedule.py
index 37c10b0e20..37ee118e7a 100644
--- a/plugins/modules/proxmox_backup_schedule.py
+++ b/plugins/modules/proxmox_backup_schedule.py
@@ -42,7 +42,7 @@ options:
         - If V(update_vmid), the module will update backup job with new VM ID.
         - If V(delete_vmid), the module will remove the VM ID from all backup jobs where the VM ID has existed.
     required: true
-    choices: [update_vmid, delete_vmid]
+    choices: ["update_vmid", "delete_vmid"]
     type: str
 
 extends_documentation_fragment:
@@ -180,7 +180,7 @@ def main():
         vm_name=dict(type='str'),
         vm_id=dict(type='str'),
         backup_id=dict(type='str'),
-        backup_action=dict(type='str', required=True)
+        backup_action=dict(choices=['update_vmid', 'delete_vmid'], required=True)
     )
     args.update(backup_schedule_args)
 

From 942bb393047c7654dc3fbf4a7f5cae65bc2547d2 Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Sat, 1 Feb 2025 08:50:55 +0330
Subject: [PATCH 04/31] Update RETURN section in proxmox_backup_schedule module

---
 plugins/modules/proxmox_backup_schedule.py | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/plugins/modules/proxmox_backup_schedule.py b/plugins/modules/proxmox_backup_schedule.py
index 37ee118e7a..e1266fd6d7 100644
--- a/plugins/modules/proxmox_backup_schedule.py
+++ b/plugins/modules/proxmox_backup_schedule.py
@@ -90,15 +90,17 @@ EXAMPLES = """
 
 RETURN = """
 ---
-backup_schedule:
-  description:
-    - When backup_action is 'update_vmid', the backup_schedule will return True after successfully adding the VM ID to the backup job.
-    - When backup_action is 'delete_vmid', the backup_schedule will return a list of backup job IDs where the VM ID has been removed.
-  returned: always, but can be empty
-  type: bool | list
-  sample:
-    - True
-    - ['backup-job-id1', 'backup-job-id2']
+update_result:
+  description: True if the VM ID was successfully added to the backup job.
+  returned: when backup_action is 'update_vmid'
+  type: bool
+  sample: true
+
+delete_result:
+  description: A list of backup job IDs where the VM ID has been removed.
+  returned: when backup_action is 'delete_vmid'
+  type: list
+  sample: ['backup-job-id1', 'backup-job-id2']
 """
 
 from ansible.module_utils.basic import AnsibleModule, missing_required_lib

From a48fe7ae667932469df95797888dac26b6afdf52 Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Sat, 1 Feb 2025 09:56:37 +0330
Subject: [PATCH 05/31] Update  license in proxmox_backup_schedule.py

---
 plugins/modules/proxmox_backup_schedule.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/modules/proxmox_backup_schedule.py b/plugins/modules/proxmox_backup_schedule.py
index e1266fd6d7..e62c96a157 100644
--- a/plugins/modules/proxmox_backup_schedule.py
+++ b/plugins/modules/proxmox_backup_schedule.py
@@ -2,7 +2,7 @@
 # -*- coding: utf-8 -*-
 #
 # Copyright (c) 2025 Marzieh Raoufnezhad <raoufnezhad@gmail.com>
-# Copyright (c) 2024 Maryam Mayabi <mayabi.ahm at gmail.com>
+# Copyright (c) 2025 Maryam Mayabi <mayabi.ahm at gmail.com>
 # GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
 # SPDX-License-Identifier: GPL-3.0-or-later
 

From dbc9b41e7d48c3d37b5941f3d276ee1663cdc98b Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Tue, 4 Feb 2025 08:17:02 +0330
Subject: [PATCH 06/31] check again the proxmox_backup_schedule.py module


From ef96ba85ef2f0e1076edc59ba82ea17641c548bd Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Wed, 5 Feb 2025 08:33:57 +0330
Subject: [PATCH 07/31] Update the RETURN description of
 proxmox_backup_schedule.py

---
 plugins/modules/proxmox_backup_schedule.py | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/plugins/modules/proxmox_backup_schedule.py b/plugins/modules/proxmox_backup_schedule.py
index e62c96a157..c793e65b4a 100644
--- a/plugins/modules/proxmox_backup_schedule.py
+++ b/plugins/modules/proxmox_backup_schedule.py
@@ -90,17 +90,13 @@ EXAMPLES = """
 
 RETURN = """
 ---
-update_result:
-  description: True if the VM ID was successfully added to the backup job.
-  returned: when backup_action is 'update_vmid'
-  type: bool
-  sample: true
-
-delete_result:
-  description: A list of backup job IDs where the VM ID has been removed.
-  returned: when backup_action is 'delete_vmid'
-  type: list
-  sample: ['backup-job-id1', 'backup-job-id2']
+backup_schedule:
+  description:
+    - If V(update_vmid), the backup_schedule will return True after adding the VM ID to the backup job.
+    - If V(delete_vmid), the backup_schedule will return a list of backup job IDs where the VM ID has existed after removing it.
+  returned: always, but can be empty
+  type: any
+  sample: "true or ['backup-job-id1', 'backup-job-id2']"
 """
 
 from ansible.module_utils.basic import AnsibleModule, missing_required_lib

From eae9eae4147e32bd5bd26f607a4d80ce04c83f78 Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Wed, 5 Feb 2025 09:01:24 +0330
Subject: [PATCH 08/31] Update the RETURN of proxmox_backup_schedule.py again

---
 plugins/modules/proxmox_backup_schedule.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/plugins/modules/proxmox_backup_schedule.py b/plugins/modules/proxmox_backup_schedule.py
index c793e65b4a..9070454dbd 100644
--- a/plugins/modules/proxmox_backup_schedule.py
+++ b/plugins/modules/proxmox_backup_schedule.py
@@ -95,8 +95,10 @@ backup_schedule:
     - If V(update_vmid), the backup_schedule will return True after adding the VM ID to the backup job.
     - If V(delete_vmid), the backup_schedule will return a list of backup job IDs where the VM ID has existed after removing it.
   returned: always, but can be empty
-  type: any
-  sample: "true or ['backup-job-id1', 'backup-job-id2']"
+  type: raw
+  sample:
+    - true
+    - ['backup-job-id1', 'backup-job-id2']
 """
 
 from ansible.module_utils.basic import AnsibleModule, missing_required_lib

From 575648f5d889302bae2948d0d17ea7a11be38243 Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Mon, 3 Mar 2025 08:32:25 +0330
Subject: [PATCH 09/31] Update proxmox_backup_schedule.py

---
 plugins/modules/proxmox_backup_schedule.py | 86 ++++++++++++++--------
 1 file changed, 54 insertions(+), 32 deletions(-)

diff --git a/plugins/modules/proxmox_backup_schedule.py b/plugins/modules/proxmox_backup_schedule.py
index 9070454dbd..99d77cc6b0 100644
--- a/plugins/modules/proxmox_backup_schedule.py
+++ b/plugins/modules/proxmox_backup_schedule.py
@@ -13,7 +13,7 @@ DOCUMENTATION = """
 ---
 module: proxmox_backup_schedule
 
-short_description: Scheduling VM backups and removing it.
+short_description: Scheduling VM backups and removing them.
 
 version_added: 10.3.0
 
@@ -37,12 +37,12 @@ options:
   backup_id:
     description: The backup job ID.
     type: str
-  backup_action:
+  state:
     description:
-        - If V(update_vmid), the module will update backup job with new VM ID.
-        - If V(delete_vmid), the module will remove the VM ID from all backup jobs where the VM ID has existed.
+        - If V(present), the module will update backup job with new VM ID.
+        - If V(absent), the module will remove the VM ID from all backup jobs where the VM ID has existed.
     required: true
-    choices: ["update_vmid", "delete_vmid"]
+    choices: ["present", "absent"]
     type: str
 
 extends_documentation_fragment:
@@ -53,47 +53,47 @@ extends_documentation_fragment:
 """
 
 EXAMPLES = """
-- name: Scheduling VM Backups based on VM name.
+- name: Scheduling VM Backups based on VM name
   proxmox_backup_schedule:
     api_user: 'myUser@pam'
     api_password: '*******'
     api_host: '192.168.20.20'
     vm_name: 'VM Name'
     backup_id: 'backup-b2adffdc-316e'
-    backup_action: 'update_vmid'
+    state: 'present'
 
-- name: Scheduling VM Backups based on VM ID.
+- name: Scheduling VM Backups based on VM ID
   proxmox_backup_schedule:
     api_user: 'myUser@pam'
     api_password: '*******'
     api_host: '192.168.20.20'
     vm_id: 'VM ID'
     backup_id: 'backup-b2adffdc-316e'
-    backup_action: 'update_vmid'
+    state: 'present'
 
-- name: Removing backup setting based on VM name.
+- name: Removing backup setting based on VM name
   proxmox_backup_schedule:
     api_user: 'myUser@pam'
     api_password: '*******'
     api_host: '192.168.20.20'
     vm_name: 'VM Name'
-    backup_action: 'delete_vmid'
+    state: 'absent'
 
-- name: Removing backup setting based on VM ID.
+- name: Removing backup setting based on VM ID
   proxmox_backup_schedule:
     api_user: 'myUser@pam'
     api_password: '*******'
     api_host: '192.168.20.20'
     vm_id: 'VM ID'
-    backup_action: 'delete_vmid'
+    state: 'absent'
 """
 
 RETURN = """
 ---
 backup_schedule:
   description:
-    - If V(update_vmid), the backup_schedule will return True after adding the VM ID to the backup job.
-    - If V(delete_vmid), the backup_schedule will return a list of backup job IDs where the VM ID has existed after removing it.
+    - If V(present), the backup_schedule will return True after adding the VM ID to the backup job.
+    - If V(absent), the backup_schedule will return a list of backup job IDs where the VM ID has existed after removing it.
   returned: always, but can be empty
   type: raw
   sample:
@@ -143,7 +143,7 @@ class ProxmoxSetVMBackupAnsible(ProxmoxAnsible):
         return (vms[0]['vmid'])
 
     # add vmid to backup job
-    def backup_update_vmid(self, vm_id, backup_id):
+    def backup_present(self, vm_id, backup_id):
         bk_id_info = self.get_cluster_specific_bkjobid(backup_id)
 
         # If bk_id_info is a list, get the first item (assuming there's only one backup job returned)
@@ -154,22 +154,42 @@ class ProxmoxSetVMBackupAnsible(ProxmoxAnsible):
             bk_id_vmids = bk_id_info['vmid'] + ',' + str(vm_id)
             self.set_vmid_backup(backup_id, bk_id_vmids)
             return True
+        else:
+            return False
 
     # delete vmid from backup job
-    def backup_delete_vmid(self, vm_id):
-        bkID_delvm = []
-        backupList = self.get_cluster_bklist()
-        for backupItem in backupList:
-            vmids = list(backupItem['vmid'].split(','))
+    def backup_absent(self, vm_id, backup_id):
+        if backup_id:
+            bk_id_info = self.get_cluster_specific_bkjobid(backup_id)
+            if isinstance(bk_id_info, list):
+                bk_id_info = bk_id_info[0]  # Access the first item in the list
+            vmids = bk_id_info['vmid'].split(',')
             if vm_id in vmids:
                 if len(vmids) > 1:
                     vmids.remove(vm_id)
                     new_vmids = ','.join(map(str, vmids))
-                    self.set_vmid_backup(backupItem['id'], new_vmids)
-                    bkID_delvm.append(backupItem['id'])
+                    self.set_vmid_backup(bk_id_info['id'], new_vmids)
+                    return True
                 else:
-                    self.module.fail_json(msg="No more than one vmid is assigned to %s. You just can remove job." % backupItem['id'])
-        return bkID_delvm
+                    self.module.fail_json(msg="No more than one vmid is assigned to %s. You just can remove job." % bk_id_info['id'])
+            return False
+        else:
+            bkID_delvm = []
+            backupList = self.get_cluster_bklist()
+            for backupItem in backupList:
+                vmids = list(backupItem['vmid'].split(','))
+                if vm_id in vmids:
+                    if len(vmids) > 1:
+                        vmids.remove(vm_id)
+                        new_vmids = ','.join(map(str, vmids))
+                        self.set_vmid_backup(backupItem['id'], new_vmids)
+                        bkID_delvm.append(backupItem['id'])
+                    else:
+                        self.module.fail_json(msg="No more than one vmid is assigned to %s. You just can remove job." % backupItem['id'])
+            if bkID_delvm:
+                return True
+            else:
+                return False
 
 
 # main function
@@ -180,7 +200,7 @@ def main():
         vm_name=dict(type='str'),
         vm_id=dict(type='str'),
         backup_id=dict(type='str'),
-        backup_action=dict(choices=['update_vmid', 'delete_vmid'], required=True)
+        state=dict(choices=['present', 'absent'], required=True)
     )
     args.update(backup_schedule_args)
 
@@ -205,20 +225,22 @@ def main():
     vm_name = module.params['vm_name']
     vm_id = module.params['vm_id']
     backup_id = module.params['backup_id']
-    backup_action = module.params['backup_action']
+    state = module.params['state']
 
     if vm_name:
         vm_id = proxmox.vmname_2_vmid(vm_name)
 
-    if backup_action == 'update_vmid':
-        result['backup_schedule'] = proxmox.backup_update_vmid(vm_id, backup_id)
+    if state == 'present':
+        result['backup_schedule'] = proxmox.backup_present(vm_id, backup_id)
 
-    if backup_action == 'delete_vmid':
-        result['backup_schedule'] = proxmox.backup_delete_vmid(vm_id)
+    if state == 'absent':
+        result['backup_schedule'] = proxmox.backup_absent(vm_id, backup_id)
 
     if result['backup_schedule']:
         result['changed'] = True
-        result['message'] = 'The backup schedule has been changed successfully'
+        result['message'] = 'The backup schedule has been changed successfully.'
+    else:
+        result['message'] = 'The backup schedule did not change anything.'
 
     module.exit_json(**result)
 

From cf99474d1c3d37a97af45b0a83f2bce14cee1167 Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Mon, 3 Mar 2025 08:32:47 +0330
Subject: [PATCH 10/31] Update test_proxmox_backup_schedule.py

---
 .../unit/plugins/modules/test_proxmox_backup_schedule.py  | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
index e042254ae8..13358f3c5c 100644
--- a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
+++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
@@ -171,7 +171,7 @@ BACKUP_JOB_SPECIFIC_BKID = {
     "vmid": "100,101"
 }
 EXPECTED_UPDATE_BACKUP_SCHEDULE = True
-EXPECTED_DEL_BACKUP_SCHEDULE = ["backup-001", "backup-002"]
+EXPECTED_DEL_BACKUP_SCHEDULE = True 
 
 
 class TestProxmoxBackupScheduleModule(ModuleTestCase):
@@ -199,7 +199,7 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
             self.module.main()
 
         result = exc_info.value.args[0]
-        assert result["msg"] == "missing required arguments: api_host, api_user, backup_action"
+        assert result["msg"] == "missing required arguments: api_host, api_user, state"
 
     def test_update_vmid_in_backup(self):
         with pytest.raises(AnsibleExitJson) as exc_info:
@@ -209,7 +209,7 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
                 'api_password': 'supersecret',
                 'vm_name': 'test05',
                 'backup_id': 'backup-001',
-                'backup_action': 'update_vmid'
+                'state': 'present'
             })
             self.module.main()
 
@@ -225,7 +225,7 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
                 'api_user': 'root@pam',
                 'api_password': 'supersecret',
                 'vm_id': 101,
-                'backup_action': 'delete_vmid'
+                'state': 'absent'
             })
             self.module.main()
 

From 20069dce8c3f06a87167c1258767f2c4b11fb402 Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Mon, 3 Mar 2025 09:02:08 +0330
Subject: [PATCH 11/31] Fix trailing whitespace err in
 test_proxmox_backup_schedule.py

---
 tests/unit/plugins/modules/test_proxmox_backup_schedule.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
index 13358f3c5c..0c2186f402 100644
--- a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
+++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
@@ -171,7 +171,7 @@ BACKUP_JOB_SPECIFIC_BKID = {
     "vmid": "100,101"
 }
 EXPECTED_UPDATE_BACKUP_SCHEDULE = True
-EXPECTED_DEL_BACKUP_SCHEDULE = True 
+EXPECTED_DEL_BACKUP_SCHEDULE = True
 
 
 class TestProxmoxBackupScheduleModule(ModuleTestCase):

From 8afd207c821fc3078ae2ffcc95047de6401bc595 Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Mon, 3 Mar 2025 11:58:33 +0330
Subject: [PATCH 12/31] Update backup_absent function in
 proxmox_backup_schedule.py

---
 plugins/modules/proxmox_backup_schedule.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/plugins/modules/proxmox_backup_schedule.py b/plugins/modules/proxmox_backup_schedule.py
index 99d77cc6b0..ec39246f1b 100644
--- a/plugins/modules/proxmox_backup_schedule.py
+++ b/plugins/modules/proxmox_backup_schedule.py
@@ -150,7 +150,7 @@ class ProxmoxSetVMBackupAnsible(ProxmoxAnsible):
         if isinstance(bk_id_info, list):
             bk_id_info = bk_id_info[0]  # Access the first item in the list
         vms_id = bk_id_info['vmid'].split(',')
-        if vm_id not in vms_id:
+        if str(vm_id) not in vms_id:
             bk_id_vmids = bk_id_info['vmid'] + ',' + str(vm_id)
             self.set_vmid_backup(backup_id, bk_id_vmids)
             return True
@@ -164,9 +164,9 @@ class ProxmoxSetVMBackupAnsible(ProxmoxAnsible):
             if isinstance(bk_id_info, list):
                 bk_id_info = bk_id_info[0]  # Access the first item in the list
             vmids = bk_id_info['vmid'].split(',')
-            if vm_id in vmids:
+            if str(vm_id) in vmids:
                 if len(vmids) > 1:
-                    vmids.remove(vm_id)
+                    vmids.remove(str(vm_id))
                     new_vmids = ','.join(map(str, vmids))
                     self.set_vmid_backup(bk_id_info['id'], new_vmids)
                     return True
@@ -178,9 +178,9 @@ class ProxmoxSetVMBackupAnsible(ProxmoxAnsible):
             backupList = self.get_cluster_bklist()
             for backupItem in backupList:
                 vmids = list(backupItem['vmid'].split(','))
-                if vm_id in vmids:
+                if str(vm_id) in vmids:
                     if len(vmids) > 1:
-                        vmids.remove(vm_id)
+                        vmids.remove(str(vm_id))
                         new_vmids = ','.join(map(str, vmids))
                         self.set_vmid_backup(backupItem['id'], new_vmids)
                         bkID_delvm.append(backupItem['id'])

From 2f7469be42ee6a0dec386af7f756b8f4e41a412e Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Mon, 3 Mar 2025 12:30:27 +0330
Subject: [PATCH 13/31] change description in proxmox_backup_schedule.py

---
 plugins/modules/proxmox_backup_schedule.py | 26 +++++++++++++++++-----
 1 file changed, 20 insertions(+), 6 deletions(-)

diff --git a/plugins/modules/proxmox_backup_schedule.py b/plugins/modules/proxmox_backup_schedule.py
index ec39246f1b..02281efe22 100644
--- a/plugins/modules/proxmox_backup_schedule.py
+++ b/plugins/modules/proxmox_backup_schedule.py
@@ -86,6 +86,24 @@ EXAMPLES = """
     api_host: '192.168.20.20'
     vm_id: 'VM ID'
     state: 'absent'
+
+- name: Removing backup setting based on VM name from specific backup job
+  proxmox_backup_schedule:
+    api_user: 'myUser@pam'
+    api_password: '*******'
+    api_host: '192.168.20.20'
+    vm_name: 'VM Name'
+    backup_id: 'backup-b2adffdc-316e'
+    state: 'absent'
+
+- name: Removing backup setting based on VM ID from specific backup job
+  proxmox_backup_schedule:
+    api_user: 'myUser@pam'
+    api_password: '*******'
+    api_host: '192.168.20.20'
+    vm_id: 'VM ID'
+    backup_id: 'backup-b2adffdc-316e'
+    state: 'absent'
 """
 
 RETURN = """
@@ -93,12 +111,8 @@ RETURN = """
 backup_schedule:
   description:
     - If V(present), the backup_schedule will return True after adding the VM ID to the backup job.
-    - If V(absent), the backup_schedule will return a list of backup job IDs where the VM ID has existed after removing it.
-  returned: always, but can be empty
-  type: raw
-  sample:
-    - true
-    - ['backup-job-id1', 'backup-job-id2']
+    - If V(absent), the backup_schedule will return True after removing it from the backup job.
+  returned: always, but can be empty  
 """
 
 from ansible.module_utils.basic import AnsibleModule, missing_required_lib

From d88bad4b053eba05d0dd168f44171aed34430c60 Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Mon, 3 Mar 2025 12:59:00 +0330
Subject: [PATCH 14/31] Fix trailing whitespace Err in
 proxmox_backup_schedule.py

---
 plugins/modules/proxmox_backup_schedule.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/modules/proxmox_backup_schedule.py b/plugins/modules/proxmox_backup_schedule.py
index 02281efe22..390d84f19a 100644
--- a/plugins/modules/proxmox_backup_schedule.py
+++ b/plugins/modules/proxmox_backup_schedule.py
@@ -112,7 +112,7 @@ backup_schedule:
   description:
     - If V(present), the backup_schedule will return True after adding the VM ID to the backup job.
     - If V(absent), the backup_schedule will return True after removing it from the backup job.
-  returned: always, but can be empty  
+  returned: always, but can be empty
 """
 
 from ansible.module_utils.basic import AnsibleModule, missing_required_lib

From f9e94451c26d11173cb198d5d452e8bafa33f1bf Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Mon, 3 Mar 2025 13:28:07 +0330
Subject: [PATCH 15/31] Update RETURN proxmox_backup_schedule.py

---
 plugins/modules/proxmox_backup_schedule.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/plugins/modules/proxmox_backup_schedule.py b/plugins/modules/proxmox_backup_schedule.py
index 390d84f19a..cdc542af1b 100644
--- a/plugins/modules/proxmox_backup_schedule.py
+++ b/plugins/modules/proxmox_backup_schedule.py
@@ -113,6 +113,7 @@ backup_schedule:
     - If V(present), the backup_schedule will return True after adding the VM ID to the backup job.
     - If V(absent), the backup_schedule will return True after removing it from the backup job.
   returned: always, but can be empty
+  type: raw
 """
 
 from ansible.module_utils.basic import AnsibleModule, missing_required_lib

From da892cfba317e7c43fc6dff5b185d1c2e31e3836 Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Sat, 15 Mar 2025 12:50:55 +0330
Subject: [PATCH 16/31] Update proxmox_backup_schedule.py

---
 plugins/modules/proxmox_backup_schedule.py | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/plugins/modules/proxmox_backup_schedule.py b/plugins/modules/proxmox_backup_schedule.py
index cdc542af1b..83975fe078 100644
--- a/plugins/modules/proxmox_backup_schedule.py
+++ b/plugins/modules/proxmox_backup_schedule.py
@@ -13,9 +13,9 @@ DOCUMENTATION = """
 ---
 module: proxmox_backup_schedule
 
-short_description: Scheduling VM backups and removing them.
+short_description: Schedule VM backups and remove them
 
-version_added: 10.3.0
+version_added: 10.5.0
 
 description: The module modifies backup jobs such as set or delete C(vmid).
 
@@ -108,12 +108,12 @@ EXAMPLES = """
 
 RETURN = """
 ---
-backup_schedule:
+changed:
   description:
-    - If V(present), the backup_schedule will return True after adding the VM ID to the backup job.
-    - If V(absent), the backup_schedule will return True after removing it from the backup job.
+    - If V(present), the changed will return True after adding the VM ID to the backup job.
+    - If V(absent), the changed will return True after removing it from the backup job.
   returned: always, but can be empty
-  type: raw
+  type: bool
 """
 
 from ansible.module_utils.basic import AnsibleModule, missing_required_lib
@@ -246,12 +246,12 @@ def main():
         vm_id = proxmox.vmname_2_vmid(vm_name)
 
     if state == 'present':
-        result['backup_schedule'] = proxmox.backup_present(vm_id, backup_id)
+        backup_schedule = proxmox.backup_present(vm_id, backup_id)
 
     if state == 'absent':
-        result['backup_schedule'] = proxmox.backup_absent(vm_id, backup_id)
+        backup_schedule = proxmox.backup_absent(vm_id, backup_id)
 
-    if result['backup_schedule']:
+    if backup_schedule:
         result['changed'] = True
         result['message'] = 'The backup schedule has been changed successfully.'
     else:

From c146625912d78da8f01394702ee409d66e7d9a3b Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Sat, 15 Mar 2025 13:12:50 +0330
Subject: [PATCH 17/31] Update test_proxmox_backup_schedule.py

---
 tests/unit/plugins/modules/test_proxmox_backup_schedule.py | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
index 0c2186f402..4cdfe13bfc 100644
--- a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
+++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
@@ -170,8 +170,6 @@ BACKUP_JOB_SPECIFIC_BKID = {
     "type": "vzdump",
     "vmid": "100,101"
 }
-EXPECTED_UPDATE_BACKUP_SCHEDULE = True
-EXPECTED_DEL_BACKUP_SCHEDULE = True
 
 
 class TestProxmoxBackupScheduleModule(ModuleTestCase):
@@ -214,9 +212,7 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
             self.module.main()
 
         result = exc_info.value.args[0]
-
         assert result['changed'] is True
-        assert result['backup_schedule'] == EXPECTED_UPDATE_BACKUP_SCHEDULE
 
     def test_delete_vmid_from_backup(self):
         with pytest.raises(AnsibleExitJson) as exc_info:
@@ -231,7 +227,6 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
 
         result = exc_info.value.args[0]
         assert result['changed'] is True
-        assert result['backup_schedule'] == EXPECTED_DEL_BACKUP_SCHEDULE
 
 
 if __name__ == '__main__':

From 7ff9e4b928c8129fb1e194f6874f81ed4d031f3c Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Mon, 17 Mar 2025 09:29:52 +0330
Subject: [PATCH 18/31] check again


From 2b58f5518bd17e4517b9cdd04cfabec352c6484e Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Mon, 17 Mar 2025 12:29:53 +0330
Subject: [PATCH 19/31] Update test_proxmox_backup_schedule.py

---
 tests/unit/plugins/modules/test_proxmox_backup_schedule.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
index 4cdfe13bfc..d077f2ac76 100644
--- a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
+++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
@@ -220,7 +220,7 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
                 'api_host': 'proxmoxhost',
                 'api_user': 'root@pam',
                 'api_password': 'supersecret',
-                'vm_id': 101,
+                'vm_id': '101',
                 'state': 'absent'
             })
             self.module.main()

From 8c3ff95648d873557bae1646760feed6e48baef7 Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Mon, 17 Mar 2025 13:30:38 +0330
Subject: [PATCH 20/31] Update test_proxmox_backup_schedule.py

---
 .../modules/test_proxmox_backup_schedule.py   | 50 ++++++++++---------
 1 file changed, 26 insertions(+), 24 deletions(-)

diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
index d077f2ac76..477f918a34 100644
--- a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
+++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
@@ -132,7 +132,7 @@ RESOURCE_LIST = [
 ]
 
 BACKUP_JOBS = [
-    {
+{
         "type": "vzdump",
         "id": "backup-001",
         "storage": "local",
@@ -200,33 +200,35 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
         assert result["msg"] == "missing required arguments: api_host, api_user, state"
 
     def test_update_vmid_in_backup(self):
-        with pytest.raises(AnsibleExitJson) as exc_info:
-            set_module_args({
-                'api_host': 'proxmoxhost',
-                'api_user': 'root@pam',
-                'api_password': 'supersecret',
-                'vm_name': 'test05',
-                'backup_id': 'backup-001',
-                'state': 'present'
-            })
-            self.module.main()
+        with patch('builtins.input', return_value='mocked input'):
+            with pytest.raises(AnsibleExitJson) as exc_info:
+                set_module_args({
+                    'api_host': 'proxmoxhost',
+                    'api_user': 'root@pam',
+                    'api_password': 'supersecret',
+                    'vm_name': 'test05',
+                    'backup_id': 'backup-001',
+                    'state': 'present'
+                })
+                self.module.main()
 
-        result = exc_info.value.args[0]
-        assert result['changed'] is True
+            result = exc_info.value.args[0]
+            assert result['changed'] is True
 
     def test_delete_vmid_from_backup(self):
-        with pytest.raises(AnsibleExitJson) as exc_info:
-            set_module_args({
-                'api_host': 'proxmoxhost',
-                'api_user': 'root@pam',
-                'api_password': 'supersecret',
-                'vm_id': '101',
-                'state': 'absent'
-            })
-            self.module.main()
+        with patch('builtins.input', return_value='mocked input'):
+            with pytest.raises(AnsibleExitJson) as exc_info:
+                set_module_args({
+                    'api_host': 'proxmoxhost',
+                    'api_user': 'root@pam',
+                    'api_password': 'supersecret',
+                    'vm_id': '101',
+                    'state': 'absent'
+                })
+                self.module.main()
 
-        result = exc_info.value.args[0]
-        assert result['changed'] is True
+            result = exc_info.value.args[0]
+            assert result['changed'] is True
 
 
 if __name__ == '__main__':

From 163bca335328574c96922ddf83f3d94df9418da0 Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Mon, 17 Mar 2025 13:54:59 +0330
Subject: [PATCH 21/31] fix PEP8 Err in test_proxmox_backup_schedule.py

---
 tests/unit/plugins/modules/test_proxmox_backup_schedule.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
index 477f918a34..f2f210c9f0 100644
--- a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
+++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
@@ -184,7 +184,9 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
             RESOURCE_LIST
         )
         self.connect_mock.return_value.cluster.backup.get.side_effect = (
-            lambda backup_id=None: BACKUP_JOBS if backup_id is None else [job for job in BACKUP_JOBS if job['id'] == backup_id]
+            lambda backup_id=None: BACKUP_JOBS if backup_id is None else [
+                job for job in BACKUP_JOBS if job['id'] == backup_id
+            ]
         )
 
     def tearDown(self):

From 4ce8f1a29fe94f852c9779de5eb02de4d023b3e1 Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Tue, 18 Mar 2025 10:38:54 +0330
Subject: [PATCH 22/31] fix Err closing bracket does not match in
 test_proxmox_backup_schedule.py

---
 tests/unit/plugins/modules/test_proxmox_backup_schedule.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
index f2f210c9f0..40ebf3057b 100644
--- a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
+++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
@@ -132,7 +132,7 @@ RESOURCE_LIST = [
 ]
 
 BACKUP_JOBS = [
-{
+    {
         "type": "vzdump",
         "id": "backup-001",
         "storage": "local",

From 070d60ba3065f2e6b6accb40a09adf2d3629b865 Mon Sep 17 00:00:00 2001
From: mayabi <mayabi@um.ac.ir>
Date: Sun, 30 Mar 2025 10:18:38 +0330
Subject: [PATCH 23/31] debug

---
 .../modules/test_proxmox_backup_schedule.py   | 52 +++++++++----------
 1 file changed, 25 insertions(+), 27 deletions(-)

diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
index 40ebf3057b..4bacd3c3bf 100644
--- a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
+++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
@@ -202,35 +202,33 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
         assert result["msg"] == "missing required arguments: api_host, api_user, state"
 
     def test_update_vmid_in_backup(self):
-        with patch('builtins.input', return_value='mocked input'):
-            with pytest.raises(AnsibleExitJson) as exc_info:
-                set_module_args({
-                    'api_host': 'proxmoxhost',
-                    'api_user': 'root@pam',
-                    'api_password': 'supersecret',
-                    'vm_name': 'test05',
-                    'backup_id': 'backup-001',
-                    'state': 'present'
-                })
-                self.module.main()
-
-            result = exc_info.value.args[0]
-            assert result['changed'] is True
+        with pytest.raises(AnsibleExitJson) as exc_info:
+            set_module_args({
+                'api_host': 'proxmoxhost',
+                'api_user': 'root@pam',
+                'api_password': 'supersecret',
+                'vm_name': 'test05',
+                'backup_id': 'backup-001',
+                'state': 'present'
+            })
+            self.module.main()
+        
+        result = exc_info.value.args[0]
+        assert result['changed'] is True
 
     def test_delete_vmid_from_backup(self):
-        with patch('builtins.input', return_value='mocked input'):
-            with pytest.raises(AnsibleExitJson) as exc_info:
-                set_module_args({
-                    'api_host': 'proxmoxhost',
-                    'api_user': 'root@pam',
-                    'api_password': 'supersecret',
-                    'vm_id': '101',
-                    'state': 'absent'
-                })
-                self.module.main()
-
-            result = exc_info.value.args[0]
-            assert result['changed'] is True
+        with pytest.raises(AnsibleExitJson) as exc_info:
+            set_module_args({
+                'api_host': 'proxmoxhost',
+                'api_user': 'root@pam',
+                'api_password': 'supersecret',
+                'vm_id': '101',
+                'state': 'absent'
+            })
+            self.module.main()
+        
+        result = exc_info.value.args[0]
+        assert result['changed'] is True
 
 
 if __name__ == '__main__':

From 0c747bb7fb59024369dc6a82f376a6b85e62c513 Mon Sep 17 00:00:00 2001
From: mayabi <mayabi@um.ac.ir>
Date: Sun, 30 Mar 2025 10:39:31 +0330
Subject: [PATCH 24/31] remove whitespaces

---
 tests/unit/plugins/modules/test_proxmox_backup_schedule.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
index 4bacd3c3bf..f381d714e5 100644
--- a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
+++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
@@ -212,7 +212,6 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
                 'state': 'present'
             })
             self.module.main()
-        
         result = exc_info.value.args[0]
         assert result['changed'] is True
 
@@ -226,7 +225,6 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
                 'state': 'absent'
             })
             self.module.main()
-        
         result = exc_info.value.args[0]
         assert result['changed'] is True
 

From b643de123ca9f1792520d403f11bce47326c5490 Mon Sep 17 00:00:00 2001
From: mayabi <mayabi@um.ac.ir>
Date: Sun, 30 Mar 2025 11:37:53 +0330
Subject: [PATCH 25/31] replace mock and compat with code from
 community.internal_test_tools

---
 tests/unit/plugins/modules/test_proxmox_backup_schedule.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
index f381d714e5..d1bd7706c2 100644
--- a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
+++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
@@ -19,7 +19,7 @@ mandatory_py_version = pytest.mark.skipif(
 )
 
 from ansible_collections.community.general.plugins.modules import proxmox_backup_schedule
-from ansible_collections.community.general.tests.unit.compat.mock import patch
+from ansible_collections.community.internal_test_tools.tests.unit.compat.mock import patch
 from ansible_collections.community.general.tests.unit.plugins.modules.utils import (
     AnsibleExitJson,
     AnsibleFailJson,

From a12300171eecb941088df07b9536290312c89fb7 Mon Sep 17 00:00:00 2001
From: mayabi <mayabi@um.ac.ir>
Date: Sun, 30 Mar 2025 12:23:25 +0330
Subject: [PATCH 26/31] debug assert expression

---
 .../modules/test_proxmox_backup_schedule.py     | 17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
index d1bd7706c2..b6bdf14bb8 100644
--- a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
+++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
@@ -158,19 +158,6 @@ BACKUP_JOBS = [
     }
 ]
 
-BACKUP_JOB_SPECIFIC_BKID = {
-    "enabled": 1,
-    "id": "backup-001",
-    "mailnotification": "always",
-    "mode": "snapshot",
-    "compress": "zstd",
-    "notes-template": "{{guestname}}",
-    "schedule": "06,18:30",
-    "storage": "local",
-    "type": "vzdump",
-    "vmid": "100,101"
-}
-
 
 class TestProxmoxBackupScheduleModule(ModuleTestCase):
     def setUp(self):
@@ -213,7 +200,7 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
             })
             self.module.main()
         result = exc_info.value.args[0]
-        assert result['changed'] is True
+        assert result['changed'] == True
 
     def test_delete_vmid_from_backup(self):
         with pytest.raises(AnsibleExitJson) as exc_info:
@@ -226,7 +213,7 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
             })
             self.module.main()
         result = exc_info.value.args[0]
-        assert result['changed'] is True
+        assert result['changed'] == True
 
 
 if __name__ == '__main__':

From 06f469e38a5659fcf640e13878243acf0f1c44a1 Mon Sep 17 00:00:00 2001
From: mayabi <mayabi@um.ac.ir>
Date: Sun, 30 Mar 2025 12:32:00 +0330
Subject: [PATCH 27/31] replace mock and compat with code from
 community.internal_test_tools

---
 tests/unit/plugins/modules/test_proxmox_backup_schedule.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
index b6bdf14bb8..0874854a8d 100644
--- a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
+++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
@@ -20,7 +20,7 @@ mandatory_py_version = pytest.mark.skipif(
 
 from ansible_collections.community.general.plugins.modules import proxmox_backup_schedule
 from ansible_collections.community.internal_test_tools.tests.unit.compat.mock import patch
-from ansible_collections.community.general.tests.unit.plugins.modules.utils import (
+from ansible_collections.community.internal_test_tools.tests.unit.plugins.modules.utils import (
     AnsibleExitJson,
     AnsibleFailJson,
     ModuleTestCase,
@@ -200,7 +200,7 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
             })
             self.module.main()
         result = exc_info.value.args[0]
-        assert result['changed'] == True
+        assert result['changed'] is True
 
     def test_delete_vmid_from_backup(self):
         with pytest.raises(AnsibleExitJson) as exc_info:
@@ -213,7 +213,7 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
             })
             self.module.main()
         result = exc_info.value.args[0]
-        assert result['changed'] == True
+        assert result['changed'] is True
 
 
 if __name__ == '__main__':

From 1b22c92ae83eee2abf6948b1eb73f34a49256ca5 Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Sun, 30 Mar 2025 13:12:49 +0330
Subject: [PATCH 28/31] add mock input in test_proxmox_backup_schedule.py

---
 .../modules/test_proxmox_backup_schedule.py   | 50 ++++++++++---------
 1 file changed, 27 insertions(+), 23 deletions(-)

diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
index 0874854a8d..34bdae38f6 100644
--- a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
+++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
@@ -189,31 +189,35 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
         assert result["msg"] == "missing required arguments: api_host, api_user, state"
 
     def test_update_vmid_in_backup(self):
-        with pytest.raises(AnsibleExitJson) as exc_info:
-            set_module_args({
-                'api_host': 'proxmoxhost',
-                'api_user': 'root@pam',
-                'api_password': 'supersecret',
-                'vm_name': 'test05',
-                'backup_id': 'backup-001',
-                'state': 'present'
-            })
-            self.module.main()
-        result = exc_info.value.args[0]
-        assert result['changed'] is True
+        with patch('builtins.input', return_value='mocked input'):
+            with pytest.raises(AnsibleExitJson) as exc_info:
+                set_module_args({
+                    'api_host': 'proxmoxhost',
+                    'api_user': 'root@pam',
+                    'api_password': 'supersecret',
+                    'vm_name': 'test05',
+                    'backup_id': 'backup-001',
+                    'state': 'present'
+                })
+                self.module.main()
+
+            result = exc_info.value.args[0]
+            assert result['changed'] is True
 
     def test_delete_vmid_from_backup(self):
-        with pytest.raises(AnsibleExitJson) as exc_info:
-            set_module_args({
-                'api_host': 'proxmoxhost',
-                'api_user': 'root@pam',
-                'api_password': 'supersecret',
-                'vm_id': '101',
-                'state': 'absent'
-            })
-            self.module.main()
-        result = exc_info.value.args[0]
-        assert result['changed'] is True
+        with patch('builtins.input', return_value='mocked input'):
+            with pytest.raises(AnsibleExitJson) as exc_info:
+                set_module_args({
+                    'api_host': 'proxmoxhost',
+                    'api_user': 'root@pam',
+                    'api_password': 'supersecret',
+                    'vm_id': '101',
+                    'state': 'absent'
+                })
+                self.module.main()
+
+            result = exc_info.value.args[0]
+            assert result['changed'] is True  
 
 
 if __name__ == '__main__':

From 1e4efeea0168d719ff08ab3493d72d70e0282986 Mon Sep 17 00:00:00 2001
From: raoufnezhad <72685312+raoufnezhad@users.noreply.github.com>
Date: Sun, 30 Mar 2025 13:17:57 +0330
Subject: [PATCH 29/31] fix trailing-whitespace error in
 test_proxmox_backup_schedule.py

---
 tests/unit/plugins/modules/test_proxmox_backup_schedule.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
index 34bdae38f6..c541facecc 100644
--- a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
+++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
@@ -217,7 +217,7 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
                 self.module.main()
 
             result = exc_info.value.args[0]
-            assert result['changed'] is True  
+            assert result['changed'] is True
 
 
 if __name__ == '__main__':

From aa1b757c3d537eca4b2a3c2906b7d1e7d0d2e390 Mon Sep 17 00:00:00 2001
From: mayabi <mayabi@um.ac.ir>
Date: Sun, 30 Mar 2025 13:47:31 +0330
Subject: [PATCH 30/31] add vm_id in result output

---
 plugins/modules/proxmox_backup_schedule.py    | 19 ++++---
 .../modules/test_proxmox_backup_schedule.py   | 55 +++++++++----------
 2 files changed, 37 insertions(+), 37 deletions(-)

diff --git a/plugins/modules/proxmox_backup_schedule.py b/plugins/modules/proxmox_backup_schedule.py
index 83975fe078..48a2d70d60 100644
--- a/plugins/modules/proxmox_backup_schedule.py
+++ b/plugins/modules/proxmox_backup_schedule.py
@@ -13,7 +13,7 @@ DOCUMENTATION = """
 ---
 module: proxmox_backup_schedule
 
-short_description: Schedule VM backups and remove them
+short_description: Schedule VM backups and removing them
 
 version_added: 10.5.0
 
@@ -108,12 +108,12 @@ EXAMPLES = """
 
 RETURN = """
 ---
-changed:
+backup_schedule:
   description:
-    - If V(present), the changed will return True after adding the VM ID to the backup job.
-    - If V(absent), the changed will return True after removing it from the backup job.
+    - If V(present), the backup_schedule will return True after adding the VM ID to the backup job.
+    - If V(absent), the backup_schedule will return True after removing it from the backup job.
   returned: always, but can be empty
-  type: bool
+  type: raw
 """
 
 from ansible.module_utils.basic import AnsibleModule, missing_required_lib
@@ -246,13 +246,14 @@ def main():
         vm_id = proxmox.vmname_2_vmid(vm_name)
 
     if state == 'present':
-        backup_schedule = proxmox.backup_present(vm_id, backup_id)
+        backup_schedule_result = proxmox.backup_present(vm_id, backup_id)
 
     if state == 'absent':
-        backup_schedule = proxmox.backup_absent(vm_id, backup_id)
+        backup_schedule_result = proxmox.backup_absent(vm_id, backup_id)
 
-    if backup_schedule:
-        result['changed'] = True
+    if backup_schedule_result:
+        result['changed'] = backup_schedule_result
+        result['vm_id'] = vm_id
         result['message'] = 'The backup schedule has been changed successfully.'
     else:
         result['message'] = 'The backup schedule did not change anything.'
diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
index c541facecc..fad35b25b4 100644
--- a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
+++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
@@ -171,9 +171,7 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
             RESOURCE_LIST
         )
         self.connect_mock.return_value.cluster.backup.get.side_effect = (
-            lambda backup_id=None: BACKUP_JOBS if backup_id is None else [
-                job for job in BACKUP_JOBS if job['id'] == backup_id
-            ]
+            lambda backup_id=None: BACKUP_JOBS if backup_id is None else [job for job in BACKUP_JOBS if job['id'] == backup_id]
         )
 
     def tearDown(self):
@@ -189,35 +187,36 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
         assert result["msg"] == "missing required arguments: api_host, api_user, state"
 
     def test_update_vmid_in_backup(self):
-        with patch('builtins.input', return_value='mocked input'):
-            with pytest.raises(AnsibleExitJson) as exc_info:
-                set_module_args({
-                    'api_host': 'proxmoxhost',
-                    'api_user': 'root@pam',
-                    'api_password': 'supersecret',
-                    'vm_name': 'test05',
-                    'backup_id': 'backup-001',
-                    'state': 'present'
-                })
-                self.module.main()
+        with pytest.raises(AnsibleExitJson) as exc_info:
+            set_module_args({
+                'api_host': 'proxmoxhost',
+                'api_user': 'root@pam',
+                'api_password': 'supersecret',
+                'vm_name': 'test05',
+                'backup_id': 'backup-001',
+                'state': 'present'
+            })
+            self.module.main()
 
-            result = exc_info.value.args[0]
-            assert result['changed'] is True
+        result = exc_info.value.args[0]
+
+        assert result['changed'] is True
+        assert result['vm_id'] == 105
 
     def test_delete_vmid_from_backup(self):
-        with patch('builtins.input', return_value='mocked input'):
-            with pytest.raises(AnsibleExitJson) as exc_info:
-                set_module_args({
-                    'api_host': 'proxmoxhost',
-                    'api_user': 'root@pam',
-                    'api_password': 'supersecret',
-                    'vm_id': '101',
-                    'state': 'absent'
-                })
-                self.module.main()
+        with pytest.raises(AnsibleExitJson) as exc_info:
+            set_module_args({
+                'api_host': 'proxmoxhost',
+                'api_user': 'root@pam',
+                'api_password': 'supersecret',
+                'vm_id': 101,
+                'state': 'absent'
+            })
+            self.module.main()
 
-            result = exc_info.value.args[0]
-            assert result['changed'] is True
+        result = exc_info.value.args[0]
+        assert result['changed'] is True
+        assert result['vm_id'] == 101
 
 
 if __name__ == '__main__':

From f09c2a10bcb7549fbd1ea90fe453da5b9a372134 Mon Sep 17 00:00:00 2001
From: mayabi <mayabi@um.ac.ir>
Date: Sun, 30 Mar 2025 13:57:12 +0330
Subject: [PATCH 31/31] rollback

---
 plugins/modules/proxmox_backup_schedule.py               | 9 ++++-----
 .../unit/plugins/modules/test_proxmox_backup_schedule.py | 7 +++++--
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/plugins/modules/proxmox_backup_schedule.py b/plugins/modules/proxmox_backup_schedule.py
index 48a2d70d60..7a4c11acd0 100644
--- a/plugins/modules/proxmox_backup_schedule.py
+++ b/plugins/modules/proxmox_backup_schedule.py
@@ -246,14 +246,13 @@ def main():
         vm_id = proxmox.vmname_2_vmid(vm_name)
 
     if state == 'present':
-        backup_schedule_result = proxmox.backup_present(vm_id, backup_id)
+        result['backup_schedule'] = proxmox.backup_present(vm_id, backup_id)
 
     if state == 'absent':
-        backup_schedule_result = proxmox.backup_absent(vm_id, backup_id)
+        result['backup_schedule'] = proxmox.backup_absent(vm_id, backup_id)
 
-    if backup_schedule_result:
-        result['changed'] = backup_schedule_result
-        result['vm_id'] = vm_id
+    if result['backup_schedule']:
+        result['changed'] = True
         result['message'] = 'The backup schedule has been changed successfully.'
     else:
         result['message'] = 'The backup schedule did not change anything.'
diff --git a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
index fad35b25b4..d130175ed2 100644
--- a/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
+++ b/tests/unit/plugins/modules/test_proxmox_backup_schedule.py
@@ -158,6 +158,9 @@ BACKUP_JOBS = [
     }
 ]
 
+EXPECTED_UPDATE_BACKUP_SCHEDULE = True
+EXPECTED_DEL_BACKUP_SCHEDULE = True
+
 
 class TestProxmoxBackupScheduleModule(ModuleTestCase):
     def setUp(self):
@@ -201,7 +204,7 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
         result = exc_info.value.args[0]
 
         assert result['changed'] is True
-        assert result['vm_id'] == 105
+        assert result['backup_schedule'] == EXPECTED_UPDATE_BACKUP_SCHEDULE
 
     def test_delete_vmid_from_backup(self):
         with pytest.raises(AnsibleExitJson) as exc_info:
@@ -216,7 +219,7 @@ class TestProxmoxBackupScheduleModule(ModuleTestCase):
 
         result = exc_info.value.args[0]
         assert result['changed'] is True
-        assert result['vm_id'] == 101
+        assert result['backup_schedule'] == EXPECTED_DEL_BACKUP_SCHEDULE
 
 
 if __name__ == '__main__':