ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-06 10:40:32 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

[PR #9871/dd0a2cbf backport][stable-10] sudoers: display stderr raised while validation (#9885)

Browse source 
sudoers: display stderr raised while validation (#9871)

* sudoers: display stderr raised while validation

* Print stdout and stderr raised from sudoers validation

Fixes: #9674

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit dd0a2cbff9)

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
This commit is contained in:
patchback[bot] 2025-03-15 07:46:14 +01:00 • committed by GitHub
parent 2583152512
commit c91e7b4c03
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
changelogs/fragments/sudoers.yml Normal file
View file

@ -0,0 +1,3 @@
---
bugfixes:
- sudoers - display stdout and stderr raised while failed validation (https://github.com/ansible-collections/community.general/issues/9674, https://github.com/ansible-collections/community.general/pull/9871).

2
plugins/modules/sudoers.py
View file

@ -246,7 +246,7 @@ class Sudoers(object):
rc, stdout, stderr = self.module.run_command(check_command, data=self.content()) rc, stdout, stderr = self.module.run_command(check_command, data=self.content())
if rc != 0: if rc != 0:
raise Exception('Failed to validate sudoers rule:\n{stdout}'.format(stdout=stdout)) self.module.fail_json(msg='Failed to validate sudoers rule:\n{stdout}'.format(stdout=stdout or stderr), stdout=stdout, stderr=stderr)
def run(self): def run(self):
if self.state == 'absent': if self.state == 'absent':

6
tests/integration/targets/sudoers/tasks/main.yml
View file

@ -229,7 +229,7 @@
ignore_errors: true ignore_errors: true
when: ansible_os_family != 'Darwin' when: ansible_os_family != 'Darwin'
register: edge_case_3 register: edge_case_3
- name: Revoke non-existing rule - name: Revoke non-existing rule
community.general.sudoers: community.general.sudoers:
name: non-existing-rule name: non-existing-rule
@ -278,12 +278,14 @@
that: that:
- not revoke_rule_1_stat.stat.exists - not revoke_rule_1_stat.stat.exists
- not revoke_non_existing_rule_stat.stat.exists - not revoke_non_existing_rule_stat.stat.exists
- name: Check edge case responses - name: Check edge case responses
ansible.builtin.assert: ansible.builtin.assert:
that: that:
- edge_case_1 is failed - edge_case_1 is failed
- "'Failed to validate sudoers rule' in edge_case_1.msg" - "'Failed to validate sudoers rule' in edge_case_1.msg"
- edge_case_1.stdout is defined
- edge_case_1.stderr is defined
- edge_case_2 is not failed - edge_case_2 is not failed
- name: Check missing validation edge case - name: Check missing validation edge case