From c881be0999c07713e303fe05ef42df2d29a5d4f2 Mon Sep 17 00:00:00 2001 From: Dexter <45038532+munchtoast@users.noreply.github.com> Date: Wed, 27 Aug 2025 16:04:01 -0400 Subject: [PATCH] pacemaker_cluster: deprecate cleanup state (#10741) * Add deprecation for pacemaker_cluster cleanup state * Add changelog fragment * Apply suggestions from code review Co-authored-by: Felix Fontein --------- Co-authored-by: Felix Fontein --- .../10741-pacemaker-cluster-cleanup-deprecate.yml | 2 ++ plugins/modules/pacemaker_cluster.py | 7 +++++++ 2 files changed, 9 insertions(+) create mode 100644 changelogs/fragments/10741-pacemaker-cluster-cleanup-deprecate.yml diff --git a/changelogs/fragments/10741-pacemaker-cluster-cleanup-deprecate.yml b/changelogs/fragments/10741-pacemaker-cluster-cleanup-deprecate.yml new file mode 100644 index 0000000000..4bb018a9c7 --- /dev/null +++ b/changelogs/fragments/10741-pacemaker-cluster-cleanup-deprecate.yml @@ -0,0 +1,2 @@ +deprecated_features: + - pacemaker_cluster - the state ``cleanup`` will be removed from community.general 14.0.0 (https://github.com/ansible-collections/community.general/pull/10741). diff --git a/plugins/modules/pacemaker_cluster.py b/plugins/modules/pacemaker_cluster.py index ffed13f9c5..a69a126596 100644 --- a/plugins/modules/pacemaker_cluster.py +++ b/plugins/modules/pacemaker_cluster.py @@ -99,6 +99,13 @@ class PacemakerCluster(StateModuleHelper): self.vars.set('previous_value', self._get()['out']) self.vars.set('value', self.vars.previous_value, change=True, diff=True) + if self.module.params['state'] == "cleanup": + self.module.deprecate( + 'The value `cleanup` for "state" is being deprecated, use pacemaker_resource module instead.', + version='14.0.0', + collection_name='community.general' + ) + if not self.module.params['state']: self.module.deprecate( 'Parameter "state" values not set is being deprecated. Make sure to provide a value for "state"',