become plugins: use f-strings (#9319)

* become plugins: use f-strings

* add changelog frag
This commit is contained in:
Alexei Znamensky 2024-12-23 22:02:12 +13:00 committed by GitHub
parent d05d067f3b
commit c7edf0a87b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 28 additions and 18 deletions

View file

@ -98,16 +98,16 @@ class BecomeModule(BecomeBase):
flags = self.get_option('become_flags') or ''
prompt = ''
if self.get_option('become_pass'):
self.prompt = '[sudo via ansible, key=%s] password:' % self._id
self.prompt = f'[sudo via ansible, key={self._id}] password:'
if flags: # this could be simplified, but kept as is for now for backwards string matching
flags = flags.replace('-n', '')
prompt = '-p "%s"' % (self.prompt)
prompt = f'-p "{self.prompt}"'
user = self.get_option('become_user') or ''
if user:
user = '%s' % (user)
user = f'{user}'
if self.get_option('alt_method'):
return ' '.join([becomecmd, flags, prompt, "su -l", user, "-c", self._build_success_command(cmd, shell, True)])
return f"{becomecmd} {flags} {prompt} su -l {user} -c {self._build_success_command(cmd, shell, True)}"
else:
return ' '.join([becomecmd, flags, prompt, 'su -l', user, self._build_success_command(cmd, shell)])
return f"{becomecmd} {flags} {prompt} su -l {user} {self._build_success_command(cmd, shell)}"