From 9a92cc634041d981b0fa193ea5681255395ba03b Mon Sep 17 00:00:00 2001 From: Charles Ulrich Date: Wed, 2 Apr 2025 22:00:46 -0400 Subject: [PATCH] Canonicalize value for AAAA records This ensures that any AAAA record value provided by the user is converted into a canonical and correctly-shortened form before any other processing takes place. In particular, this fixes an issue where a non-canonical address is not found by the create-or-update logic, causing the API to return an error saying that the record already exists. --- plugins/modules/cloudflare_dns.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/modules/cloudflare_dns.py b/plugins/modules/cloudflare_dns.py index e1b75e30ca..91be801845 100644 --- a/plugins/modules/cloudflare_dns.py +++ b/plugins/modules/cloudflare_dns.py @@ -422,6 +422,7 @@ record: sample: sample.com """ +from ipaddress import IPv6Address import json from ansible.module_utils.basic import AnsibleModule, env_fallback @@ -477,7 +478,7 @@ class CloudflareAPI(object): self.value = self.value.rstrip('.').lower() if (self.type == 'AAAA') and (self.value is not None): - self.value = self.value.lower() + self.value = str(IPv6Address(self.value)) if (self.type == 'SRV'): if (self.proto is not None) and (not self.proto.startswith('_')):