nxos tests to use network_cli (#34474)

* Fix over-byte

* Fix nxos_l2_interface docs

* Update connections for tasks

* Add default ssh port

* Only report provider when using connection=local

* Send empty provider when connection=network_cli

* Fix find tasks

test/integration/targets/nxos_interface/tasks/cli.yaml

@@ -3,12 +3,14 @@
   find:
     paths: "{{ role_path }}/tests/common"
     patterns: "{{ testcase }}.yaml"
+  connection: local
   register: test_cases
 
 - name: collect cli test cases
   find:
     paths: "{{ role_path }}/tests/cli"
     patterns: "{{ testcase }}.yaml"
+  connection: local
   register: cli_cases
 
 - set_fact:
@@ -18,8 +20,14 @@
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"
 
-- name: run test case
-  include: "{{ test_case_to_run }} connection={{ cli }}"
+- name: run test cases (connection=network_cli)
+  include: "{{ test_case_to_run }} ansible_connection=network_cli connection={}"
   with_items: "{{ test_items }}"
   loop_control:
     loop_var: test_case_to_run
+
+- name: run test case (connection=local)
+  include: "{{ test_case_to_run }} ansible_connection=local connection={{ cli }}"
+  with_first_found: "{{ test_items }}"
+  loop_control:
+    loop_var: test_case_to_run

test/integration/targets/nxos_interface/tasks/nxapi.yaml

@@ -3,12 +3,14 @@
   find:
     paths: "{{ role_path }}/tests/common"
     patterns: "{{ testcase }}.yaml"
+  connection: local
   register: test_cases
 
 - name: collect nxapi test cases
   find:
     paths: "{{ role_path }}/tests/nxapi"
     patterns: "{{ testcase }}.yaml"
+  connection: local
   register: nxapi_cases
 
 - set_fact:
@@ -18,8 +20,8 @@
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"
 
-- name: run test case
-  include: "{{ test_case_to_run }} connection={{ nxapi }}"
+- name: run test cases (connection=local)
+  include: "{{ test_case_to_run }} ansible_connection=local connection={{ nxapi }}"
   with_items: "{{ test_items }}"
   loop_control:
     loop_var: test_case_to_run

test/integration/targets/nxos_interface/tests/common/intent.yaml

@@ -1,4 +1,6 @@
-- debug: msg="START TRANSPORT:{{ connection.transport }} nxos_interface intent test"
+- debug: msg="START connection={{ ansible_connection }} nxos_interface intent test"
+- debug: msg="Using provider={{ connection.transport }}"
+  when: ansible_connection == "local"
 
 - set_fact: testint1="{{ nxos_int1 }}"
 - set_fact: testint2="{{ nxos_int2 }}"
@@ -60,4 +62,4 @@
     provider: "{{ connection }}"
   ignore_errors: yes
 
-- debug: msg="END TRANSPORT:{{ connection.transport }} nxos_interface intent test"
+- debug: msg="END connection={{ ansible_connection }} nxos_interface intent test"

test/integration/targets/nxos_interface/tests/common/sanity.yaml

@@ -1,5 +1,7 @@
 ---
-- debug: msg="START TRANSPORT:{{ connection.transport }} nxos_interface sanity test"
+- debug: msg="START connection={{ ansible_connection }} nxos_interface sanity test"
+- debug: msg="Using provider={{ connection.transport }}"
+  when: ansible_connection == "local"
 
 - set_fact: testint="{{ nxos_int1 }}"
 
@@ -128,4 +130,4 @@
     ignore_errors: yes
 
   always:
-  - debug: msg="END TRANSPORT:{{ connection.transport }} nxos_interface sanity test"
+  - debug: msg="END connection={{ ansible_connection }} nxos_interface sanity test"