ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-05-29 12:29:10 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

nxos_file_copy network_cli and httpapi fix (#40592)

Browse source 
* Leverage action plugin to pass credentials to nxos_file_copy for network_cli, httpapi

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* make sure local test uses provider

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update tests

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update doc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* clarify action plugin comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add connection=local back to nxos_file_copy because that module is weird

Also blacklist it running on nxapi, because that is meaningless

* remove provider

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* blacklist nxapi

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Address review comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
This commit is contained in:
Trishna Guha 2018-05-24 20:21:18 +05:30 • committed by GitHub
parent 94049680c3
commit c2f7f36fc5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 46 additions and 112 deletions
Download patch file Download diff file Expand all files Collapse all files

12
test/integration/targets/nxos_file_copy/tests/cli/sanity.yaml
View file

@ -1,7 +1,5 @@
---
- debug: msg="START TRANSPORT:CLI nxos_file_copy sanity test"
- debug: msg="Using provider={{ connection.transport }}"
when: ansible_connection == "local"
- debug: msg="START connection={{ ansible_connection }} nxos_file_copy sanity test"
- name: "Setup - Remove existing file"
nxos_command: &remove_file
@ -20,9 +18,6 @@
nxos_file_copy: &copy_file_same_name
local_file: "./network-integration.cfg"
file_system: "bootflash:"
username: "{{ ansible_ssh_user }}"
password: "{{ ansible_ssh_pass }}"
host: "{{ ansible_host }}"
connect_ssh_port: "{{ ansible_ssh_port }}"
register: result
@ -47,9 +42,6 @@
local_file: "./inventory.networking.template"
remote_file: "network-integration.cfg"
file_system: "bootflash:"
username: "{{ ansible_ssh_user }}"
password: "{{ ansible_ssh_pass }}"
host: "{{ ansible_host }}"
connect_ssh_port: "{{ ansible_ssh_port }}"
register: result
@ -80,4 +72,4 @@
feature: scp-server
state: disabled
- debug: msg="END TRANSPORT:CLI nxos_file_copy sanity test"
- debug: msg="END connection={{ ansible_connection }} nxos_file_copy sanity test"