ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-06-04 15:29:10 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix: github_deploy_key check key exists on 422 (#10011)

Browse source 
* fix: github_deploy_key check key exists on 422

If we get a 422 response code as we add a key, check if it's because the key already exists or for another reason.

fixes: #6718

* chore: add changelog 10011-github_deploy_key-check-key-present

* chore: fix changelog fragment

* chore: fix changelog fragment

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
Alex Garel 2025-04-21 12:22:14 +02:00 • committed by GitHub
parent e0a283bb36
commit c248073079
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/10011-github_deploy_key-check-key-present.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- "github_deploy_key - check that key really exists on 422 to avoid masking other errors (https://github.com/ansible-collections/community.general/issues/6718, https://github.com/ansible-collections/community.general/pull/10011)."

5
plugins/modules/github_deploy_key.py
View file

@ -259,9 +259,14 @@ class GithubDeployKey(object):
key_id = response_body["id"] key_id = response_body["id"]
self.module.exit_json(changed=True, msg="Deploy key successfully added", id=key_id) self.module.exit_json(changed=True, msg="Deploy key successfully added", id=key_id)
elif status_code == 422: elif status_code == 422:
# there might be multiple reasons for a 422
# so we must check if the reason is that the key already exists
if self.get_existing_key():
self.module.exit_json(changed=False, msg="Deploy key already exists") self.module.exit_json(changed=False, msg="Deploy key already exists")
else: else:
self.handle_error(method="POST", info=info) self.handle_error(method="POST", info=info)
else:
self.handle_error(method="POST", info=info)
def remove_existing_key(self, key_id): def remove_existing_key(self, key_id):
resp, info = fetch_url(self.module, "{0}/{1}".format(self.url, key_id), headers=self.headers, method="DELETE") resp, info = fetch_url(self.module, "{0}/{1}".format(self.url, key_id), headers=self.headers, method="DELETE")