From be3c3c3f45cfe78238c2b859c14d1a6cd29513d7 Mon Sep 17 00:00:00 2001 From: Felix Fontein Date: Wed, 14 May 2025 07:34:39 +0200 Subject: [PATCH] [stable-8] redis_info: adjust tests for Arch Linux (#10132) * Cherry-pick parts of bf69dc46ff934091fdcb2133b4d1af16cd3319f0. * redis_info: adjust tests for Arch Linux (#10129) (cherry picked from commit e853a6f39b70fdc20c297cf183db917b9e3044a5) --- .../setup_redis_replication/defaults/main.yml | 14 ++++++++++++-- .../tasks/setup_redis_cluster.yml | 8 ++++---- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/tests/integration/targets/setup_redis_replication/defaults/main.yml b/tests/integration/targets/setup_redis_replication/defaults/main.yml index 46dae9898a..a283fa5725 100644 --- a/tests/integration/targets/setup_redis_replication/defaults/main.yml +++ b/tests/integration/targets/setup_redis_replication/defaults/main.yml @@ -8,7 +8,7 @@ redis_packages: Alpine: - redis Archlinux: - - redis + - valkey Debian: - redis-server Ubuntu: @@ -22,13 +22,23 @@ redis_packages: FreeBSD: - redis +redis_user: + Alpine: redis + Archlinux: valkey + Debian: redis + Ubuntu: redis + openSUSE Leap: redis + Fedora: "{{ '998' if ansible_distribution_major_version is version('41', '>=') else 'redis' }}" + CentOS: redis + FreeBSD: redis + redis_bin: Alpine: /usr/bin/redis-server Archlinux: /usr/bin/redis-server Debian: /usr/bin/redis-server Ubuntu: /usr/bin/redis-server openSUSE Leap: /usr/sbin/redis-server - Fedora: /usr/bin/redis-server + Fedora: "/usr/bin/{{ 'valkey-server' if ansible_distribution_major_version is version('41', '>=') else 'redis-server' }}" CentOS: /usr/bin/redis-server FreeBSD: /usr/local/bin/redis-server diff --git a/tests/integration/targets/setup_redis_replication/tasks/setup_redis_cluster.yml b/tests/integration/targets/setup_redis_replication/tasks/setup_redis_cluster.yml index dd48bf2b64..72f1703832 100644 --- a/tests/integration/targets/setup_redis_replication/tasks/setup_redis_cluster.yml +++ b/tests/integration/targets/setup_redis_replication/tasks/setup_redis_cluster.yml @@ -24,8 +24,8 @@ file: path: "{{ item }}" state: directory - owner: redis - group: redis + owner: "{{ redis_user[ansible_distribution] }}" + group: "{{ redis_user[ansible_distribution] }}" loop: - "{{ master_datadir }}" - "{{ master_logdir }}" @@ -54,10 +54,10 @@ datadir: "{{ replica_datadir }}" - name: Start redis master - shell: "{{ redis_bin[ansible_distribution] }} {{ master_conf }}" + ansible.builtin.command: "{{ redis_bin[ansible_distribution] }} {{ master_conf }}" - name: Start redis replica - shell: "{{ redis_bin[ansible_distribution] }} {{ replica_conf }} --{% if old_redis %}slaveof{% else %}replicaof{% endif %} 127.0.0.1 {{ master_port }}" + ansible.builtin.command: "{{ redis_bin[ansible_distribution] }} {{ replica_conf }} --{% if old_redis %}slaveof{% else %}replicaof{% endif %} 127.0.0.1 {{ master_port }}" - name: Wait for redis master to be started ansible.builtin.wait_for: