Temporary (#31677)

* allow shells to have per host options, remote_tmp

added language to shell
removed module lang setting from general as  plugins have it now
use get to avoid bad powershell plugin
more resilient tmp discovery, fall back to `pwd`
add shell to docs
fixed options for when frags are only options
added shell set ops in t_e and fixed option frags
normalize tmp dir usag4e

- pass tmpdir/tmp/temp options as env var to commands, making it default for tempfile
- adjusted ansiballz tmpdir
- default local tempfile usage to the configured local tmp
- set env temp in action

add options to powershell
shift temporary to internal envvar/params
ensure tempdir is set if we pass var
ensure basic and url use expected tempdir
ensure localhost uses local tmp
give /var/tmp priority, less perms issues
more consistent tempfile mgmt for ansiballz
made async_dir configurable
better action handling, allow for finally rm tmp
fixed tmp issue and no more tempdir in ballz
hostvarize world readable and admin users
always set shell tempdir
added comment to discourage use of exception/flow control

* Mostly revert expand_user as it's not quite working.

This was an additional feature anyhow.

Kept the use of pwd as a fallback but moved it to a second ssh
connection.  This is not optimal but getting that to work in a single
ssh connection was part of the problem holding this up.

(cherry picked from commit 395b714120522f15e4c90a346f5e8e8d79213aca)

* fixed script and other action plugins

ensure tmpdir deletion
allow for connections that don't support new options (legacy, 3rd party)
fixed tests

lib/ansible/plugins/action/patch.py

@@ -20,7 +20,7 @@ __metaclass__ = type
 
 import os
 
-from ansible.errors import AnsibleError
+from ansible.errors import AnsibleError, AnsibleAction, AnsibleActionDone, AnsibleActionFail
 from ansible.module_utils._text import to_native
 from ansible.module_utils.parsing.convert_bool import boolean
 from ansible.plugins.action import ActionBase
@@ -28,6 +28,8 @@ from ansible.plugins.action import ActionBase
 
 class ActionModule(ActionBase):
 
+    TRANSFERS_FILES = True
+
     def run(self, tmp=None, task_vars=None):
         if task_vars is None:
             task_vars = dict()
@@ -37,39 +39,33 @@ class ActionModule(ActionBase):
         src = self._task.args.get('src', None)
         remote_src = boolean(self._task.args.get('remote_src', 'no'), strict=False)
 
-        if src is None:
-            result['failed'] = True
-            result['msg'] = "src is required"
-            return result
-        elif remote_src:
-            # everything is remote, so we just execute the module
-            # without changing any of the module arguments
-            result.update(self._execute_module(task_vars=task_vars))
-            return result
-
         try:
-            src = self._find_needle('files', src)
-        except AnsibleError as e:
-            result['failed'] = True
-            result['msg'] = to_native(e)
-            return result
+            if src is None:
+                raise AnsibleActionFail("src is required")
+            elif remote_src:
+                # everything is remote, so we just execute the module
+                # without changing any of the module arguments
+                raise AnsibleActionDone(result=self._execute_module(task_vars=task_vars))
 
-        # create the remote tmp dir if needed, and put the source file there
-        if tmp is None or "-tmp-" not in tmp:
-            tmp = self._make_tmp_path()
+            try:
+                src = self._find_needle('files', src)
+            except AnsibleError as e:
+                raise AnsibleActionFail(to_native(e))
 
-        tmp_src = self._connection._shell.join_path(tmp, os.path.basename(src))
-        self._transfer_file(src, tmp_src)
+            tmp_src = self._connection._shell.join_path(self._connection._shell.tempdir, os.path.basename(src))
+            self._transfer_file(src, tmp_src)
+            self._fixup_perms2((tmp_src,))
 
-        self._fixup_perms2((tmp, tmp_src))
-
-        new_module_args = self._task.args.copy()
-        new_module_args.update(
-            dict(
-                src=tmp_src,
+            new_module_args = self._task.args.copy()
+            new_module_args.update(
+                dict(
+                    src=tmp_src,
+                )
             )
-        )
 
-        result.update(self._execute_module('patch', module_args=new_module_args, task_vars=task_vars))
-        self._remove_tmp_path(tmp)
+            result.update(self._execute_module('patch', module_args=new_module_args, task_vars=task_vars))
+        except AnsibleAction as e:
+            result.update(e.result)
+        finally:
+            self._remove_tmp_path(self._connection._shell.tempdir)
         return result