Move import sanity test files into own directory. (#35593)

test/sanity/code-smell/no-underscore-variable.sh

@@ -101,7 +101,7 @@ TO_BE_FIXED='
 ./lib/ansible/plugins/strategy/linear.py
 ./test/legacy/cleanup_gce.py
 ./test/legacy/gce_credentials.py
-./test/runner/importer.py
+./test/sanity/import/importer.py
 ./test/runner/lib/cloud/cs.py
 ./test/runner/lib/core_ci.py
 ./test/runner/lib/delegation.py

test/sanity/import/importer.py

@@ -0,0 +1,120 @@
+#!/usr/bin/env python
+"""Import the given python module(s) and report error(s) encountered."""
+
+from __future__ import absolute_import, print_function
+
+import contextlib
+import imp
+import os
+import re
+import sys
+import traceback
+
+try:
+    from StringIO import StringIO
+except ImportError:
+    from io import StringIO
+
+
+def main():
+    """Main program function."""
+    base_dir = os.getcwd()
+    messages = set()
+
+    for path in sys.argv[1:]:
+        capture = Capture()
+        try:
+            with open(path, 'r') as module_fd:
+                with capture_output(capture):
+                    imp.load_module('module_import_test', module_fd, os.path.abspath(path), ('.py', 'r', imp.PY_SOURCE))
+
+            capture_report(path, capture, messages)
+        except BaseException as ex:  # pylint: disable=locally-disabled, broad-except
+            capture_report(path, capture, messages)
+
+            exc_type, _, exc_tb = sys.exc_info()
+            message = str(ex)
+            results = list(reversed(traceback.extract_tb(exc_tb)))
+            source = None
+            line = 0
+            offset = 0
+
+            for result in results:
+                if result[0].startswith(base_dir):
+                    source = result[0][len(base_dir) + 1:].replace('test/sanity/import/', '')
+                    line = result[1] or 0
+                    break
+
+            if not source:
+                # If none of our source files are found in the traceback, report the file we were testing.
+                # I haven't been able to come up with a test case that encounters this issue yet.
+                source = path
+                message += ' (in %s:%d)' % (results[-1][0], results[-1][1] or 0)
+            elif isinstance(ex, SyntaxError):
+                if ex.filename.endswith(path):  # pylint: disable=locally-disabled, no-member
+                    # A SyntaxError in the source we're importing will have the correct path, line and offset.
+                    # However, the traceback will report the path to this importer.py script instead.
+                    # We'll use the details from the SyntaxError in this case, as it's more accurate.
+                    source = path
+                    line = ex.lineno or 0  # pylint: disable=locally-disabled, no-member
+                    offset = ex.offset or 0  # pylint: disable=locally-disabled, no-member
+                    message = str(ex)
+
+                    # Hack to remove the filename and line number from the message, if present.
+                    message = message.replace(' (%s, line %d)' % (os.path.basename(path), line), '')
+
+            message = re.sub(r'\n *', ': ', message)
+            error = '%s:%d:%d: %s: %s' % (source, line, offset, exc_type.__name__, message)
+
+            if error not in messages:
+                messages.add(error)
+                print(error)
+
+    if messages:
+        exit(10)
+
+
+class Capture(object):
+    """Captured output and/or exception."""
+    def __init__(self):
+        self.stdout = StringIO()
+        self.stderr = StringIO()
+
+
+def capture_report(path, capture, messages):
+    """Report on captured output.
+    :type path: str
+    :type capture: Capture
+    :type messages: set[str]
+    """
+    if capture.stdout.getvalue():
+        message = '%s:%d:%d: %s: %s' % (path, 0, 0, 'Output', 'Import resulted in output to stdout.')
+        messages.add(message)
+        print(message)
+
+    if capture.stderr.getvalue():
+        message = '%s:%d:%d: %s: %s' % (path, 0, 0, 'Output', 'Import resulted in output to stderr.')
+        messages.add(message)
+        print(message)
+
+
+@contextlib.contextmanager
+def capture_output(capture):
+    """Capture sys.stdout and sys.stderr.
+    :type capture: Capture
+    """
+    old_stdout = sys.stdout
+    old_stderr = sys.stderr
+
+    sys.stdout = capture.stdout
+    sys.stderr = capture.stderr
+
+    try:
+        yield
+    finally:
+        sys.stdout = old_stdout
+        sys.stderr = old_stderr
+
+
+if __name__ == '__main__':
+    main()

test/sanity/import/lib/ansible/__init__.py

@@ -0,0 +1 @@
+"""Empty placeholder for import sanity test."""

test/sanity/import/lib/ansible/module_utils

@@ -0,0 +1 @@
+../../../../../lib/ansible/module_utils

test/sanity/pylint/ignore.txt

@@ -69,7 +69,6 @@ lib/ansible/modules/storage/purestorage/purefa_pg.py ansible-format-automatic-sp
 lib/ansible/modules/system/firewalld.py ansible-format-automatic-specification
 lib/ansible/plugins/cliconf/junos.py ansible-no-format-on-bytestring 3
 lib/ansible/plugins/cliconf/nxos.py ansible-format-automatic-specification
-test/runner/importer.py missing-docstring 3.7
 test/runner/injector/importer.py missing-docstring 3.7
 test/runner/injector/injector.py missing-docstring 3.7
 test/runner/lib/ansible_util.py missing-docstring 3.7
@@ -97,8 +96,10 @@ test/runner/lib/powershell_import_analysis.py missing-docstring 3.7
 test/runner/lib/pytar.py missing-docstring 3.7
 test/runner/lib/sanity/__init__.py missing-docstring 3.7
 test/runner/lib/sanity/ansible_doc.py missing-docstring 3.7
+test/runner/lib/sanity/compile.py missing-docstring 3.7
 test/runner/lib/sanity/import.py missing-docstring 3.7
 test/runner/lib/sanity/pep8.py missing-docstring 3.7
+test/runner/lib/sanity/pslint.py missing-docstring 3.7
 test/runner/lib/sanity/pylint.py missing-docstring 3.7
 test/runner/lib/sanity/rstcheck.py missing-docstring 3.7
 test/runner/lib/sanity/sanity_docs.py missing-docstring 3.7
@@ -113,3 +114,4 @@ test/runner/retry.py missing-docstring 3.7
 test/runner/shippable.py missing-docstring 3.7
 test/runner/test.py missing-docstring 3.7
 test/runner/units/test_diff.py missing-docstring 3.7
+test/sanity/import/importer.py missing-docstring 3.7