ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-25 11:51:26 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Compare byte strings to byte strings

Browse source 
* Fix a traceback in ansible-pull on python3 comparing output from
  subprocess with a text string.
* Rename variables that hold byte strings so we are clear that those are
  not text strings.
* Use to_text() to transform variable that's being displayed as it's
  less fragile than str().

Fixes #36962
This commit is contained in:
Toshio Kuratomi 2018-03-19 09:10:50 -07:00
parent 0d55081ba8
commit b98ad3a12b
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
lib/ansible/cli/pull.py
View file

@ -30,7 +30,7 @@ import time
from ansible.cli import CLI from ansible.cli import CLI
from ansible.errors import AnsibleOptionsError from ansible.errors import AnsibleOptionsError
from ansible.module_utils._text import to_native from ansible.module_utils._text import to_native, to_text
from ansible.plugins.loader import module_loader from ansible.plugins.loader import module_loader
from ansible.utils.cmd_functions import run_cmd from ansible.utils.cmd_functions import run_cmd
@ -238,14 +238,14 @@ class PullCLI(CLI):
# RUN the Checkout command # RUN the Checkout command
display.debug("running ansible with VCS module to checkout repo") display.debug("running ansible with VCS module to checkout repo")
display.vvvv('EXEC: %s' % cmd) display.vvvv('EXEC: %s' % cmd)
rc, out, err = run_cmd(cmd, live=True) rc, b_out, b_err = run_cmd(cmd, live=True)
if rc != 0: if rc != 0:
if self.options.force: if self.options.force:
display.warning("Unable to update repository. Continuing with (forced) run of playbook.") display.warning("Unable to update repository. Continuing with (forced) run of playbook.")
else: else:
return rc return rc
elif self.options.ifchanged and '"changed": true' not in out: elif self.options.ifchanged and b'"changed": true' not in b_out:
display.display("Repository has not changed, quitting.") display.display("Repository has not changed, quitting.")
return 0 return 0
@ -287,14 +287,14 @@ class PullCLI(CLI):
# RUN THE PLAYBOOK COMMAND # RUN THE PLAYBOOK COMMAND
display.debug("running ansible-playbook to do actual work") display.debug("running ansible-playbook to do actual work")
display.debug('EXEC: %s' % cmd) display.debug('EXEC: %s' % cmd)
rc, out, err = run_cmd(cmd, live=True) rc, b_out, b_err = run_cmd(cmd, live=True)
if self.options.purge: if self.options.purge:
os.chdir('/') os.chdir('/')
try: try:
shutil.rmtree(self.options.dest) shutil.rmtree(self.options.dest)
except Exception as e: except Exception as e:
display.error("Failed to remove %s: %s" % (self.options.dest, str(e))) display.error(u"Failed to remove %s: %s" % (self.options.dest, to_text(e)))
return rc return rc