ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-10-26 05:50:36 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

use f-strings in module utils (#10901)
Some checks are pending
EOL CI / EOL Sanity (Ⓐ2.17) (push) Waiting to run
Details
EOL CI / EOL Units (Ⓐ2.17+py3.10) (push) Waiting to run
Details
EOL CI / EOL Units (Ⓐ2.17+py3.12) (push) Waiting to run
Details
EOL CI / EOL Units (Ⓐ2.17+py3.7) (push) Waiting to run
Details
EOL CI / EOL I (Ⓐ2.17+alpine319+py:azp/posix/1/) (push) Waiting to run
Details
EOL CI / EOL I (Ⓐ2.17+alpine319+py:azp/posix/2/) (push) Waiting to run
Details
EOL CI / EOL I (Ⓐ2.17+alpine319+py:azp/posix/3/) (push) Waiting to run
Details
EOL CI / EOL I (Ⓐ2.17+fedora39+py:azp/posix/1/) (push) Waiting to run
Details
EOL CI / EOL I (Ⓐ2.17+fedora39+py:azp/posix/2/) (push) Waiting to run
Details
EOL CI / EOL I (Ⓐ2.17+fedora39+py:azp/posix/3/) (push) Waiting to run
Details
EOL CI / EOL I (Ⓐ2.17+ubuntu2004+py:azp/posix/1/) (push) Waiting to run
Details
EOL CI / EOL I (Ⓐ2.17+ubuntu2004+py:azp/posix/2/) (push) Waiting to run
Details
EOL CI / EOL I (Ⓐ2.17+ubuntu2004+py:azp/posix/3/) (push) Waiting to run
Details
nox / Run extra sanity tests (push) Waiting to run
Details

Browse source 
* use f-strings in module utils

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* remove unused imports

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
Alexei Znamensky 2025-10-11 22:43:43 +13:00 • committed by GitHub
commit b85e263466
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
51 changed files with 270 additions and 382 deletions
Download patch file Download diff file Expand all files Collapse all files

21
plugins/module_utils/ilo_redfish_utils.py
View file

@ -20,8 +20,7 @@ class iLORedfishUtils(RedfishUtils):
properties = ['Description', 'Id', 'Name', 'UserName']
# Changed self.sessions_uri to Hardcoded string.
response = self.get_request(
self.root_uri + self.service_root + "SessionService/Sessions/")
response = self.get_request(f"{self.root_uri}{self.service_root}SessionService/Sessions/")
if not response['ret']:
return response
result['ret'] = True
@ -83,7 +82,7 @@ class iLORedfishUtils(RedfishUtils):
if not res_dhv6['ret']:
return res_dhv6
datetime_uri = self.manager_uri + "DateTime"
datetime_uri = f"{self.manager_uri}DateTime"
listofips = mgr_attributes['mgr_attr_value'].split(" ")
if len(listofips) > 2:
@ -102,12 +101,12 @@ class iLORedfishUtils(RedfishUtils):
if not response1['ret']:
return response1
return {'ret': True, 'changed': True, 'msg': "Modified %s" % mgr_attributes['mgr_attr_name']}
return {'ret': True, 'changed': True, 'msg': f"Modified {mgr_attributes['mgr_attr_name']}"}
def set_time_zone(self, attr):
key = attr['mgr_attr_name']
uri = self.manager_uri + "DateTime/"
uri = f"{self.manager_uri}DateTime/"
response = self.get_request(self.root_uri + uri)
if not response['ret']:
return response
@ -115,7 +114,7 @@ class iLORedfishUtils(RedfishUtils):
data = response["data"]
if key not in data:
return {'ret': False, 'changed': False, 'msg': "Key %s not found" % key}
return {'ret': False, 'changed': False, 'msg': f"Key {key} not found"}
timezones = data["TimeZoneList"]
index = ""
@ -129,7 +128,7 @@ class iLORedfishUtils(RedfishUtils):
if not response['ret']:
return response
return {'ret': True, 'changed': True, 'msg': "Modified %s" % attr['mgr_attr_name']}
return {'ret': True, 'changed': True, 'msg': f"Modified {attr['mgr_attr_name']}"}
def set_dns_server(self, attr):
key = attr['mgr_attr_name']
@ -161,7 +160,7 @@ class iLORedfishUtils(RedfishUtils):
if not response['ret']:
return response
return {'ret': True, 'changed': True, 'msg': "Modified %s" % attr['mgr_attr_name']}
return {'ret': True, 'changed': True, 'msg': f"Modified {attr['mgr_attr_name']}"}
def set_domain_name(self, attr):
key = attr['mgr_attr_name']
@ -206,7 +205,7 @@ class iLORedfishUtils(RedfishUtils):
response = self.patch_request(self.root_uri + ethuri, payload)
if not response['ret']:
return response
return {'ret': True, 'changed': True, 'msg': "Modified %s" % attr['mgr_attr_name']}
return {'ret': True, 'changed': True, 'msg': f"Modified {attr['mgr_attr_name']}"}
def set_wins_registration(self, mgrattr):
Key = mgrattr['mgr_attr_name']
@ -227,7 +226,7 @@ class iLORedfishUtils(RedfishUtils):
response = self.patch_request(self.root_uri + ethuri, payload)
if not response['ret']:
return response
return {'ret': True, 'changed': True, 'msg': "Modified %s" % mgrattr['mgr_attr_name']}
return {'ret': True, 'changed': True, 'msg': f"Modified {mgrattr['mgr_attr_name']}"}
def get_server_poststate(self):
# Get server details
@ -302,5 +301,5 @@ class iLORedfishUtils(RedfishUtils):
return {
"ret": False,
"changed": False,
"msg": "Server Reboot has failed, server state: {state} ".format(state=state)
"msg": f"Server Reboot has failed, server state: {state} "
}