ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-27 15:11:23 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Minor fixups found during review of #582

Browse source
This commit is contained in:
Toshio Kuratomi 2015-05-27 07:03:29 -07:00 • committed by Matt Clay
commit b6a312e489
1 changed files with 26 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

35
lib/ansible/modules/cloud/amazon/s3.py
View file

@ -219,14 +219,23 @@ def upload_s3file(module, s3, bucket, obj, src, expiry, metadata):
except s3.provider.storage_copy_error, e: except s3.provider.storage_copy_error, e:
module.fail_json(msg= str(e)) module.fail_json(msg= str(e))
def download_s3file(module, s3, bucket, obj, dest): def download_s3file(module, s3, bucket, obj, dest, retries):
try: # retries is the number of loops; range/xrange needs to be one
bucket = s3.lookup(bucket) # more to get that count of loops.
key = bucket.lookup(obj) bucket = s3.lookup(bucket)
key.get_contents_to_filename(dest) key = bucket.lookup(obj)
module.exit_json(msg="GET operation complete", changed=True) for x in range(0, retries + 1):
except s3.provider.storage_copy_error, e: try:
module.fail_json(msg= str(e)) key.get_contents_to_filename(dest)
module.exit_json(msg="GET operation complete", changed=True)
except s3.provider.storage_copy_error, e:
module.fail_json(msg= str(e))
except SSLError as e:
# actually fail on last pass through the loop.
if x >= retries:
module.fail_json(msg="s3 download failed; %s" % e)
# otherwise, try again, this may be a transient timeout.
pass
def download_s3str(module, s3, bucket, obj): def download_s3str(module, s3, bucket, obj):
try: try:
@ -274,7 +283,8 @@ def main():
expiry = dict(default=600, aliases=['expiration']), expiry = dict(default=600, aliases=['expiration']),
s3_url = dict(aliases=['S3_URL']), s3_url = dict(aliases=['S3_URL']),
overwrite = dict(aliases=['force'], default=True, type='bool'), overwrite = dict(aliases=['force'], default=True, type='bool'),
metadata = dict(type='dict'), metadata = dict(type='dict'),
retries = dict(aliases=['retry'], type='int', default=0),
), ),
) )
module = AnsibleModule(argument_spec=argument_spec) module = AnsibleModule(argument_spec=argument_spec)
@ -292,6 +302,13 @@ def main():
s3_url = module.params.get('s3_url') s3_url = module.params.get('s3_url')
overwrite = module.params.get('overwrite') overwrite = module.params.get('overwrite')
metadata = module.params.get('metadata') metadata = module.params.get('metadata')
retries = module.params.get('retries')
if overwrite not in ['always', 'never', 'different']:
if module.boolean(overwrite):
overwrite = 'always'
else:
overwrite='never'
region, ec2_url, aws_connect_kwargs = get_aws_connection_info(module) region, ec2_url, aws_connect_kwargs = get_aws_connection_info(module)