ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-25 14:20:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Call parent super() in RoleDefinition init before doing other stuff

Browse source 
This only impacts the use of RoleDefinition directly, but it was a tricky
bug to spot.
This commit is contained in:
James Cammarata 2017-02-10 08:26:01 -06:00
commit b5bf525828
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/ansible/playbook/role/definition.py
View file

@ -49,6 +49,9 @@ class RoleDefinition(Base, Become, Conditional, Taggable):
_role = FieldAttribute(isa='string') _role = FieldAttribute(isa='string')
def __init__(self, play=None, role_basedir=None, variable_manager=None, loader=None): def __init__(self, play=None, role_basedir=None, variable_manager=None, loader=None):
super(RoleDefinition, self).__init__()
self._play = play self._play = play
self._variable_manager = variable_manager self._variable_manager = variable_manager
self._loader = loader self._loader = loader
@ -56,7 +59,6 @@ class RoleDefinition(Base, Become, Conditional, Taggable):
self._role_path = None self._role_path = None
self._role_basedir = role_basedir self._role_basedir = role_basedir
self._role_params = dict() self._role_params = dict()
super(RoleDefinition, self).__init__()
#def __repr__(self): #def __repr__(self):
# return 'ROLEDEF: ' + self._attributes.get('role', '<no name set>') # return 'ROLEDEF: ' + self._attributes.get('role', '<no name set>')