xfconf/xfconf_info: add return value version (#9226)

* xfconf/xfconf_info: add return value version

* add changelog frag

* adapt test to helper improvements

* rollback copyright update

* replace tab with spaces in test yamls

tests/unit/plugins/modules/test_xfconf.yaml

@@ -21,11 +21,23 @@
     previous_value: '100'
     type: int
     value: '90'
+    version: "4.18.1"
   mocks:
     run_command:
-    - command: [/testbin/xfconf-query, --channel, xfwm4, --property, /general/inactive_opacity]
+    - command: [/testbin/xfconf-query, --version]
       environ: &env-def {environ_update: {LANGUAGE: C, LC_ALL: C}, check_rc: false}
       rc: 0
+      out: &version-output |
+        xfconf-query 4.18.1
+
+        Copyright (c) 2008-2023
+            The Xfce development team. All rights reserved.
+
+        Please report bugs to <https://gitlab.xfce.org/xfce/xfconf>.
+      err: ""
+    - command: [/testbin/xfconf-query, --channel, xfwm4, --property, /general/inactive_opacity]
+      environ: *env-def
+      rc: 0
       out: "100\n"
       err: ""
     - command: [/testbin/xfconf-query, --channel, xfwm4, --property, /general/inactive_opacity, --create, --type, int, --set, '90']
@@ -45,8 +57,14 @@
     previous_value: '90'
     type: int
     value: '90'
+    version: "4.18.1"
   mocks:
     run_command:
+    - command: [/testbin/xfconf-query, --version]
+      environ: *env-def
+      rc: 0
+      out: *version-output
+      err: ""
     - command: [/testbin/xfconf-query, --channel, xfwm4, --property, /general/inactive_opacity]
       environ: *env-def
       rc: 0
@@ -69,8 +87,14 @@
     previous_value: 'true'
     type: bool
     value: 'False'
+    version: "4.18.1"
   mocks:
     run_command:
+    - command: [/testbin/xfconf-query, --version]
+      environ: *env-def
+      rc: 0
+      out: *version-output
+      err: ""
     - command: [/testbin/xfconf-query, --channel, xfce4-session, --property, /general/SaveOnExit]
       environ: *env-def
       rc: 0
@@ -93,8 +117,14 @@
     previous_value: [Main, Work, Tmp]
     type: [string, string, string]
     value: [A, B, C]
+    version: "4.18.1"
   mocks:
     run_command:
+    - command: [/testbin/xfconf-query, --version]
+      environ: *env-def
+      rc: 0
+      out: *version-output
+      err: ""
     - command: [/testbin/xfconf-query, --channel, xfwm4, --property, /general/workspace_names]
       environ: *env-def
       rc: 0
@@ -136,8 +166,14 @@
     previous_value: [A, B, C]
     type: [string, string, string]
     value: [A, B, C]
+    version: "4.18.1"
   mocks:
     run_command:
+    - command: [/testbin/xfconf-query, --version]
+      environ: *env-def
+      rc: 0
+      out: *version-output
+      err: ""
     - command: [/testbin/xfconf-query, --channel, xfwm4, --property, /general/workspace_names]
       environ: *env-def
       rc: 0
@@ -177,8 +213,14 @@
     previous_value: [A, B, C]
     type:
     value:
+    version: "4.18.1"
   mocks:
     run_command:
+    - command: [/testbin/xfconf-query, --version]
+      environ: *env-def
+      rc: 0
+      out: *version-output
+      err: ""
     - command: [/testbin/xfconf-query, --channel, xfwm4, --property, /general/workspace_names]
       environ: *env-def
       rc: 0

tests/unit/plugins/modules/test_xfconf_info.yaml

@@ -6,6 +6,13 @@
 ---
 anchors:
   environ: &env-def {environ_update: {LANGUAGE: C, LC_ALL: C}, check_rc: true}
+  out: &version-output |
+    xfconf-query 4.18.1
+
+    Copyright (c) 2008-2023
+        The Xfce development team. All rights reserved.
+
+    Please report bugs to <https://gitlab.xfce.org/xfce/xfconf>.
 test_cases:
 - id: test_simple_property_get
   input:
@@ -14,8 +21,14 @@ test_cases:
   output:
     value: '100'
     is_array: false
+    version: "4.18.1"
   mocks:
     run_command:
+    - command: [/testbin/xfconf-query, --version]
+      environ: *env-def
+      rc: 0
+      out: *version-output
+      err: ""
     - command: [/testbin/xfconf-query, --channel, xfwm4, --property, /general/inactive_opacity]
       environ: *env-def
       rc: 0
@@ -25,9 +38,15 @@ test_cases:
   input:
     channel: xfwm4
     property: /general/i_dont_exist
-  output: {}
+  output:
+    version: "4.18.1"
   mocks:
     run_command:
+    - command: [/testbin/xfconf-query, --version]
+      environ: *env-def
+      rc: 0
+      out: *version-output
+      err: ""
     - command: [/testbin/xfconf-query, --channel, xfwm4, --property, /general/i_dont_exist]
       environ: *env-def
       rc: 1
@@ -39,8 +58,6 @@ test_cases:
   output:
     failed: true
     msg: "missing parameter(s) required by 'property': channel"
-  mocks:
-    run_command: []
 - id: test_property_get_array
   input:
     channel: xfwm4
@@ -48,8 +65,14 @@ test_cases:
   output:
     is_array: true
     value_array: [Main, Work, Tmp]
+    version: "4.18.1"
   mocks:
     run_command:
+    - command: [/testbin/xfconf-query, --version]
+      environ: *env-def
+      rc: 0
+      out: *version-output
+      err: ""
     - command: [/testbin/xfconf-query, --channel, xfwm4, --property, /general/workspace_names]
       environ: *env-def
       rc: 0
@@ -59,8 +82,14 @@ test_cases:
   input: {}
   output:
     channels: [a, b, c]
+    version: "4.18.1"
   mocks:
     run_command:
+    - command: [/testbin/xfconf-query, --version]
+      environ: *env-def
+      rc: 0
+      out: *version-output
+      err: ""
     - command: [/testbin/xfconf-query, --list]
       environ: *env-def
       rc: 0
@@ -77,8 +106,14 @@ test_cases:
     - /general/wrap_windows
     - /general/wrap_workspaces
     - /general/zoom_desktop
+    version: "4.18.1"
   mocks:
     run_command:
+    - command: [/testbin/xfconf-query, --version]
+      environ: *env-def
+      rc: 0
+      out: *version-output
+      err: ""
     - command: [/testbin/xfconf-query, --list, --channel, xfwm4]
       environ: *env-def
       rc: 0