Fixes solaris (sunos) uptime in ansible facts module (#54626)

* correct uptime on solaris by using system boot_time instead of snaptime
* add unit test
This commit is contained in:
Anatoly Pugachev 2019-04-16 01:01:24 +03:00 committed by Sam Doran
commit b28c73af62
3 changed files with 24 additions and 8 deletions

View file

@ -17,6 +17,7 @@ from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
import re
import time
from ansible.module_utils.six.moves import reduce
@ -266,18 +267,15 @@ class SunOSHardware(Hardware):
def get_uptime_facts(self):
uptime_facts = {}
# On Solaris, unix:0:system_misc:snaptime is created shortly after machine boots up
# and displays tiem in seconds. This is much easier than using uptime as we would
# need to have a parsing procedure for translating from human-readable to machine-readable
# format.
# Example output:
# unix:0:system_misc:snaptime 1175.410463590
rc, out, err = self.module.run_command('/usr/bin/kstat -p unix:0:system_misc:snaptime')
# sample kstat output:
# unix:0:system_misc:boot_time 1548249689
rc, out, err = self.module.run_command('/usr/bin/kstat -p unix:0:system_misc:boot_time')
if rc != 0:
return
uptime_facts['uptime_seconds'] = int(float(out.split('\t')[1]))
# uptime = $current_time - $boot_time
uptime_facts['uptime_seconds'] = int(time.time() - int(out.split('\t')[1]))
return uptime_facts