ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-25 22:30:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

win_timezone: Clean up and check-mode support (#21387)

Browse source 
Changes include:
- Use Get-AnsibleParam with -type support
- Replace $result PSObject with normal hash
- Add check-mode support
This commit is contained in:
Dag Wieers 2017-02-21 07:01:09 +01:00 • committed by jhawkesworth
commit b0fdb6ac10
1 changed files with 29 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

49
lib/ansible/modules/windows/win_timezone.ps1
View file

@ -19,28 +19,32 @@
# WANT_JSON # WANT_JSON
# POWERSHELL_COMMON # POWERSHELL_COMMON
$params = Parse-Args $args; $result = @{
$result = New-Object psobject @{
win_timezone = New-Object psobject
changed = $false changed = $false
win_timezone = @{}
} }
$timezone = Get-Attr -obj $params -name timezone -failifempty $true -resultobj $result $params = Parse-Args $args -supports_check_mode $true
$check_mode = Get-AnsibleParam -obj $params -name "_ansible_check_mode" -type "bool" -default $false
$timezone = Get-AnsibleParam -obj $params -name "timezone" -failifempty $true -resultobj $result
Try { Try {
# Get the current timezone set # Get the current timezone set
$currentTZ = $(tzutil.exe /g) $currentTZ = $(tzutil.exe /g)
If ($LASTEXITCODE -ne 0) { Throw "An error occurred when getting the current machine's timezone setting." / If ($LASTEXITCODE -ne 0) {
Throw "An error occurred when getting the current machine's timezone setting."
}
If ( $currentTZ -eq $timezone ) { If ( $currentTZ -eq $timezone ) {
Exit-Json $result "$timezone is already set on this machine" Exit-Json $result "$timezone is already set on this machine"
} } Else {
Else {
$tzExists = $false $tzExists = $false
#Check that timezone can even be set (if it is listed from tzutil as an available timezone to the machine) #Check that timezone can even be set (if it is listed from tzutil as an available timezone to the machine)
$tzList = $(tzutil.exe /l) $tzList = $(tzutil.exe /l)
If ($LASTEXITCODE -ne 0) { Throw "An error occurred when listing the available timezones." } If ($LASTEXITCODE -ne 0) {
Throw "An error occurred when listing the available timezones."
}
ForEach ($tz in $tzList) { ForEach ($tz in $tzList) {
If ( $tz -eq $timezone ) { If ( $tz -eq $timezone ) {
$tzExists = $true $tzExists = $true
@ -49,23 +53,28 @@ Try {
} }
If ( $tzExists ) { If ( $tzExists ) {
tzutil.exe /s "$timezone" if (-not $check_mode) {
If ($LASTEXITCODE -ne 0) { Throw "An error occurred when setting the specified timezone with tzutil." } tzutil.exe /s "$timezone"
$newTZ = $(tzutil.exe /g) If ($LASTEXITCODE -ne 0) {
If ($LASTEXITCODE -ne 0) { Throw "An error occurred when getting the current machine's timezone setting." } Throw "An error occurred when setting the specified timezone with tzutil."
}
$newTZ = $(tzutil.exe /g)
If ($LASTEXITCODE -ne 0) {
Throw "An error occurred when getting the current machine's timezone setting."
}
If ( $timezone -eq $newTZ ) { If ( $timezone -eq $newTZ ) {
$result.changed = $true
}
} else {
$result.changed = $true $result.changed = $true
} }
} } Else {
Else {
Fail-Json $result "The specified timezone: $timezone isn't supported on the machine." Fail-Json $result "The specified timezone: $timezone isn't supported on the machine."
} }
} }
} } Catch {
Catch {
Fail-Json $result "Error setting timezone to: $timezone." Fail-Json $result "Error setting timezone to: $timezone."
} }
Exit-Json $result
Exit-Json $result;