ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-26 14:41:23 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Tolerate win line endings on windows module_util load (#37291)

Browse source 
* tolerate windows line endings when loading windows module utils.  Helpful for old custom windows modules.

* add test modules to demonstrate win line ending module load behaviour.

* attempt to fix sanity check failures

* pep8 fix

* explict skip of test modules from shebang check (core modules must still have expected unix style line endings)

* switch to rstrip() following core team meeting feedback
This commit is contained in:
jhawkesworth 2018-04-05 22:13:31 +01:00 • committed by Jordan Borean
commit ad94d03ba1
6 changed files with 31 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/sanity/code-smell/line-endings.py
View file

@ -8,6 +8,8 @@ def main():
'test/integration/targets/template/files/foo.dos.txt',
'test/integration/targets/win_regmerge/templates/win_line_ending.j2',
'test/integration/targets/win_template/files/foo.dos.txt',
'test/integration/targets/win_module_utils/library/legacy_only_new_way_win_line_ending.ps1',
'test/integration/targets/win_module_utils/library/legacy_only_old_way_win_line_ending.ps1',
])
for path in sys.argv[1:] or sys.stdin.read().splitlines():

2
test/sanity/code-smell/shebang.py
View file

@ -25,6 +25,8 @@ def main():
skip = set([
'hacking/cherrypick.py',
'test/integration/targets/win_module_utils/library/legacy_only_new_way_win_line_ending.ps1',
'test/integration/targets/win_module_utils/library/legacy_only_old_way_win_line_ending.ps1',
])
for path in sys.argv[1:] or sys.stdin.read().splitlines():