Fix iosxr integration tests (#34663)

* Handle non-XML errors

* Move iosxr_netconf tuning to prepare

* Apply provider warning to netconf as well

* Update netconf task files

test/integration/targets/iosxr_banner/tasks/netconf.yaml

@@ -9,8 +9,14 @@
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"
 
-- name: run test case
-  include: "{{ test_case_to_run }}"
+- name: run test cases (connection=netconf)
+  include: "{{ test_case_to_run }} ansible_connection=netconf"
   with_items: "{{ test_items }}"
   loop_control:
     loop_var: test_case_to_run
+
+- name: run test case (connection=local)
+  include: "{{ test_case_to_run }} ansible_connection=local"
+  with_first_found: "{{ test_items }}"
+  loop_control:
+    loop_var: test_case_to_run

test/integration/targets/iosxr_banner/tests/netconf/basic-login.yaml

@@ -1,11 +1,4 @@
 ---
-- name: Enable Netconf service
-  iosxr_netconf:
-    netconf_port: 830
-    netconf_vrf: 'default'
-    state: present
-  register: result
-
 - name: setup - remove login
   iosxr_banner:
     banner: login

test/integration/targets/iosxr_banner/tests/netconf/basic-motd.yaml

@@ -1,11 +1,4 @@
 ---
-- name: Enable Netconf service
-  iosxr_netconf:
-    netconf_port: 830
-    netconf_vrf: 'default'
-    state: present
-  register: result
-
 - name: setup - remove motd
   iosxr_banner:
     banner: motd

test/integration/targets/iosxr_banner/tests/netconf/basic-no-login.yaml

@@ -1,11 +1,4 @@
 ---
-- name: Enable Netconf service
-  iosxr_netconf:
-    netconf_port: 830
-    netconf_vrf: 'default'
-    state: present
-  register: result
-
 - name: Setup
   iosxr_banner:
     banner: login

test/integration/targets/iosxr_interface/tasks/netconf.yaml

@@ -9,8 +9,14 @@
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"
 
-- name: run test case
-  include: "{{ test_case_to_run }}"
+- name: run test cases (connection=netconf)
+  include: "{{ test_case_to_run }} ansible_connection=netconf"
   with_items: "{{ test_items }}"
   loop_control:
     loop_var: test_case_to_run
+
+- name: run test case (connection=local)
+  include: "{{ test_case_to_run }} ansible_connection=local"
+  with_first_found: "{{ test_items }}"
+  loop_control:
+    loop_var: test_case_to_run

test/integration/targets/iosxr_interface/tests/netconf/basic.yaml

@@ -1,13 +1,6 @@
 ---
 - debug: msg="START iosxr_interface netconf/basic.yaml"
 
-- name: Enable Netconf service
-  iosxr_netconf:
-    netconf_port: 830
-    netconf_vrf: 'default'
-    state: present
-  register: result
-
 - name: Setup interface
   iosxr_interface:
     name: GigabitEthernet0/0/0/1

test/integration/targets/prepare_iosxr_tests/tasks/main.yml

@@ -1,10 +1,17 @@
 ---
-
 - name: Ensure we have loopback 888 for testing
   iosxr_config:
     src: config.j2
   connection: network_cli
 
+- name: Enable Netconf service
+  iosxr_netconf:
+    netconf_port: 830
+    netconf_vrf: 'default'
+    state: present
+  connection: network_cli
+  tags: netconf
+
 # Some AWS hostnames can be longer than those allowed by the system we are testing
 # Truncate the hostname
 # http://jinja.pocoo.org/docs/2.9/templates/#truncate