apk: fix empty/whitespace-only package name check (#10532)

* Fix empty/whitespace-only package name check.

* Adjust test.
This commit is contained in:
Felix Fontein 2025-08-02 16:41:24 +02:00 committed by GitHub
commit abfe1e6180
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 8 additions and 5 deletions

View file

@ -0,0 +1,2 @@
bugfixes:
- "apk - fix check for empty/whitespace-only package names (https://github.com/ansible-collections/community.general/pull/10532)."

View file

@ -351,7 +351,7 @@ def main():
p = module.params p = module.params
if all(not name.strip() for name in p['name']): if p['name'] and any(not name.strip() for name in p['name']):
module.fail_json(msg="Package name(s) cannot be empty or whitespace-only") module.fail_json(msg="Package name(s) cannot be empty or whitespace-only")
if p['no_cache']: if p['no_cache']:

View file

@ -183,16 +183,17 @@
- result_spaces is failed - result_spaces is failed
- "'Package name(s) cannot be empty or whitespace-only' == result_spaces.msg" - "'Package name(s) cannot be empty or whitespace-only' == result_spaces.msg"
- name: Accept list with valid and empty string - name: Do not accept list with valid and empty string
community.general.apk: community.general.apk:
name: ["busybox", ""] name: ["busybox", ""]
register: result_valid_mixed register: result_invalid_mixed
ignore_errors: true ignore_errors: true
- name: Assert success with mixed package list - name: Assert failure with mixed package list
ansible.builtin.assert: ansible.builtin.assert:
that: that:
- result_valid_mixed is not failed - result_invalid_mixed is failed
- "'Package name(s) cannot be empty or whitespace-only' == result_invalid_mixed.msg"
- name: Reject package name list with multiple empty/whitespace-only strings - name: Reject package name list with multiple empty/whitespace-only strings
community.general.apk: community.general.apk: