Tidy up validate-modules nonexistent-parameter-documented (#1389) (#1400)

* fixed validation-modules for plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py

* fixed validation-modules for plugins/modules/cloud/univention/udm_share.py

* fixed validation-modules for plugins/modules/net_tools/nios/nios_host_record.py

* fixed validation-modules for plugins/modules/storage/zfs/zfs_facts.py

* fixed validation-modules for plugins/modules/storage/zfs/zpool_facts.py

* Tidy up validate-modules ignores nonexistent-parameter-documented

* Adjustments per the PR

* Removed no longer needed ignore line for udm_share.py

(cherry picked from commit 7f890c4645)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py

@@ -144,13 +144,6 @@ options:
         This will not work unless the uniqueness_by field is set to id.
         When this is set, and the uniqueness_by field is set, the group will either be updated or deleted, but not created.
 
-  ignore_changes:
-    choices:
-      - image_id
-      - target
-    description:
-      - (List of Strings) list of fields on which changes should be ignored when updating
-
   image_id:
     description:
       - (String) The image Id used to launch the instance.;

plugins/modules/cloud/univention/udm_share.py

@@ -90,12 +90,12 @@ options:
         description:
             - Blocking locks.
         aliases: [ sambaBlockingLocks ]
-    samba_browseable:
+    sambaBrowseable:
-        default: '1'
-        choices: [ '0', '1' ]
         description:
-            - Show in Windows network environment.
+        - Show in Windows network environment.
-        aliases: [ sambaBrowseable ]
+        type: bool
+        default: True
+        aliases: [ samba_browsable ]
     samba_create_mode:
         default: '0744'
         description:

plugins/modules/net_tools/nios/nios_host_record.py

@@ -107,8 +107,6 @@ options:
           - Configure the host_record over DHCP instead of DNS, if user
             changes it to true, user need to mention MAC address to configure
         required: false
-        aliases:
-          - dhcp
   aliases:
     description:
       - Configures an optional list of additional aliases to add to the host

plugins/modules/storage/zfs/zfs_facts.py

@@ -38,7 +38,6 @@ options:
             - Specifies which dataset properties should be queried in comma-separated format.
               For more information about dataset properties, check zfs(1M) man page.
         default: all
-        aliases: [ "props" ]
     type:
         description:
             - Specifies which datasets types to display. Multiple values have to be

plugins/modules/storage/zfs/zpool_facts.py

@@ -32,7 +32,6 @@ options:
         description:
             - Specifies which dataset properties should be queried in comma-separated format.
               For more information about dataset properties, check zpool(1M) man page.
-        aliases: [ "props" ]
         default: all
         required: false
 '''

tests/sanity/ignore-2.10.txt

@@ -221,7 +221,6 @@ plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:doc-
 plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:doc-default-does-not-match-spec
 plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:doc-missing-type
 plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:doc-required-mismatch
-plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:nonexistent-parameter-documented
 plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:parameter-list-no-elements
 plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:parameter-type-not-in-doc
 plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:undocumented-parameter
@@ -235,10 +234,8 @@ plugins/modules/cloud/univention/udm_group.py validate-modules:doc-default-does-
 plugins/modules/cloud/univention/udm_group.py validate-modules:parameter-type-not-in-doc
 plugins/modules/cloud/univention/udm_share.py validate-modules:doc-choices-do-not-match-spec
 plugins/modules/cloud/univention/udm_share.py validate-modules:doc-default-does-not-match-spec
-plugins/modules/cloud/univention/udm_share.py validate-modules:nonexistent-parameter-documented
 plugins/modules/cloud/univention/udm_share.py validate-modules:parameter-list-no-elements
 plugins/modules/cloud/univention/udm_share.py validate-modules:parameter-type-not-in-doc
-plugins/modules/cloud/univention/udm_share.py validate-modules:undocumented-parameter
 plugins/modules/cloud/univention/udm_user.py validate-modules:doc-choices-do-not-match-spec
 plugins/modules/cloud/univention/udm_user.py validate-modules:doc-default-does-not-match-spec
 plugins/modules/cloud/univention/udm_user.py validate-modules:parameter-list-no-elements
@@ -386,7 +383,6 @@ plugins/modules/net_tools/nios/nios_host_record.py validate-modules:doc-elements
 plugins/modules/net_tools/nios/nios_host_record.py validate-modules:doc-missing-type
 plugins/modules/net_tools/nios/nios_host_record.py validate-modules:doc-required-mismatch
 plugins/modules/net_tools/nios/nios_host_record.py validate-modules:invalid-ansiblemodule-schema
-plugins/modules/net_tools/nios/nios_host_record.py validate-modules:nonexistent-parameter-documented
 plugins/modules/net_tools/nios/nios_host_record.py validate-modules:parameter-list-no-elements
 plugins/modules/net_tools/nios/nios_host_record.py validate-modules:parameter-type-not-in-doc
 plugins/modules/net_tools/nios/nios_host_record.py validate-modules:undocumented-parameter
@@ -659,9 +655,7 @@ plugins/modules/storage/zfs/zfs.py validate-modules:parameter-type-not-in-doc
 plugins/modules/storage/zfs/zfs_delegate_admin.py validate-modules:doc-required-mismatch
 plugins/modules/storage/zfs/zfs_delegate_admin.py validate-modules:parameter-list-no-elements
 plugins/modules/storage/zfs/zfs_delegate_admin.py validate-modules:parameter-type-not-in-doc
-plugins/modules/storage/zfs/zfs_facts.py validate-modules:nonexistent-parameter-documented
 plugins/modules/storage/zfs/zfs_facts.py validate-modules:parameter-type-not-in-doc
-plugins/modules/storage/zfs/zpool_facts.py validate-modules:nonexistent-parameter-documented
 plugins/modules/storage/zfs/zpool_facts.py validate-modules:parameter-type-not-in-doc
 plugins/modules/system/aix_devices.py validate-modules:doc-required-mismatch
 plugins/modules/system/alternatives.py pylint:blacklisted-name

tests/sanity/ignore-2.11.txt

@@ -221,7 +221,6 @@ plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:doc-
 plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:doc-default-does-not-match-spec
 plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:doc-missing-type
 plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:doc-required-mismatch
-plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:nonexistent-parameter-documented
 plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:parameter-list-no-elements
 plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:parameter-type-not-in-doc
 plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:undocumented-parameter
@@ -235,10 +234,8 @@ plugins/modules/cloud/univention/udm_group.py validate-modules:doc-default-does-
 plugins/modules/cloud/univention/udm_group.py validate-modules:parameter-type-not-in-doc
 plugins/modules/cloud/univention/udm_share.py validate-modules:doc-choices-do-not-match-spec
 plugins/modules/cloud/univention/udm_share.py validate-modules:doc-default-does-not-match-spec
-plugins/modules/cloud/univention/udm_share.py validate-modules:nonexistent-parameter-documented
 plugins/modules/cloud/univention/udm_share.py validate-modules:parameter-list-no-elements
 plugins/modules/cloud/univention/udm_share.py validate-modules:parameter-type-not-in-doc
-plugins/modules/cloud/univention/udm_share.py validate-modules:undocumented-parameter
 plugins/modules/cloud/univention/udm_user.py validate-modules:doc-choices-do-not-match-spec
 plugins/modules/cloud/univention/udm_user.py validate-modules:doc-default-does-not-match-spec
 plugins/modules/cloud/univention/udm_user.py validate-modules:parameter-list-no-elements
@@ -386,7 +383,6 @@ plugins/modules/net_tools/nios/nios_host_record.py validate-modules:doc-elements
 plugins/modules/net_tools/nios/nios_host_record.py validate-modules:doc-missing-type
 plugins/modules/net_tools/nios/nios_host_record.py validate-modules:doc-required-mismatch
 plugins/modules/net_tools/nios/nios_host_record.py validate-modules:invalid-ansiblemodule-schema
-plugins/modules/net_tools/nios/nios_host_record.py validate-modules:nonexistent-parameter-documented
 plugins/modules/net_tools/nios/nios_host_record.py validate-modules:parameter-list-no-elements
 plugins/modules/net_tools/nios/nios_host_record.py validate-modules:parameter-type-not-in-doc
 plugins/modules/net_tools/nios/nios_host_record.py validate-modules:undocumented-parameter
@@ -659,9 +655,7 @@ plugins/modules/storage/zfs/zfs.py validate-modules:parameter-type-not-in-doc
 plugins/modules/storage/zfs/zfs_delegate_admin.py validate-modules:doc-required-mismatch
 plugins/modules/storage/zfs/zfs_delegate_admin.py validate-modules:parameter-list-no-elements
 plugins/modules/storage/zfs/zfs_delegate_admin.py validate-modules:parameter-type-not-in-doc
-plugins/modules/storage/zfs/zfs_facts.py validate-modules:nonexistent-parameter-documented
 plugins/modules/storage/zfs/zfs_facts.py validate-modules:parameter-type-not-in-doc
-plugins/modules/storage/zfs/zpool_facts.py validate-modules:nonexistent-parameter-documented
 plugins/modules/storage/zfs/zpool_facts.py validate-modules:parameter-type-not-in-doc
 plugins/modules/system/aix_devices.py validate-modules:doc-required-mismatch
 plugins/modules/system/alternatives.py pylint:blacklisted-name

tests/sanity/ignore-2.9.txt

@@ -213,7 +213,6 @@ plugins/modules/cloud/smartos/vmadm.py validate-modules:undocumented-parameter
 plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:doc-choices-do-not-match-spec
 plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:doc-default-does-not-match-spec
 plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:doc-missing-type
-plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:nonexistent-parameter-documented
 plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:parameter-type-not-in-doc
 plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py validate-modules:undocumented-parameter
 plugins/modules/cloud/univention/udm_dns_record.py validate-modules:doc-choices-do-not-match-spec
@@ -225,9 +224,7 @@ plugins/modules/cloud/univention/udm_group.py validate-modules:doc-default-does-
 plugins/modules/cloud/univention/udm_group.py validate-modules:parameter-type-not-in-doc
 plugins/modules/cloud/univention/udm_share.py validate-modules:doc-choices-do-not-match-spec
 plugins/modules/cloud/univention/udm_share.py validate-modules:doc-default-does-not-match-spec
-plugins/modules/cloud/univention/udm_share.py validate-modules:nonexistent-parameter-documented
 plugins/modules/cloud/univention/udm_share.py validate-modules:parameter-type-not-in-doc
-plugins/modules/cloud/univention/udm_share.py validate-modules:undocumented-parameter
 plugins/modules/cloud/univention/udm_user.py validate-modules:doc-choices-do-not-match-spec
 plugins/modules/cloud/univention/udm_user.py validate-modules:doc-default-does-not-match-spec
 plugins/modules/cloud/univention/udm_user.py validate-modules:parameter-type-not-in-doc
@@ -326,7 +323,6 @@ plugins/modules/net_tools/nios/nios_fixed_address.py validate-modules:parameter-
 plugins/modules/net_tools/nios/nios_fixed_address.py validate-modules:undocumented-parameter
 plugins/modules/net_tools/nios/nios_host_record.py validate-modules:doc-default-does-not-match-spec
 plugins/modules/net_tools/nios/nios_host_record.py validate-modules:doc-missing-type
-plugins/modules/net_tools/nios/nios_host_record.py validate-modules:nonexistent-parameter-documented
 plugins/modules/net_tools/nios/nios_host_record.py validate-modules:parameter-type-not-in-doc
 plugins/modules/net_tools/nios/nios_host_record.py validate-modules:undocumented-parameter
 plugins/modules/net_tools/nios/nios_member.py validate-modules:doc-default-does-not-match-spec
@@ -531,9 +527,7 @@ plugins/modules/storage/purestorage/purefb_facts.py validate-modules:invalid-doc
 plugins/modules/storage/purestorage/purefb_facts.py validate-modules:return-syntax-error
 plugins/modules/storage/zfs/zfs.py validate-modules:parameter-type-not-in-doc
 plugins/modules/storage/zfs/zfs_delegate_admin.py validate-modules:parameter-type-not-in-doc
-plugins/modules/storage/zfs/zfs_facts.py validate-modules:nonexistent-parameter-documented
 plugins/modules/storage/zfs/zfs_facts.py validate-modules:parameter-type-not-in-doc
-plugins/modules/storage/zfs/zpool_facts.py validate-modules:nonexistent-parameter-documented
 plugins/modules/storage/zfs/zpool_facts.py validate-modules:parameter-type-not-in-doc
 plugins/modules/system/alternatives.py pylint:blacklisted-name
 plugins/modules/system/beadm.py pylint:blacklisted-name