From a90759d9490d1155292c412d2a39f4ef556bce83 Mon Sep 17 00:00:00 2001
From: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Date: Sun, 10 Aug 2025 23:35:45 +1200
Subject: [PATCH] portage: command args as list rather than string (#10602)

* portage: command args as list rather than string

* add changelog frag

* fix pr number in chglog frag
---
 changelogs/fragments/10602-portage-cmd-list.yml |  2 ++
 plugins/modules/portage.py                      | 12 ++++++------
 2 files changed, 8 insertions(+), 6 deletions(-)
 create mode 100644 changelogs/fragments/10602-portage-cmd-list.yml

diff --git a/changelogs/fragments/10602-portage-cmd-list.yml b/changelogs/fragments/10602-portage-cmd-list.yml
new file mode 100644
index 0000000000..36b6711e00
--- /dev/null
+++ b/changelogs/fragments/10602-portage-cmd-list.yml
@@ -0,0 +1,2 @@
+minor_changes:
+  - portage - using safer mechanism to run external command (https://github.com/ansible-collections/community.general/pull/10602).
diff --git a/plugins/modules/portage.py b/plugins/modules/portage.py
index 8a00b934dd..a950d8ce85 100644
--- a/plugins/modules/portage.py
+++ b/plugins/modules/portage.py
@@ -282,7 +282,7 @@ def query_atom(module, atom, action):
     return bool(exists)
 
 
-def query_set(module, set, action):
+def query_set(module, set_, action):
     system_sets = [
         '@live-rebuild',
         '@module-rebuild',
@@ -294,16 +294,16 @@ def query_set(module, set, action):
         '@x11-module-rebuild',
     ]
 
-    if set in system_sets:
+    if set_ in system_sets:
         if action == 'unmerge':
-            module.fail_json(msg='set %s cannot be removed' % set)
+            module.fail_json(msg='set %s cannot be removed' % set_)
         return False
 
     world_sets_path = '/var/lib/portage/world_sets'
     if not os.path.exists(world_sets_path):
         return False
 
-    cmd = 'grep %s %s' % (set, world_sets_path)
+    cmd = ['grep', set_, world_sets_path]
 
     rc, out, err = module.run_command(cmd)
     return rc == 0
@@ -315,9 +315,9 @@ def sync_repositories(module, webrsync=False):
 
     if webrsync:
         webrsync_path = module.get_bin_path('emerge-webrsync', required=True)
-        cmd = '%s --quiet' % webrsync_path
+        cmd = [webrsync_path, '--quiet']
     else:
-        cmd = '%s --sync --quiet --ask=n' % module.emerge_path
+        cmd = [module.emerge_path, '--sync', '--quiet', '--ask=n']
 
     rc, out, err = module.run_command(cmd)
     if rc != 0: