ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-05-07 17:51:29 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Add a new check to ensure that module arguments are valid python identifiers (#53278)

Browse source 
* Add a new check to ensure that module arguments are valid python identifiers

* Move the check up higher, out of the if docs block

* Skip validate-modules on py2

* Remove errant alias
This commit is contained in:
Matt Martz 2019-03-05 10:26:06 -06:00 • committed by GitHub
parent 04c6f94269
commit a639dc6d88
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 40 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/sanity/validate-modules/main.py
View file

@ -1301,6 +1301,14 @@ class ModuleValidator(Validator):
"but documentation defines choices as (%r)" % (arg, arg_choices, doc_choices))
)
for arg in args_from_argspec:
if not str(arg).isidentifier():
self.reporter.error(
path=self.object_path,
code=336,
msg="Argument '%s' is not a valid python identifier" % arg
)
if docs:
file_common_arguments = set()
for arg, data in FILE_COMMON_ARGUMENTS.items():