mirror of
https://github.com/ansible-collections/community.general.git
synced 2025-07-25 06:10:22 -07:00
Handle virtual machine config element gracefully (#32924)
This fix uses '_get_vm_prop' API to handle virtual machine related properties rather than failing with AttributeError. Handled invalid request type while connecting to ESXi server, which is caused by malformed request. Fixes: #32477 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
This commit is contained in:
parent
90e9969fb5
commit
a40ce1ba5e
2 changed files with 13 additions and 8 deletions
|
@ -51,12 +51,12 @@ virtual_machines:
|
|||
|
||||
try:
|
||||
from pyVmomi import vim, vmodl
|
||||
HAS_PYVMOMI = True
|
||||
except ImportError:
|
||||
HAS_PYVMOMI = False
|
||||
pass
|
||||
|
||||
from ansible.module_utils.basic import AnsibleModule
|
||||
from ansible.module_utils.vmware import HAS_PYVMOMI, connect_to_api, get_all_objs, vmware_argument_spec
|
||||
from ansible.module_utils.vmware import (HAS_PYVMOMI, connect_to_api, get_all_objs,
|
||||
vmware_argument_spec, _get_vm_prop)
|
||||
|
||||
|
||||
# https://github.com/vmware/pyvmomi-community-samples/blob/master/samples/getallvms.py
|
||||
|
@ -72,8 +72,9 @@ def get_all_virtual_machines(content):
|
|||
if _ip_address is None:
|
||||
_ip_address = ""
|
||||
_mac_address = []
|
||||
if vm.config is not None:
|
||||
for dev in vm.config.hardware.device:
|
||||
all_devices = _get_vm_prop(vm, ('config', 'hardware', 'device'))
|
||||
if all_devices:
|
||||
for dev in all_devices:
|
||||
if isinstance(dev, vim.vm.device.VirtualEthernetCard):
|
||||
_mac_address.append(dev.macAddress)
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue