mirror of
https://github.com/ansible-collections/community.general.git
synced 2025-06-28 03:00:23 -07:00
Unit tests: make set_module_args() a context manager, and remove copies of it in some tests (#9838)
Make set_module_args() a context manager, and remove copies of set_module_args(). Prepares for Data Tagging.
This commit is contained in:
Felix Fontein
GitHub
parent
402f725424
commit
a1781d09dd
84 changed files with 4043 additions and 4302 deletions
|
|
@ -33,12 +33,12 @@ class TestDatadogDowntime(ModuleTestCase):
|
|||
def test_without_required_parameters(self):
|
||||
"""Failure must occurs when all parameters are missing"""
|
||||
with self.assertRaises(AnsibleFailJson):
|
||||
set_module_args({})
|
||||
self.module.main()
|
||||
with set_module_args({}):
|
||||
self.module.main()
|
||||
|
||||
@patch("ansible_collections.community.general.plugins.modules.datadog_downtime.DowntimesApi")
|
||||
def test_create_downtime_when_no_id(self, downtimes_api_mock):
|
||||
set_module_args({
|
||||
with set_module_args({
|
||||
"monitor_tags": ["foo:bar"],
|
||||
"scope": ["*"],
|
||||
"monitor_id": 12345,
|
||||
|
|
@ -49,32 +49,32 @@ class TestDatadogDowntime(ModuleTestCase):
|
|||
"rrule": "rrule",
|
||||
"api_key": "an_api_key",
|
||||
"app_key": "an_app_key",
|
||||
})
|
||||
}):
|
||||
downtime = Downtime()
|
||||
downtime.monitor_tags = ["foo:bar"]
|
||||
downtime.scope = ["*"]
|
||||
downtime.monitor_id = 12345
|
||||
downtime.message = "Message"
|
||||
downtime.start = 1111
|
||||
downtime.end = 2222
|
||||
downtime.timezone = "UTC"
|
||||
downtime.recurrence = DowntimeRecurrence(
|
||||
rrule="rrule",
|
||||
type="rrule"
|
||||
)
|
||||
|
||||
downtime = Downtime()
|
||||
downtime.monitor_tags = ["foo:bar"]
|
||||
downtime.scope = ["*"]
|
||||
downtime.monitor_id = 12345
|
||||
downtime.message = "Message"
|
||||
downtime.start = 1111
|
||||
downtime.end = 2222
|
||||
downtime.timezone = "UTC"
|
||||
downtime.recurrence = DowntimeRecurrence(
|
||||
rrule="rrule",
|
||||
type="rrule"
|
||||
)
|
||||
create_downtime_mock = MagicMock(return_value=self.__downtime_with_id(12345))
|
||||
downtimes_api_mock.return_value = MagicMock(create_downtime=create_downtime_mock)
|
||||
with self.assertRaises(AnsibleExitJson) as result:
|
||||
self.module.main()
|
||||
|
||||
create_downtime_mock = MagicMock(return_value=self.__downtime_with_id(12345))
|
||||
downtimes_api_mock.return_value = MagicMock(create_downtime=create_downtime_mock)
|
||||
with self.assertRaises(AnsibleExitJson) as result:
|
||||
self.module.main()
|
||||
self.assertTrue(result.exception.args[0]['changed'])
|
||||
self.assertEqual(result.exception.args[0]['downtime']['id'], 12345)
|
||||
create_downtime_mock.assert_called_once_with(downtime)
|
||||
|
||||
@patch("ansible_collections.community.general.plugins.modules.datadog_downtime.DowntimesApi")
|
||||
def test_create_downtime_when_id_and_disabled(self, downtimes_api_mock):
|
||||
set_module_args({
|
||||
with set_module_args({
|
||||
"id": 1212,
|
||||
"monitor_tags": ["foo:bar"],
|
||||
"scope": ["*"],
|
||||
|
|
@ -86,32 +86,32 @@ class TestDatadogDowntime(ModuleTestCase):
|
|||
"rrule": "rrule",
|
||||
"api_key": "an_api_key",
|
||||
"app_key": "an_app_key",
|
||||
})
|
||||
}):
|
||||
downtime = Downtime()
|
||||
downtime.monitor_tags = ["foo:bar"]
|
||||
downtime.scope = ["*"]
|
||||
downtime.monitor_id = 12345
|
||||
downtime.message = "Message"
|
||||
downtime.start = 1111
|
||||
downtime.end = 2222
|
||||
downtime.timezone = "UTC"
|
||||
downtime.recurrence = DowntimeRecurrence(
|
||||
rrule="rrule",
|
||||
type="rrule"
|
||||
)
|
||||
|
||||
downtime = Downtime()
|
||||
downtime.monitor_tags = ["foo:bar"]
|
||||
downtime.scope = ["*"]
|
||||
downtime.monitor_id = 12345
|
||||
downtime.message = "Message"
|
||||
downtime.start = 1111
|
||||
downtime.end = 2222
|
||||
downtime.timezone = "UTC"
|
||||
downtime.recurrence = DowntimeRecurrence(
|
||||
rrule="rrule",
|
||||
type="rrule"
|
||||
)
|
||||
disabled_downtime = Downtime()
|
||||
disabled_downtime.disabled = True
|
||||
disabled_downtime.id = 1212
|
||||
|
||||
disabled_downtime = Downtime()
|
||||
disabled_downtime.disabled = True
|
||||
disabled_downtime.id = 1212
|
||||
create_downtime_mock = MagicMock(return_value=self.__downtime_with_id(12345))
|
||||
get_downtime_mock = MagicMock(return_value=disabled_downtime)
|
||||
downtimes_api_mock.return_value = MagicMock(
|
||||
create_downtime=create_downtime_mock, get_downtime=get_downtime_mock
|
||||
)
|
||||
with self.assertRaises(AnsibleExitJson) as result:
|
||||
self.module.main()
|
||||
|
||||
create_downtime_mock = MagicMock(return_value=self.__downtime_with_id(12345))
|
||||
get_downtime_mock = MagicMock(return_value=disabled_downtime)
|
||||
downtimes_api_mock.return_value = MagicMock(
|
||||
create_downtime=create_downtime_mock, get_downtime=get_downtime_mock
|
||||
)
|
||||
with self.assertRaises(AnsibleExitJson) as result:
|
||||
self.module.main()
|
||||
self.assertTrue(result.exception.args[0]['changed'])
|
||||
self.assertEqual(result.exception.args[0]['downtime']['id'], 12345)
|
||||
create_downtime_mock.assert_called_once_with(downtime)
|
||||
|
|
@ -119,7 +119,7 @@ class TestDatadogDowntime(ModuleTestCase):
|
|||
|
||||
@patch("ansible_collections.community.general.plugins.modules.datadog_downtime.DowntimesApi")
|
||||
def test_update_downtime_when_not_disabled(self, downtimes_api_mock):
|
||||
set_module_args({
|
||||
with set_module_args({
|
||||
"id": 1212,
|
||||
"monitor_tags": ["foo:bar"],
|
||||
"scope": ["*"],
|
||||
|
|
@ -131,32 +131,32 @@ class TestDatadogDowntime(ModuleTestCase):
|
|||
"rrule": "rrule",
|
||||
"api_key": "an_api_key",
|
||||
"app_key": "an_app_key",
|
||||
})
|
||||
}):
|
||||
downtime = Downtime()
|
||||
downtime.monitor_tags = ["foo:bar"]
|
||||
downtime.scope = ["*"]
|
||||
downtime.monitor_id = 12345
|
||||
downtime.message = "Message"
|
||||
downtime.start = 1111
|
||||
downtime.end = 2222
|
||||
downtime.timezone = "UTC"
|
||||
downtime.recurrence = DowntimeRecurrence(
|
||||
rrule="rrule",
|
||||
type="rrule"
|
||||
)
|
||||
|
||||
downtime = Downtime()
|
||||
downtime.monitor_tags = ["foo:bar"]
|
||||
downtime.scope = ["*"]
|
||||
downtime.monitor_id = 12345
|
||||
downtime.message = "Message"
|
||||
downtime.start = 1111
|
||||
downtime.end = 2222
|
||||
downtime.timezone = "UTC"
|
||||
downtime.recurrence = DowntimeRecurrence(
|
||||
rrule="rrule",
|
||||
type="rrule"
|
||||
)
|
||||
enabled_downtime = Downtime()
|
||||
enabled_downtime.disabled = False
|
||||
enabled_downtime.id = 1212
|
||||
|
||||
enabled_downtime = Downtime()
|
||||
enabled_downtime.disabled = False
|
||||
enabled_downtime.id = 1212
|
||||
update_downtime_mock = MagicMock(return_value=self.__downtime_with_id(1212))
|
||||
get_downtime_mock = MagicMock(return_value=enabled_downtime)
|
||||
downtimes_api_mock.return_value = MagicMock(
|
||||
update_downtime=update_downtime_mock, get_downtime=get_downtime_mock
|
||||
)
|
||||
with self.assertRaises(AnsibleExitJson) as result:
|
||||
self.module.main()
|
||||
|
||||
update_downtime_mock = MagicMock(return_value=self.__downtime_with_id(1212))
|
||||
get_downtime_mock = MagicMock(return_value=enabled_downtime)
|
||||
downtimes_api_mock.return_value = MagicMock(
|
||||
update_downtime=update_downtime_mock, get_downtime=get_downtime_mock
|
||||
)
|
||||
with self.assertRaises(AnsibleExitJson) as result:
|
||||
self.module.main()
|
||||
self.assertTrue(result.exception.args[0]['changed'])
|
||||
self.assertEqual(result.exception.args[0]['downtime']['id'], 1212)
|
||||
update_downtime_mock.assert_called_once_with(1212, downtime)
|
||||
|
|
@ -164,7 +164,7 @@ class TestDatadogDowntime(ModuleTestCase):
|
|||
|
||||
@patch("ansible_collections.community.general.plugins.modules.datadog_downtime.DowntimesApi")
|
||||
def test_update_downtime_no_change(self, downtimes_api_mock):
|
||||
set_module_args({
|
||||
with set_module_args({
|
||||
"id": 1212,
|
||||
"monitor_tags": ["foo:bar"],
|
||||
"scope": ["*"],
|
||||
|
|
@ -176,42 +176,42 @@ class TestDatadogDowntime(ModuleTestCase):
|
|||
"rrule": "rrule",
|
||||
"api_key": "an_api_key",
|
||||
"app_key": "an_app_key",
|
||||
})
|
||||
}):
|
||||
downtime = Downtime()
|
||||
downtime.monitor_tags = ["foo:bar"]
|
||||
downtime.scope = ["*"]
|
||||
downtime.monitor_id = 12345
|
||||
downtime.message = "Message"
|
||||
downtime.start = 1111
|
||||
downtime.end = 2222
|
||||
downtime.timezone = "UTC"
|
||||
downtime.recurrence = DowntimeRecurrence(
|
||||
rrule="rrule",
|
||||
type="rrule"
|
||||
)
|
||||
|
||||
downtime = Downtime()
|
||||
downtime.monitor_tags = ["foo:bar"]
|
||||
downtime.scope = ["*"]
|
||||
downtime.monitor_id = 12345
|
||||
downtime.message = "Message"
|
||||
downtime.start = 1111
|
||||
downtime.end = 2222
|
||||
downtime.timezone = "UTC"
|
||||
downtime.recurrence = DowntimeRecurrence(
|
||||
rrule="rrule",
|
||||
type="rrule"
|
||||
)
|
||||
downtime_get = Downtime()
|
||||
downtime_get.id = 1212
|
||||
downtime_get.disabled = False
|
||||
downtime_get.monitor_tags = ["foo:bar"]
|
||||
downtime_get.scope = ["*"]
|
||||
downtime_get.monitor_id = 12345
|
||||
downtime_get.message = "Message"
|
||||
downtime_get.start = 1111
|
||||
downtime_get.end = 2222
|
||||
downtime_get.timezone = "UTC"
|
||||
downtime_get.recurrence = DowntimeRecurrence(
|
||||
rrule="rrule"
|
||||
)
|
||||
|
||||
downtime_get = Downtime()
|
||||
downtime_get.id = 1212
|
||||
downtime_get.disabled = False
|
||||
downtime_get.monitor_tags = ["foo:bar"]
|
||||
downtime_get.scope = ["*"]
|
||||
downtime_get.monitor_id = 12345
|
||||
downtime_get.message = "Message"
|
||||
downtime_get.start = 1111
|
||||
downtime_get.end = 2222
|
||||
downtime_get.timezone = "UTC"
|
||||
downtime_get.recurrence = DowntimeRecurrence(
|
||||
rrule="rrule"
|
||||
)
|
||||
update_downtime_mock = MagicMock(return_value=downtime_get)
|
||||
get_downtime_mock = MagicMock(return_value=downtime_get)
|
||||
downtimes_api_mock.return_value = MagicMock(
|
||||
update_downtime=update_downtime_mock, get_downtime=get_downtime_mock
|
||||
)
|
||||
with self.assertRaises(AnsibleExitJson) as result:
|
||||
self.module.main()
|
||||
|
||||
update_downtime_mock = MagicMock(return_value=downtime_get)
|
||||
get_downtime_mock = MagicMock(return_value=downtime_get)
|
||||
downtimes_api_mock.return_value = MagicMock(
|
||||
update_downtime=update_downtime_mock, get_downtime=get_downtime_mock
|
||||
)
|
||||
with self.assertRaises(AnsibleExitJson) as result:
|
||||
self.module.main()
|
||||
self.assertFalse(result.exception.args[0]['changed'])
|
||||
self.assertEqual(result.exception.args[0]['downtime']['id'], 1212)
|
||||
update_downtime_mock.assert_called_once_with(1212, downtime)
|
||||
|
|
@ -219,20 +219,20 @@ class TestDatadogDowntime(ModuleTestCase):
|
|||
|
||||
@patch("ansible_collections.community.general.plugins.modules.datadog_downtime.DowntimesApi")
|
||||
def test_delete_downtime(self, downtimes_api_mock):
|
||||
set_module_args({
|
||||
with set_module_args({
|
||||
"id": 1212,
|
||||
"state": "absent",
|
||||
"api_key": "an_api_key",
|
||||
"app_key": "an_app_key",
|
||||
})
|
||||
}):
|
||||
cancel_downtime_mock = MagicMock()
|
||||
downtimes_api_mock.return_value = MagicMock(
|
||||
get_downtime=self.__downtime_with_id,
|
||||
cancel_downtime=cancel_downtime_mock
|
||||
)
|
||||
with self.assertRaises(AnsibleExitJson) as result:
|
||||
self.module.main()
|
||||
|
||||
cancel_downtime_mock = MagicMock()
|
||||
downtimes_api_mock.return_value = MagicMock(
|
||||
get_downtime=self.__downtime_with_id,
|
||||
cancel_downtime=cancel_downtime_mock
|
||||
)
|
||||
with self.assertRaises(AnsibleExitJson) as result:
|
||||
self.module.main()
|
||||
self.assertTrue(result.exception.args[0]['changed'])
|
||||
cancel_downtime_mock.assert_called_once_with(1212)
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue