Unit tests: make set_module_args() a context manager, and remove copies of it in some tests (#9838)

Make set_module_args() a context manager, and remove copies of set_module_args().

Prepares for Data Tagging.
This commit is contained in:
Felix Fontein 2025-03-07 07:21:03 +01:00 committed by GitHub
parent 402f725424
commit a1781d09dd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
84 changed files with 4043 additions and 4302 deletions

View file

@ -19,15 +19,15 @@ class TestBucketAccessKeyModule(ModuleTestCase):
def test_missing_key_with_present_state(self):
with self.assertRaises(AnsibleFailJson) as exec_info:
set_module_args({
with set_module_args({
'client_id': 'ABC',
'client_secret': 'XXX',
'workspace': 'name',
'repository': 'repo',
'label': 'key name',
'state': 'present',
})
self.module.main()
}):
self.module.main()
self.assertEqual(exec_info.exception.args[0]['msg'], self.module.error_messages['required_key'])
@ -35,7 +35,7 @@ class TestBucketAccessKeyModule(ModuleTestCase):
def test_create_deploy_key(self, *args):
with patch.object(self.module, 'create_deploy_key') as create_deploy_key_mock:
with self.assertRaises(AnsibleExitJson) as exec_info:
set_module_args({
with set_module_args({
'user': 'ABC',
'password': 'XXX',
'workspace': 'name',
@ -43,8 +43,8 @@ class TestBucketAccessKeyModule(ModuleTestCase):
'key': 'public_key',
'label': 'key name',
'state': 'present',
})
self.module.main()
}):
self.module.main()
self.assertEqual(create_deploy_key_mock.call_count, 1)
self.assertEqual(exec_info.exception.args[0]['changed'], True)
@ -54,7 +54,7 @@ class TestBucketAccessKeyModule(ModuleTestCase):
def test_create_deploy_key_check_mode(self, *args):
with patch.object(self.module, 'create_deploy_key') as create_deploy_key_mock:
with self.assertRaises(AnsibleExitJson) as exec_info:
set_module_args({
with set_module_args({
'client_id': 'ABC',
'client_secret': 'XXX',
'workspace': 'name',
@ -63,8 +63,8 @@ class TestBucketAccessKeyModule(ModuleTestCase):
'label': 'key name',
'state': 'present',
'_ansible_check_mode': True,
})
self.module.main()
}):
self.module.main()
self.assertEqual(create_deploy_key_mock.call_count, 0)
self.assertEqual(exec_info.exception.args[0]['changed'], True)
@ -105,7 +105,7 @@ class TestBucketAccessKeyModule(ModuleTestCase):
with patch.object(self.module, 'delete_deploy_key') as delete_deploy_key_mock:
with patch.object(self.module, 'create_deploy_key') as create_deploy_key_mock:
with self.assertRaises(AnsibleExitJson) as exec_info:
set_module_args({
with set_module_args({
'client_id': 'ABC',
'client_secret': 'XXX',
'workspace': 'name',
@ -113,8 +113,8 @@ class TestBucketAccessKeyModule(ModuleTestCase):
'key': 'new public key',
'label': 'mykey',
'state': 'present',
})
self.module.main()
}):
self.module.main()
self.assertEqual(delete_deploy_key_mock.call_count, 1)
self.assertEqual(create_deploy_key_mock.call_count, 1)
@ -156,7 +156,7 @@ class TestBucketAccessKeyModule(ModuleTestCase):
with patch.object(self.module, 'delete_deploy_key') as delete_deploy_key_mock:
with patch.object(self.module, 'create_deploy_key') as create_deploy_key_mock:
with self.assertRaises(AnsibleExitJson) as exec_info:
set_module_args({
with set_module_args({
'client_id': 'ABC',
'client_secret': 'XXX',
'workspace': 'name',
@ -164,8 +164,8 @@ class TestBucketAccessKeyModule(ModuleTestCase):
'key': 'new public key',
'label': 'mykey',
'state': 'present',
})
self.module.main()
}):
self.module.main()
self.assertEqual(delete_deploy_key_mock.call_count, 0)
self.assertEqual(create_deploy_key_mock.call_count, 0)
@ -207,7 +207,7 @@ class TestBucketAccessKeyModule(ModuleTestCase):
with patch.object(self.module, 'delete_deploy_key') as delete_deploy_key_mock:
with patch.object(self.module, 'create_deploy_key') as create_deploy_key_mock:
with self.assertRaises(AnsibleExitJson) as exec_info:
set_module_args({
with set_module_args({
'client_id': 'ABC',
'client_secret': 'XXX',
'workspace': 'name',
@ -216,8 +216,8 @@ class TestBucketAccessKeyModule(ModuleTestCase):
'label': 'mykey',
'state': 'present',
'_ansible_check_mode': True,
})
self.module.main()
}):
self.module.main()
self.assertEqual(delete_deploy_key_mock.call_count, 0)
self.assertEqual(create_deploy_key_mock.call_count, 0)
@ -258,15 +258,15 @@ class TestBucketAccessKeyModule(ModuleTestCase):
def test_delete_deploy_key(self, *args):
with patch.object(self.module, 'delete_deploy_key') as delete_deploy_key_mock:
with self.assertRaises(AnsibleExitJson) as exec_info:
set_module_args({
with set_module_args({
'client_id': 'ABC',
'client_secret': 'XXX',
'workspace': 'name',
'repository': 'repo',
'label': 'mykey',
'state': 'absent',
})
self.module.main()
}):
self.module.main()
self.assertEqual(delete_deploy_key_mock.call_count, 1)
self.assertEqual(exec_info.exception.args[0]['changed'], True)
@ -276,15 +276,15 @@ class TestBucketAccessKeyModule(ModuleTestCase):
def test_delete_absent_deploy_key(self, *args):
with patch.object(self.module, 'delete_deploy_key') as delete_deploy_key_mock:
with self.assertRaises(AnsibleExitJson) as exec_info:
set_module_args({
with set_module_args({
'client_id': 'ABC',
'client_secret': 'XXX',
'workspace': 'name',
'repository': 'repo',
'label': 'mykey',
'state': 'absent',
})
self.module.main()
}):
self.module.main()
self.assertEqual(delete_deploy_key_mock.call_count, 0)
self.assertEqual(exec_info.exception.args[0]['changed'], False)
@ -324,7 +324,7 @@ class TestBucketAccessKeyModule(ModuleTestCase):
def test_delete_deploy_key_check_mode(self, *args):
with patch.object(self.module, 'delete_deploy_key') as delete_deploy_key_mock:
with self.assertRaises(AnsibleExitJson) as exec_info:
set_module_args({
with set_module_args({
'client_id': 'ABC',
'client_secret': 'XXX',
'workspace': 'name',
@ -332,8 +332,8 @@ class TestBucketAccessKeyModule(ModuleTestCase):
'label': 'mykey',
'state': 'absent',
'_ansible_check_mode': True,
})
self.module.main()
}):
self.module.main()
self.assertEqual(delete_deploy_key_mock.call_count, 0)
self.assertEqual(exec_info.exception.args[0]['changed'], True)