ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-08-11 16:44:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

xfs_quota: command args as list rather than string (#10609)

Browse source
This commit is contained in:
Alexei Znamensky 2025-08-10 23:34:30 +12:00 • committed by GitHub
commit 9fc5d2ec4d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/10609-xfs-quota-cmd-list.yml Normal file
View file

@ -0,0 +1,2 @@
minor_changes:
- xfs_quota - using safer mechanism to run external command (https://github.com/ansible-collections/community.general/pull/10609).

4
plugins/modules/xfs_quota.py
View file

@ -457,8 +457,8 @@ def quota_report(module, xfs_quota_bin, mountpoint, name, quota_type, used_type)
def exec_quota(module, xfs_quota_bin, cmd, mountpoint): def exec_quota(module, xfs_quota_bin, cmd, mountpoint):
cmd = [xfs_quota_bin, "-x", "-c"] + [cmd, mountpoint] cmd = [xfs_quota_bin, "-x", "-c", cmd, mountpoint]
(rc, stdout, stderr) = module.run_command(cmd, use_unsafe_shell=True) (rc, stdout, stderr) = module.run_command(cmd)
if ( if (
"XFS_GETQUOTA: Operation not permitted" in stderr.split("\n") "XFS_GETQUOTA: Operation not permitted" in stderr.split("\n")
or rc == 1 or rc == 1