From 9f4bb3a788161e8031d2386bb6e3e52e428c641f Mon Sep 17 00:00:00 2001 From: Alexei Znamensky <103110+russoz@users.noreply.github.com> Date: Sun, 24 Aug 2025 04:33:52 +1200 Subject: [PATCH] django_check: rename database param, add alias (#10700) * django_check: rename database param, add alias * add changelog frag * Update plugins/modules/django_check.py Co-authored-by: Felix Fontein --------- Co-authored-by: Felix Fontein --- changelogs/fragments/10700-django-check-databases.yml | 2 ++ plugins/modules/django_check.py | 10 ++++++---- 2 files changed, 8 insertions(+), 4 deletions(-) create mode 100644 changelogs/fragments/10700-django-check-databases.yml diff --git a/changelogs/fragments/10700-django-check-databases.yml b/changelogs/fragments/10700-django-check-databases.yml new file mode 100644 index 0000000000..cfb8897f6a --- /dev/null +++ b/changelogs/fragments/10700-django-check-databases.yml @@ -0,0 +1,2 @@ +minor_changes: + - django_check - rename parameter ``database`` to ``databases``, add alias for compatibility (https://github.com/ansible-collections/community.general/pull/10700). diff --git a/plugins/modules/django_check.py b/plugins/modules/django_check.py index e6e03c8276..df902d04d9 100644 --- a/plugins/modules/django_check.py +++ b/plugins/modules/django_check.py @@ -19,12 +19,14 @@ extends_documentation_fragment: - community.general.attributes - community.general.django options: - database: + databases: description: - Specify databases to run checks against. - If not specified, Django does not run database tests. + - The parameter has been renamed to O(databases) in community.general 11.3.0. The old name is still available as an alias. type: list elements: str + aliases: ["database"] deploy: description: - Include additional checks relevant in a deployment setting. @@ -92,7 +94,7 @@ from ansible_collections.community.general.plugins.module_utils.cmd_runner impor class DjangoCheck(DjangoModuleHelper): module = dict( argument_spec=dict( - database=dict(type="list", elements="str"), + databases=dict(type="list", elements="str", aliases=["database"]), deploy=dict(type="bool", default=False), fail_level=dict(type="str", choices=["CRITICAL", "ERROR", "WARNING", "INFO", "DEBUG"]), tags=dict(type="list", elements="str"), @@ -101,14 +103,14 @@ class DjangoCheck(DjangoModuleHelper): supports_check_mode=True, ) arg_formats = dict( - database=cmd_runner_fmt.stack(cmd_runner_fmt.as_opt_val)("--database"), + databases=cmd_runner_fmt.stack(cmd_runner_fmt.as_opt_val)("--database"), deploy=cmd_runner_fmt.as_bool("--deploy"), fail_level=cmd_runner_fmt.as_opt_val("--fail-level"), tags=cmd_runner_fmt.stack(cmd_runner_fmt.as_opt_val)("--tag"), apps=cmd_runner_fmt.as_list(), ) django_admin_cmd = "check" - django_admin_arg_order = "database deploy fail_level tags apps" + django_admin_arg_order = "databases deploy fail_level tags apps" def main():