ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-23 21:30:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Ensure we only cache the loop when the task had a loop (#44901)

Browse source 
* Further restrict caching of loop when the task actually had a loop. Fixes #44874

* Extend tests for loop caching
This commit is contained in:
Matt Martz 2018-08-30 12:02:43 -05:00 • committed by GitHub
commit 9d89e15ff0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/ansible/vars/manager.py
View file

@ -494,6 +494,7 @@ class VariableManager:
templar = Templar(loader=self._loader, variables=vars_copy)
items = []
has_loop = True
if task.loop_with is not None:
if task.loop_with in lookup_loader:
try:
@ -509,6 +510,7 @@ class VariableManager:
elif task.loop is not None:
items = templar.template(task.loop)
else:
has_loop = False
items = [None]
delegated_host_vars = dict()
@ -583,7 +585,7 @@ class VariableManager:
include_hostvars=False,
)
if cache_items:
if has_loop and cache_items:
# delegate_to templating produced a change, update task.loop with templated items,
# this ensures that delegate_to+loop doesn't produce different results than TaskExecutor
# which may reprocess the loop