Re-enable module comparisons in validate-modules (#21582)

* Re-enable module comparisons, specifically for new module detection and for finding new options/arguments
* Only do new module checks in shippable, local will display warning
This commit is contained in:
Matt Martz 2017-02-17 17:13:18 -06:00 committed by Matt Clay
commit 9b1bd2eb7e
2 changed files with 56 additions and 14 deletions

View file

@ -796,6 +796,13 @@ def command_sanity_validate_modules(args, targets):
if skip_paths:
cmd += ['--exclude', '^(%s)' % '|'.join(skip_paths)]
if is_shippable():
cmd.extend([
'--base-branch', os.environ['BASE_BRANCH']
])
else:
display.warning("Cannot perform module comparison against the base branch when running locally")
run_command(args, cmd, env=env)