ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-22 21:00:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

win_iis_webapppool module, fixes and improvement (#20680)

Browse source 
* fixes and improvments for win_iis_webapppool module

* fixes following review feedback on win_iis_webapppool

* Fixed a too-long line in win_iis_webapppool documentation.

* Fixed trailing whitespace for pep8 compliance in documentation win_iis_webapppool.py

* fixed bracket bug

* module parameter attributes now populated.  Switched to hashtable for result object.  Removed remaining ; statement terminators.

* Remove example that was causing CI check failure
This commit is contained in:
jhawkesworth 2017-02-28 11:14:41 +00:00 • committed by John R Barker
commit 99c594e573
2 changed files with 118 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

74
lib/ansible/modules/windows/win_iis_webapppool.ps1
View file

@ -20,42 +20,40 @@
# WANT_JSON
# POWERSHELL_COMMON
$params = Parse-Args $args;
$params = Parse-Args $args
# Name parameter
$name = Get-Attr $params "name" $FALSE;
If ($name -eq $FALSE) {
Fail-Json (New-Object psobject) "missing required argument: name";
}
$name = Get-AnsibleParam -obj $params -name "name" -type "string" -failifempty $true
# State parameter
$state = Get-Attr $params "state" $FALSE;
$valid_states = ('started', 'restarted', 'stopped', 'absent');
If (($state -Ne $FALSE) -And ($state -NotIn $valid_states)) {
Fail-Json $result "state is '$state'; must be $($valid_states)"
}
$state = Get-AnsibleParam -obj $params -name "state" -default "present" -validateSet "started","restarted","stopped","absent"
# Attributes parameter - Pipe separated list of attributes where
# keys and values are separated by comma (paramA:valyeA|paramB:valueB)
$attributes = @{};
If (Get-Member -InputObject $params -Name attributes) {
$params.attributes -split '\|' | foreach {
$key, $value = $_ -split "\:";
$attributes.Add($key, $value);
$key, $value = $_ -split "\:"
$attributes.Add($key, $value)
}
}
# Ensure WebAdministration module is loaded
if ((Get-Module "WebAdministration" -ErrorAction SilentlyContinue) -eq $NULL){
Import-Module WebAdministration
$web_admin_dll_path = Join-Path $env:SystemRoot system32\inetsrv\Microsoft.Web.Administration.dll
Add-Type -Path $web_admin_dll_path
$t = [Type]"Microsoft.Web.Administration.ApplicationPool"
}
# Result
$result = New-Object psobject @{
$result = @{
changed = $FALSE
attributes = $attributes
};
# attributes = $attributes
}
$result.attributes = $attributes
# Get pool
$pool = Get-Item IIS:\AppPools\$name
@ -77,9 +75,15 @@ try {
if($pool) {
# Set properties
$attributes.GetEnumerator() | foreach {
$newParameter = $_;
$newParameter = $_
$currentParameter = Get-ItemProperty ("IIS:\AppPools\" + $name) $newParameter.Key
if(-not $currentParameter -or ($currentParameter.Value -as [String]) -ne $newParameter.Value) {
$currentParamVal = ""
try {
$currentParamVal = $currentParameter
} catch {
$currentParamVal = $currentParameter.Value
}
if(-not $currentParamVal -or ($currentParamVal -as [String]) -ne $newParameter.Value) {
Set-ItemProperty ("IIS:\AppPools\" + $name) $newParameter.Key $newParameter.Value
$result.changed = $TRUE
}
@ -90,17 +94,17 @@ try {
Stop-WebAppPool -Name $name -ErrorAction Stop
$result.changed = $TRUE
}
if ((($state -eq 'started') -and ($pool.State -eq 'Stopped'))) {
if (($state -eq 'started') -and ($pool.State -eq 'Stopped')) {
Start-WebAppPool -Name $name -ErrorAction Stop
$result.changed = $TRUE
}
if ($state -eq 'restarted') {
switch ($pool.State)
{
'Stopped' { Start-WebAppPool -Name $name -ErrorAction Stop }
default { Restart-WebAppPool -Name $name -ErrorAction Stop }
}
$result.changed = $TRUE
switch ($pool.State)
{
'Stopped' { Start-WebAppPool -Name $name -ErrorAction Stop }
default { Restart-WebAppPool -Name $name -ErrorAction Stop }
}
$result.changed = $TRUE
}
}
} catch {
@ -114,10 +118,22 @@ if ($pool)
$result.info = @{
name = $pool.Name
state = $pool.State
attributes = New-Object psobject @{}
attributes = @{}
};
$pool.Attributes | ForEach { $result.info.attributes.Add($_.Name, $_.Value)};
$pool.Attributes | ForEach {
# lookup name if enum
if ($_.Schema.Type -eq 'enum') {
$propertyName = $_.Name.Substring(0,1).ToUpper() + $_.Name.Substring(1)
$enum = [Microsoft.Web.Administration.ApplicationPool].GetProperty($propertyName).PropertyType.FullName
$enum_names = [Enum]::GetNames($enum)
$result.info.attributes.Add($_.Name, $enum_names[$_.Value])
} else {
$result.info.attributes.Add($_.Name, $_.Value);
}
}
}
Exit-Json $result
Exit-Json $result