From 98ccc58ba01d8460ffaf76fcb03ecb4e40f9388e Mon Sep 17 00:00:00 2001
From: Ross Williams <ross@ross-williams.net>
Date: Mon, 11 Oct 2021 19:25:06 +0000
Subject: [PATCH] pkgng: test state=latest for mixed install/upgrade

Test that a list of packages given, one not installed
and one installed but out-of-date are handled correctly.
---
 .../targets/pkgng/tasks/freebsd.yml           | 43 +++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/tests/integration/targets/pkgng/tasks/freebsd.yml b/tests/integration/targets/pkgng/tasks/freebsd.yml
index 5e931c6a18..4fa0e03f1c 100644
--- a/tests/integration/targets/pkgng/tasks/freebsd.yml
+++ b/tests/integration/targets/pkgng/tasks/freebsd.yml
@@ -200,6 +200,49 @@
       - "(pkgng_example5.stdout | regex_findall('^Number of packages to be', multiline=True) | count) == 1"
       - pkgng_example5_cleanup.changed
 
+##
+## pkgng - example - state=latest multiple packages, some already installed
+##
+- name: Remove test package (checkmode)
+  pkgng:
+    name: '{{ pkgng_test_pkg_name }}'
+    state: absent
+  check_mode: yes
+  register: pkgng_example6_check
+
+- name: Create out-of-date test package
+  import_tasks: create-outofdate-pkg.yml
+
+- name: Install out-of-date test package
+  command: 'pkg add {{ pkgng_test_outofdate_pkg_path }}'
+  register: pkgng_example6_prepare
+
+- name: Upgrade and/or install two packages
+  pkgng:
+    name: '{{ pkgng_test_pkg_name }} fish'
+    state: latest
+  register: pkgng_example6
+
+- name: Remove two packages
+  pkgng:
+    name: '{{ pkgng_test_pkg_name }} fish'
+    state: absent
+  register: pkgng_example6_cleanup
+
+- name: Ensure pkgng installs multiple packages with one command
+  assert:
+    that:
+      - not pkgng_example6_check.changed
+      - not pkgng_example6_prepare.failed
+      - pkgng_example6.changed
+      - "'Number of packages to be installed: 1' is in(pkgng_example6.stdout_lines)"
+      - "'Number of packages to be upgraded: 1' is in(pkgng_example6.stdout_lines)"
+      # Checking that "will be affected" occurs twice in the output ensures
+      # that the module runs two separate commands for install and upgrade,
+      # as the pkg command only outputs the string once per invocation.
+      - "(pkgng_example6.stdout | regex_findall('will be affected', multiline=True) | count) == 2"
+      - pkgng_example6_cleanup.changed
+
 ##
 ## pkgng - example - Install single package in jail
 ##