ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-26 06:31:23 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

pin azure deps to exact versions

Browse source 
* added warnings for newer-than-expected versions
* prevent passing api_version and profile for newer clients
This commit is contained in:
Matt Davis 2018-06-05 11:47:34 -07:00 • committed by Matt Clay
commit 980cdbe679
3 changed files with 52 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

18
lib/ansible/module_utils/azure_rm_common.py
View file

@ -195,23 +195,23 @@ AZURE_PKG_VERSIONS = {
},
'ComputeManagementClient': {
'package_name': 'compute',
'expected_version': '2.0.0'
'expected_version': '2.1.0'
},
'ContainerInstanceManagementClient': {
'package_name': 'containerinstance',
'expected_version': '0.3.1'
'expected_version': '0.4.0'
},
'NetworkManagementClient': {
'package_name': 'network',
'expected_version': '1.3.0'
'expected_version': '1.7.1'
},
'ResourceManagementClient': {
'package_name': 'resource',
'expected_version': '1.1.0'
'expected_version': '1.2.2'
},
'DnsManagementClient': {
'package_name': 'dns',
'expected_version': '1.0.1'
'expected_version': '1.2.0'
},
'WebSiteManagementClient': {
'package_name': 'web',
@ -408,8 +408,11 @@ class AzureRMModuleBase(object):
return
expected_version = package_version.get('expected_version')
if Version(client_version) < Version(expected_version):
self.fail("Installed azure-mgmt-{0} client version is {1}. The supported version is {2}. Try "
self.fail("Installed azure-mgmt-{0} client version is {1}. The minimum supported version is {2}. Try "
"`pip install ansible[azure]`".format(client_name, client_version, expected_version))
if Version(client_version) != Version(expected_version):
self.module.warn("Installed azure-mgmt-{0} client version is {1}. The expected version is {2}. Try "
"`pip install ansible[azure]`".format(client_name, client_version, expected_version))
def exec_module(self, **kwargs):
self.fail("Error: {0} failed to implement exec_module method.".format(self.__class__.__name__))
@ -945,6 +948,9 @@ class AzureRMModuleBase(object):
profile_default_version = api_profile_dict.get('default_api_version', None)
if api_version or profile_default_version:
client_kwargs['api_version'] = api_version or profile_default_version
if 'profile' in client_kwargs:
# remove profile; only pass API version if specified
client_kwargs.pop('profile')
client = client_type(**client_kwargs)