BIGIP: Bugfix.multiple modules 3 (#53969)

* Moving comparision functions to compare.py from common.py

* Refactors main() function and module manager in multiple modules in line with recent changes
Adds variable types to docs
Refactors unit tests to remove deprecated parameters
This commit is contained in:
Wojciech Wypior 2019-03-19 06:03:47 +01:00 committed by Tim Rupp
parent 284565c39e
commit 9744ef80a0
12 changed files with 229 additions and 168 deletions

View file

@ -107,15 +107,18 @@ class TestManager(unittest.TestCase):
set_module_args(dict(
name='somevlan',
description='fakevlan',
server='localhost',
password='password',
user='admin',
partition='Common'
partition='Common',
provider=dict(
server='localhost',
password='password',
user='admin'
)
))
module = AnsibleModule(
argument_spec=self.spec.argument_spec,
supports_check_mode=self.spec.supports_check_mode
supports_check_mode=self.spec.supports_check_mode,
mutually_exclusive=self.spec.mutually_exclusive
)
# Override methods to force specific logic in the module to happen
@ -133,15 +136,18 @@ class TestManager(unittest.TestCase):
name='somevlan',
tagged_interface=['2.1'],
tag=213,
server='localhost',
password='password',
user='admin',
partition='Common'
partition='Common',
provider=dict(
server='localhost',
password='password',
user='admin'
)
))
module = AnsibleModule(
argument_spec=self.spec.argument_spec,
supports_check_mode=self.spec.supports_check_mode
supports_check_mode=self.spec.supports_check_mode,
mutually_exclusive=self.spec.mutually_exclusive
)
# Override methods to force specific logic in the module to happen
@ -159,15 +165,18 @@ class TestManager(unittest.TestCase):
set_module_args(dict(
name='somevlan',
untagged_interface=['2.1'],
server='localhost',
password='password',
user='admin',
partition='Common'
partition='Common',
provider=dict(
server='localhost',
password='password',
user='admin'
)
))
module = AnsibleModule(
argument_spec=self.spec.argument_spec,
supports_check_mode=self.spec.supports_check_mode
supports_check_mode=self.spec.supports_check_mode,
mutually_exclusive=self.spec.mutually_exclusive
)
# Override methods to force specific logic in the module to happen
@ -185,15 +194,18 @@ class TestManager(unittest.TestCase):
name='somevlan',
tagged_interface=['2.1', '1.1'],
tag=213,
server='localhost',
password='password',
user='admin',
partition='Common'
partition='Common',
provider=dict(
server='localhost',
password='password',
user='admin'
)
))
module = AnsibleModule(
argument_spec=self.spec.argument_spec,
supports_check_mode=self.spec.supports_check_mode
supports_check_mode=self.spec.supports_check_mode,
mutually_exclusive=self.spec.mutually_exclusive
)
# Override methods to force specific logic in the module to happen
@ -211,15 +223,18 @@ class TestManager(unittest.TestCase):
set_module_args(dict(
name='somevlan',
untagged_interface=['2.1', '1.1'],
server='localhost',
password='password',
user='admin',
partition='Common',
provider=dict(
server='localhost',
password='password',
user='admin'
)
))
module = AnsibleModule(
argument_spec=self.spec.argument_spec,
supports_check_mode=self.spec.supports_check_mode
supports_check_mode=self.spec.supports_check_mode,
mutually_exclusive=self.spec.mutually_exclusive
)
# Override methods to force specific logic in the module to happen
@ -236,15 +251,18 @@ class TestManager(unittest.TestCase):
set_module_args(dict(
name='somevlan',
untagged_interface=['2.1'],
server='localhost',
password='password',
user='admin',
partition='Common',
provider=dict(
server='localhost',
password='password',
user='admin'
)
))
module = AnsibleModule(
argument_spec=self.spec.argument_spec,
supports_check_mode=self.spec.supports_check_mode
supports_check_mode=self.spec.supports_check_mode,
mutually_exclusive=self.spec.mutually_exclusive
)
# Override methods to force specific logic in the module to happen
@ -267,15 +285,18 @@ class TestManager(unittest.TestCase):
set_module_args(dict(
name='somevlan',
tagged_interface=['2.1'],
server='localhost',
password='password',
user='admin',
partition='Common',
provider=dict(
server='localhost',
password='password',
user='admin'
)
))
module = AnsibleModule(
argument_spec=self.spec.argument_spec,
supports_check_mode=self.spec.supports_check_mode
supports_check_mode=self.spec.supports_check_mode,
mutually_exclusive=self.spec.mutually_exclusive
)
# Override methods to force specific logic in the module to happen
@ -296,15 +317,18 @@ class TestManager(unittest.TestCase):
set_module_args(dict(
name='somevlan',
description='changed_that',
server='localhost',
password='password',
user='admin',
partition='Common',
provider=dict(
server='localhost',
password='password',
user='admin'
)
))
module = AnsibleModule(
argument_spec=self.spec.argument_spec,
supports_check_mode=self.spec.supports_check_mode
supports_check_mode=self.spec.supports_check_mode,
mutually_exclusive=self.spec.mutually_exclusive
)
# Override methods to force specific logic in the module to happen