From 96b003f9af74aee5cee4184f1149bb65d37a85aa Mon Sep 17 00:00:00 2001 From: Croko-fr <62189784+Croko-fr@users.noreply.github.com> Date: Sat, 15 Mar 2025 07:46:44 +0100 Subject: [PATCH] Adding Audio device support to proxmox_kvm (#9847) * Add Audio device support to proxmox_kvm.py Audio device was unsupported with message : `FAILED! => {"changed": false, "msg": "Unsupported parameters for (community.general.proxmox_kvm) module: audio. Supported parameters include: acpi, agent, api_host, api_password, api_port, api_token_id, api_token_secret, api_user, archive, args, autostart, balloon, bios, boot, bootdisk, cicustom, cipassword, citype, ciupgrade, ciuser, clone, cores, cpu, cpulimit, cpuunits, delete, description, digest, efidisk0, force, format, freeze, full, hookscript, hostpci, hotplug, hugepages, ide, ipconfig, keyboard, kvm, localtime, lock, machine, memory, migrate, migrate_downtime, migrate_speed, name, nameservers, net, newid, node, numa, numa_enabled, onboot, ostype, parallel, pool, protection, reboot, revert, sata, scsi, scsihw, searchdomains, serial, shares, skiplock, smbios, snapname, sockets, sshkeys, startdate, startup, state, storage, tablet, tags, target, tdf, template, timeout, tpmstate0, update, update_unsafe, usb, validate_certs, vcpus, vga, virtio, vmid, watchdog."}` With this patch it is possible to update proxmox VM config with an audio device. ```yaml - name: Add Spice compatible audio device community.general.proxmox_kvm: api_user: "{{ api_user }}" api_password: "{{ api_password }}" api_host: "{{ api_host }}" node: "{{ node_name }}" vmid: "{{ proxmox_vmid }}" audio: '{"audio0":"device=ich9-intel-hda,driver=spice"}' update: true delegate_to: localhost ``` * Update plugins/modules/proxmox_kvm.py Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com> * Update plugins/modules/proxmox_kvm.py Co-authored-by: Felix Fontein * Update plugins/modules/proxmox_kvm.py Co-authored-by: Felix Fontein * Create changelog fragment 9847-Adding_audio_device-support_to_proxmox_kvm.yml * Update 9847-Adding_audio_device-support_to_proxmox_kvm.yml Update following recommandations, thanks * Update changelogs/fragments/9847-Adding_audio_device-support_to_proxmox_kvm.yml Co-authored-by: Felix Fontein --------- Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com> Co-authored-by: Felix Fontein --- ...7-Adding_audio_device-support_to_proxmox_kvm.yml | 2 ++ plugins/modules/proxmox_kvm.py | 13 ++++++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/9847-Adding_audio_device-support_to_proxmox_kvm.yml diff --git a/changelogs/fragments/9847-Adding_audio_device-support_to_proxmox_kvm.yml b/changelogs/fragments/9847-Adding_audio_device-support_to_proxmox_kvm.yml new file mode 100644 index 0000000000..27633edfb0 --- /dev/null +++ b/changelogs/fragments/9847-Adding_audio_device-support_to_proxmox_kvm.yml @@ -0,0 +1,2 @@ +minor_changes: + - proxmox_kvm - add missing audio hardware device handling (https://github.com/ansible-collections/community.general/issues/5192, https://github.com/ansible-collections/community.general/pull/9847). diff --git a/plugins/modules/proxmox_kvm.py b/plugins/modules/proxmox_kvm.py index 21a336442b..714633eaa2 100644 --- a/plugins/modules/proxmox_kvm.py +++ b/plugins/modules/proxmox_kvm.py @@ -43,6 +43,15 @@ options: - Pass arbitrary arguments to kvm. - This option is for experts only! type: str + audio: + description: + - A hash/dictionary of audio devices for the VM. O(audio={"key":"value", "key":"value"}). + - Keys allowed are - C(audio[n]) where 0 ≤ n ≤ N. + - Values allowed are - C(device="ich9-intel-hda|intel-hda|AC97",driver="none|spice"). + - C(device) is either V(ich9-intel-hda) or V(intel-hda) or V(AC97). + - Option C(driver) is V(none) or V(spice). + type: dict + version_added: 10.5.0 autostart: description: - Specify if the VM should be automatically restarted after crash (currently ignored in PVE API). @@ -1086,7 +1095,7 @@ class ProxmoxKvmAnsible(ProxmoxAnsible): ) # Convert all dict in kwargs to elements. - # For hostpci[n], ide[n], net[n], numa[n], parallel[n], sata[n], scsi[n], serial[n], virtio[n], ipconfig[n], usb[n] + # For audio[n], hostpci[n], ide[n], net[n], numa[n], parallel[n], sata[n], scsi[n], serial[n], virtio[n], ipconfig[n], usb[n] for k in list(kwargs.keys()): if isinstance(kwargs[k], dict): kwargs.update(kwargs[k]) @@ -1227,6 +1236,7 @@ def main(): acpi=dict(type='bool'), agent=dict(type='str'), args=dict(type='str'), + audio=dict(type='dict'), autostart=dict(type='bool'), balloon=dict(type='int'), bios=dict(choices=['seabios', 'ovmf']), @@ -1435,6 +1445,7 @@ def main(): archive=module.params['archive'], acpi=module.params['acpi'], agent=module.params['agent'], + audio=module.params['audio'], autostart=module.params['autostart'], balloon=module.params['balloon'], bios=module.params['bios'],