nxos: merge nxapi/cli tests - acl, acl_interface, banner, bgp (#28234)

* refactored nxos_acl

* refactor nxos_acl_interface

* refactor nxos_banner

* refactor nxos_bgp

* fix typo
This commit is contained in:
David Newswanger 2017-08-17 04:40:54 -04:00 committed by Trishna Guha
commit 9556e945eb
20 changed files with 139 additions and 492 deletions

View file

@ -1,15 +1,25 @@
---
- name: collect all cli test cases
- name: collect common cli test cases
find:
paths: "{{ role_path }}/tests/common"
patterns: "{{ testcase }}.yaml"
register: test_cases
- name: collect cli test cases
find:
paths: "{{ role_path }}/tests/cli"
patterns: "{{ testcase }}.yaml"
register: test_cases
register: cli_cases
- set_fact:
test_cases:
files: "{{ test_cases.files }} + {{ cli_cases.files }}"
- name: set test_items
set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"
- name: run test case
include: "{{ test_case_to_run }}"
include: "{{ test_case_to_run }} connection={{ cli }}"
with_items: "{{ test_items }}"
loop_control:
loop_var: test_case_to_run

View file

@ -1,9 +1,19 @@
---
- name: collect all nxapi test cases
- name: collect common nxapi test cases
find:
paths: "{{ role_path }}/tests/common"
patterns: "{{ testcase }}.yaml"
register: test_cases
- name: collect nxapi test cases
find:
paths: "{{ role_path }}/tests/nxapi"
patterns: "{{ testcase }}.yaml"
register: test_cases
register: nxapi_cases
- set_fact:
test_cases:
files: "{{ test_cases.files }} + {{ nxapi_cases.files }}"
- name: set test_items
set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"
@ -16,7 +26,7 @@
provider: "{{ cli }}"
- name: run test case
include: "{{ test_case_to_run }}"
include: "{{ test_case_to_run }} connection={{ nxapi }}"
with_items: "{{ test_items }}"
loop_control:
loop_var: test_case_to_run

View file

@ -1,5 +1,5 @@
---
- debug: msg="START TRANSPORT:CLI nxos_acl_interface sanity test"
- debug: msg="START TRANSPORT:{{ connection.transport}} nxos_acl_interface sanity test"
# Select interface for test
- set_fact: intname="{{ nxos_int1 }}"
@ -11,7 +11,7 @@
nxos_config: &default
lines:
- "default interface {{ intname }}"
provider: "{{ cli }}"
provider: "{{ connection }}"
ignore_errors: yes
- name: "Setup: Cleanup possibly existing acl"
@ -19,7 +19,7 @@
name: ANSIBLE_ACL
seq: 10
state: absent
provider: "{{ cli }}"
provider: "{{ connection }}"
ignore_errors: yes
- name: Configure Supporting ACL
@ -30,7 +30,7 @@
proto: tcp
src: 1.1.1.1/24
dest: any
provider: "{{ cli }}"
provider: "{{ connection }}"
- block:
- name: Configure acl interface egress
@ -39,7 +39,7 @@
interface: "{{ intname }}"
direction: egress
state: present
provider: "{{ cli }}"
provider: "{{ connection }}"
register: result
- assert: &true
@ -60,7 +60,7 @@
interface: "{{ intname }}"
direction: ingress
state: present
provider: "{{ cli }}"
provider: "{{ connection }}"
register: result
- assert: *true
@ -77,7 +77,7 @@
interface: "{{ intname }}"
direction: egress
state: absent
provider: "{{ cli }}"
provider: "{{ connection }}"
register: result
- assert: *true
@ -94,7 +94,7 @@
interface: "{{ intname }}"
direction: ingress
state: absent
provider: "{{ cli }}"
provider: "{{ connection }}"
register: result
- assert: *true
@ -115,4 +115,4 @@
ignore_errors: yes
always:
- debug: msg="END TRANSPORT:CLI nxos_acl_interface sanity test"
- debug: msg="END TRANSPORT:{{ connection.transport}} nxos_acl_interface sanity test"

View file

@ -1,118 +0,0 @@
---
- debug: msg="START TRANSPORT:NXAPI nxos_acl_interface sanity test"
# Select interface for test
- set_fact: intname="{{ nxos_int1 }}"
- name: "Interface selected for this test"
debug: msg="{{ intname }}"
- name: "Setup: Put interface into a default state"
nxos_config: &default
lines:
- "default interface {{ intname }}"
provider: "{{ nxapi }}"
ignore_errors: yes
- name: "Setup: Cleanup possibly existing acl"
nxos_acl: &remove
name: ANSIBLE_ACL
seq: 10
state: absent
provider: "{{ nxapi }}"
ignore_errors: yes
- name: Configure Supporting ACL
nxos_acl:
name: ANSIBLE_ACL
seq: 10
action: permit
proto: tcp
src: 1.1.1.1/24
dest: any
provider: "{{ nxapi }}"
- block:
- name: Configure acl interface egress
nxos_acl_interface: &configure_egr
name: ANSIBLE_ACL
interface: "{{ intname }}"
direction: egress
state: present
provider: "{{ nxapi }}"
register: result
- assert: &true
that:
- "result.changed == true"
- name: "Check Idempotence egress"
nxos_acl_interface: *configure_egr
register: result
- assert: &false
that:
- "result.changed == false"
- name: Configure acl interface ingress
nxos_acl_interface: &configure_ingr
name: ANSIBLE_ACL
interface: "{{ intname }}"
direction: ingress
state: present
provider: "{{ nxapi }}"
register: result
- assert: *true
- name: "Check Idempotence ingress"
nxos_acl_interface: *configure_ingr
register: result
- assert: *false
- name: Cleanup acl interface egress
nxos_acl_interface: &cleanup_egr
name: ANSIBLE_ACL
interface: "{{ intname }}"
direction: egress
state: absent
provider: "{{ nxapi }}"
register: result
- assert: *true
- name: "Check Idempotence egress cleanup"
nxos_acl_interface: *cleanup_egr
register: result
- assert: *false
- name: Cleanup acl interface ingress
nxos_acl_interface: &cleanup_ingr
name: ANSIBLE_ACL
interface: "{{ intname }}"
direction: ingress
state: absent
provider: "{{ nxapi }}"
register: result
- assert: *true
- name: "Check Idempotence ingress cleanup"
nxos_acl_interface: *cleanup_ingr
register: result
- assert: *false
rescue:
- name: Put test interface into default state.
nxos_config: *default
ignore_errors: yes
- name: Remove possible configured ACL
nxos_acl: *remove
ignore_errors: yes
always:
- debug: msg="END TRANSPORT:NXAPI nxos_acl_interface sanity test"