nxos: merge nxapi/cli tests - acl, acl_interface, banner, bgp (#28234)

* refactored nxos_acl

* refactor nxos_acl_interface

* refactor nxos_banner

* refactor nxos_bgp

* fix typo

test/integration/targets/nxos_acl/tasks/cli.yaml

@@ -1,15 +1,25 @@
 ---
-- name: collect all cli test cases
+- name: collect common cli test cases
+  find:
+    paths: "{{ role_path }}/tests/common"
+    patterns: "{{ testcase }}.yaml"
+  register: test_cases
+
+- name: collect cli test cases
   find:
     paths: "{{ role_path }}/tests/cli"
     patterns: "{{ testcase }}.yaml"
-  register: test_cases
+  register: cli_cases
+
+- set_fact:
+    test_cases:
+      files: "{{ test_cases.files }} + {{ cli_cases.files }}"
 
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"
 
 - name: run test case
-  include: "{{ test_case_to_run }}"
+  include: "{{ test_case_to_run }} connection={{ cli }}"
   with_items: "{{ test_items }}"
   loop_control:
     loop_var: test_case_to_run

test/integration/targets/nxos_acl/tasks/nxapi.yaml

@@ -1,9 +1,19 @@
 ---
-- name: collect all nxapi test cases
+- name: collect common nxapi test cases
+  find:
+    paths: "{{ role_path }}/tests/common"
+    patterns: "{{ testcase }}.yaml"
+  register: test_cases
+
+- name: collect nxapi test cases
   find:
     paths: "{{ role_path }}/tests/nxapi"
     patterns: "{{ testcase }}.yaml"
-  register: test_cases
+  register: nxapi_cases
+
+- set_fact:
+    test_cases:
+      files: "{{ test_cases.files }} + {{ nxapi_cases.files }}"
 
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"
@@ -16,7 +26,7 @@
     provider: "{{ cli }}"
 
 - name: run test case
-  include: "{{ test_case_to_run }}"
+  include: "{{ test_case_to_run }} connection={{ nxapi }}"
   with_items: "{{ test_items }}"
   loop_control:
     loop_var: test_case_to_run

test/integration/targets/nxos_acl/tests/cli/sanity.yaml

@@ -1,48 +0,0 @@
----
-- debug: msg="START TRANSPORT:CLI nxos_acl sanity test"
-
-- name: "Setup: Cleanup possibly existing acl."
-  nxos_acl: &remove
-    name: TEST_ACL
-    seq: 10
-    state: absent
-    provider: "{{ cli }}"
-  ignore_errors: yes
-
-- name: "Configure ACL"
-  nxos_acl: &configure
-    name: TEST_ACL
-    seq: 10
-    action: permit
-    proto: tcp
-    src: 1.1.1.1/24
-    dest: any
-    state: present
-    provider: "{{ cli }}"
-  register: result
-
-- assert: &true
-    that:
-      - "result.changed == true"
-
-- name: "Check Idempotence"
-  nxos_acl: *configure
-  register: result
-
-- assert: &false
-    that:
-      - "result.changed == false"
-
-- name: "Remove ACL"
-  nxos_acl: *remove
-  register: result
-
-- assert: *true
-
-- name: "Check Idempotence"
-  nxos_acl: *remove
-  register: result
-
-- assert: *false
-
-- debug: msg="END TRANSPORT:CLI nxos_acl sanity test"

test/integration/targets/nxos_acl/tests/common/sanity.yaml

@@ -1,12 +1,12 @@
 ---
-- debug: msg="START TRANSPORT:NXAPI nxos_acl sanity test"
+- debug: msg="START TRANSPORT:{{ connection.transport }} nxos_acl sanity test"
 
 - name: "Setup: Cleanup possibly existing acl."
   nxos_acl: &remove
     name: TEST_ACL
     seq: 10
     state: absent
-    provider: "{{ nxapi }}"
+    provider: "{{ connection }}"
   ignore_errors: yes
 
 - name: "Configure ACL"
@@ -31,7 +31,7 @@
     syn: 'enable'
     time_range: 'ans-range'
     state: present
-    provider: "{{ nxapi }}"
+    provider: "{{ connection }}"
   register: result
 
 - assert: &true
@@ -58,4 +58,4 @@
 
 - assert: *false
 
-- debug: msg="END TRANSPORT:NXAPI nxos_acl sanity test"
+- debug: msg="END TRANSPORT:{{ connection.transport }} nxos_acl sanity test"