Standardize cliconf get_capabilities (#51147)

* Standardize cliconf get_capabilities

* Check for capabilities before querying them

* Try to be more helpful when unexpected things are found in get_capabilities

* Add flags param to get_config for compatibility
This commit is contained in:
Nathaniel Case 2019-01-28 08:24:44 -05:00 committed by GitHub
parent bd44db141a
commit 9336281a60
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
26 changed files with 82 additions and 143 deletions

View file

@ -38,7 +38,7 @@ class Cliconf(CliconfBase):
return device_info
def get_config(self, source='running', format='text'):
def get_config(self, source='running', format='text', flags=None):
return self.send_command('show configuration commands')
def edit_config(self, candidate=None, commit=True, replace=False, comment=None):
@ -59,8 +59,6 @@ class Cliconf(CliconfBase):
self.send_command('discard')
def get_capabilities(self):
result = {}
result['rpc'] = self.get_base_rpc() + ['commit', 'discard_changes']
result['network_api'] = 'cliconf'
result['device_info'] = self.get_device_info()
result = super(Cliconf, self).get_capabilities()
result['rpc'] += ['commit', 'discard_changes']
return json.dumps(result)