ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-10-24 04:54:00 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

ec2_group: description is only required when group state is present (#19791)

Browse source 
* description is only required when group state is present

also note that AWS requires a non-empty description when creating a security group

* clarify description requirement
This commit is contained in:
Alex Lo 2017-03-07 14:55:17 -05:00 • committed by René Moser
commit 8e910cce8a
2 changed files with 23 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

21
test/integration/roles/test_ec2_group/tasks/main.yml
View file

@ -18,7 +18,7 @@
assert:
that:
- 'result.failed'
- 'result.msg == "missing required arguments: description,name"'
- 'result.msg == "missing required arguments: name"'
# ============================================================
- name: test failure with only name
@ -31,7 +31,7 @@
assert:
that:
- 'result.failed'
- 'result.msg == "missing required arguments: description"'
- 'result.msg == "Must provide description when state is present."'
# ============================================================
- name: test failure with only description
@ -46,6 +46,21 @@
- 'result.failed'
- 'result.msg == "missing required arguments: name"'
# ============================================================
- name: test failure with empty description (AWS API requires non-empty string desc)
ec2_group:
name='{{ec2_group_name}}'
description=''
region='{{ec2_region}}'
register: result
ignore_errors: true
- name: assert failure with empty description
assert:
that:
- 'result.failed'
- 'result.msg == "Must provide description when state is present."'
# ============================================================
- name: test invalid region parameter
ec2_group:
@ -213,7 +228,6 @@
- name: test state=absent (expected changed=true)
ec2_group:
name='{{ec2_group_name}}'
description='{{ec2_group_description}}'
state=absent
environment:
EC2_REGION: '{{ec2_region}}'
@ -231,7 +245,6 @@
- name: test state=absent (expected changed=false)
ec2_group:
name='{{ec2_group_name}}'
description='{{ec2_group_description}}'
state=absent
environment:
EC2_REGION: '{{ec2_region}}'