ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-27 15:11:23 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

monit: fix module detection of monitored process state (#1107)

Browse source 
* refactor and test

* require version >= 5.21.0

Prior to this version the status output was different

* python version compatability

* use exception classes from utils

* modify monit to use 'status' output instead of 'summary' output

The summary output is a fixed width table which truncates the
contents and prevents us from parsing the actual status of the
program.

* add integration tests + fixes

* remove unused handlers in monit integration test

* fix lint

* add '__metaclass__ = type' to integration python files

* raise AttributeError

* simplify status

* lint: add type to parameter docs

* remove lint ignore

* move monit process config into main file

* specify path to monit PID file

* set config location based on os_family

* create required directories

* update aliases to set group and skips

* add changelog

* add author

* add types to docs

* add EPEL repo

* custom vars for centos-6

* uninstall EPEL

* support older versions

* wait for status to change before exiting

* use 'validate' to force status updates

* handle 'execution failed'

* better status output for errors

* add more context to failure + standardize

* don't check rc for validate

* legacy string format support

* add integration test for 'reloaded' and 'present'

* don't wait after reload

* lint

* Revert "uninstall EPEL"

This reverts commit 4d548718d0.

* make 'present' more robust

* Apply suggestions from code review

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* add license header

* drop daemon.py and use python-daemon instead

* skip python2.6 which is not supported by python-daemon

* refactor test tasks for reuse

* cleanup files after test

* lint

* start process before enabling monit

This shouldn't be necessary but I'm adding it in the hopes
it will make tests more robust.

* retry task

* attempt to rescue the task on failure

* fix indentation

* ignore check if rescue ran

* restart monit instead of reload

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
This commit is contained in:
Simon Kelly 2020-10-23 12:26:23 +02:00 • committed by GitHub
commit 8de1c0c205
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
21 changed files with 698 additions and 127 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/sanity/ignore-2.10.txt
View file

@ -675,8 +675,6 @@ plugins/modules/monitoring/logentries.py validate-modules:undocumented-parameter
plugins/modules/monitoring/logstash_plugin.py validate-modules:doc-missing-type
plugins/modules/monitoring/logstash_plugin.py validate-modules:invalid-ansiblemodule-schema
plugins/modules/monitoring/logstash_plugin.py validate-modules:parameter-type-not-in-doc
plugins/modules/monitoring/monit.py validate-modules:doc-missing-type
plugins/modules/monitoring/monit.py validate-modules:parameter-type-not-in-doc
plugins/modules/monitoring/newrelic_deployment.py validate-modules:doc-missing-type
plugins/modules/monitoring/pagerduty.py validate-modules:doc-default-does-not-match-spec
plugins/modules/monitoring/pagerduty.py validate-modules:doc-missing-type

2
tests/sanity/ignore-2.11.txt
View file

@ -675,8 +675,6 @@ plugins/modules/monitoring/logentries.py validate-modules:undocumented-parameter
plugins/modules/monitoring/logstash_plugin.py validate-modules:doc-missing-type
plugins/modules/monitoring/logstash_plugin.py validate-modules:invalid-ansiblemodule-schema
plugins/modules/monitoring/logstash_plugin.py validate-modules:parameter-type-not-in-doc
plugins/modules/monitoring/monit.py validate-modules:doc-missing-type
plugins/modules/monitoring/monit.py validate-modules:parameter-type-not-in-doc
plugins/modules/monitoring/newrelic_deployment.py validate-modules:doc-missing-type
plugins/modules/monitoring/pagerduty.py validate-modules:doc-default-does-not-match-spec
plugins/modules/monitoring/pagerduty.py validate-modules:doc-missing-type

2
tests/sanity/ignore-2.9.txt
View file

@ -543,8 +543,6 @@ plugins/modules/monitoring/logentries.py validate-modules:parameter-type-not-in-
plugins/modules/monitoring/logentries.py validate-modules:undocumented-parameter
plugins/modules/monitoring/logstash_plugin.py validate-modules:doc-missing-type
plugins/modules/monitoring/logstash_plugin.py validate-modules:parameter-type-not-in-doc
plugins/modules/monitoring/monit.py validate-modules:doc-missing-type
plugins/modules/monitoring/monit.py validate-modules:parameter-type-not-in-doc
plugins/modules/monitoring/newrelic_deployment.py validate-modules:doc-missing-type
plugins/modules/monitoring/pagerduty.py validate-modules:doc-default-does-not-match-spec
plugins/modules/monitoring/pagerduty.py validate-modules:doc-missing-type