Add integration tests for nxos_facts, nxos_bgp, nxos_bgp_af, nxos_bgp_neighbor, and nxos_evpn_global (#26924)

* Add new ITs for nxos_bgp, nxos_bgp_af, nxos_bgp_neighbor, and nxos_evpn_global

* Add nxos_facts IT and enhance existing tests

* switch nxos_feature tests to use bgp

* misc. test fixes

* Add checks for titanium in IT

* Handle non-titanium case in tests

test/integration/targets/nxos_facts/tests/cli/all_facts.yaml

@@ -24,6 +24,10 @@
 
       # Items from those subsets are present
       - "result.ansible_facts.ansible_net_filesystems is defined"
+      - "result.ansible_facts.ansible_net_interfaces is defined"
+      - "result.ansible_facts.ansible_net_config is defined"
+      - "result.ansible_facts.ansible_net_model is defined"
+
       # Check that these facts not only are present, but are valid (positive integers)
       - "result.ansible_facts.ansible_net_memfree_mb > 1"
       - "result.ansible_facts.ansible_net_memtotal_mb > 1"

test/integration/targets/nxos_facts/tests/cli/default_facts.yaml

@@ -23,6 +23,8 @@
       # Items from those subsets are present
       - "result.ansible_facts.ansible_net_filesystems is defined" #hw
       - "result.ansible_facts.ansible_net_memtotal_mb > 10" #hw
+      - "result.ansible_facts.ansible_net_model is defined" #default
+      - "result.ansible_facts.ansible_net_interfaces is defined" #interfaces
     # FIXME
 #      - "result.ansible_facts.ansible_net_interfaces.Ethernet1.ipv4.masklen > 1" # interfaces
 

test/integration/targets/nxos_facts/tests/cli/not_hardware.yaml

@@ -16,9 +16,9 @@
 
       # Correct subsets are present
       - "'config' in result.ansible_facts.ansible_net_gather_subset"
-
       - "'default' in result.ansible_facts.ansible_net_gather_subset"
       - "'interfaces' in result.ansible_facts.ansible_net_gather_subset"
+
       # ... and not present
       - "'hardware' not in result.ansible_facts.ansible_net_gather_subset"
 

test/integration/targets/nxos_facts/tests/cli/sanity.yaml

@@ -0,0 +1,78 @@
+---
+- debug: msg="START TRANSPORT:CLI nxos_facts sanity test"
+
+- name: "nxos_facts gather hardware facts"
+  nxos_facts:
+    gather_subset: hardware
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      # _facts modules should never report a change
+      - "result.changed == false"
+
+      # Correct subsets are present
+      - "'hardware' in result.ansible_facts.ansible_net_gather_subset"
+
+      # Other facts are not present
+      - "'config' not in result.ansible_facts.ansible_net_gather_subset"
+      - "'interfaces' not in result.ansible_facts.ansible_net_gather_subset"
+
+      # Items from those subsets are present
+      - "result.ansible_facts.ansible_net_filesystems is defined"
+
+      # Check that these facts not only are present, but are valid (positive integers)
+      - "result.ansible_facts.ansible_net_memfree_mb > 1"
+      - "result.ansible_facts.ansible_net_memtotal_mb > 1"
+
+- name: "nxos_facts gather config facts"
+  nxos_facts:
+    gather_subset: config
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      # _facts modules should never report a change
+      - "result.changed == false"
+
+      # Correct subsets are present
+      - "'config' in result.ansible_facts.ansible_net_gather_subset"
+
+      # Other facts are not present
+      - "'hardware' not in result.ansible_facts.ansible_net_gather_subset"
+      - "'interfaces' not in result.ansible_facts.ansible_net_gather_subset"
+
+      # Items from those subsets are present
+      - "result.ansible_facts.ansible_net_config is defined"
+
+- name: "nxos_facts gather config and hardware facts"
+  nxos_facts:
+    gather_subset:
+      - hardware
+      - config
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      # _facts modules should never report a change
+      - "result.changed == false"
+
+      # Correct subsets are present
+      - "'hardware' in result.ansible_facts.ansible_net_gather_subset"
+      - "'config' in result.ansible_facts.ansible_net_gather_subset"
+
+      # Other facts are not present
+      - "'interfaces' not in result.ansible_facts.ansible_net_gather_subset"
+
+      # Items from those subsets are present
+      - "result.ansible_facts.ansible_net_filesystems is defined"
+      - "result.ansible_facts.ansible_net_config is defined"
+
+      # Check that these facts not only are present, but are valid (positive integers)
+      - "result.ansible_facts.ansible_net_memfree_mb > 1"
+      - "result.ansible_facts.ansible_net_memtotal_mb > 1"
+
+- debug: msg="END TRANSPORT:CLI nxos_facts sanity test"

test/integration/targets/nxos_facts/tests/nxapi/all_facts.yaml

@@ -25,6 +25,10 @@
 
       # Items from those subsets are present
       - "result.ansible_facts.ansible_net_filesystems is defined"
+      - "result.ansible_facts.ansible_net_interfaces is defined"
+      - "result.ansible_facts.ansible_net_config is defined"
+      - "result.ansible_facts.ansible_net_model is defined"
+
       # Check that these facts not only are present, but are valid (positive integers)
       - "result.ansible_facts.ansible_net_memfree_mb > 1"
       - "result.ansible_facts.ansible_net_memtotal_mb > 1"

test/integration/targets/nxos_facts/tests/nxapi/default_facts.yaml

@@ -23,6 +23,8 @@
       # Items from those subsets are present
       - "result.ansible_facts.ansible_net_filesystems is defined" #hw
       - "result.ansible_facts.ansible_net_memtotal_mb > 10" #hw
+      - "result.ansible_facts.ansible_net_model is defined" #default
+      - "result.ansible_facts.ansible_net_interfaces is defined" #interfaces
     # FIXME
 #      - "result.ansible_facts.ansible_net_interfaces.Ethernet1.ipv4.masklen > 1" # interfaces
 

test/integration/targets/nxos_facts/tests/nxapi/not_hardware.yaml

@@ -17,9 +17,9 @@
 
       # Correct subsets are present
       - "'config' in result.ansible_facts.ansible_net_gather_subset"
-
       - "'default' in result.ansible_facts.ansible_net_gather_subset"
       - "'interfaces' in result.ansible_facts.ansible_net_gather_subset"
+
       # ... and not present
       - "'hardware' not in result.ansible_facts.ansible_net_gather_subset"
 

test/integration/targets/nxos_facts/tests/nxapi/sanity.yaml

@@ -0,0 +1,78 @@
+---
+- debug: msg="START TRANSPORT:NXAPI nxos_facts sanity test"
+
+- name: "nxos_facts gather hardware facts"
+  nxos_facts:
+    gather_subset: hardware
+    provider: "{{ nxapi }}"
+  register: result
+
+- assert:
+    that:
+      # _facts modules should never report a change
+      - "result.changed == false"
+
+      # Correct subsets are present
+      - "'hardware' in result.ansible_facts.ansible_net_gather_subset"
+
+      # Other facts are not present
+      - "'config' not in result.ansible_facts.ansible_net_gather_subset"
+      - "'interfaces' not in result.ansible_facts.ansible_net_gather_subset"
+
+      # Items from those subsets are present
+      - "result.ansible_facts.ansible_net_filesystems is defined"
+
+      # Check that these facts not only are present, but are valid (positive integers)
+      - "result.ansible_facts.ansible_net_memfree_mb > 1"
+      - "result.ansible_facts.ansible_net_memtotal_mb > 1"
+
+- name: "nxos_facts gather config facts"
+  nxos_facts:
+    gather_subset: config
+    provider: "{{ nxapi }}"
+  register: result
+
+- assert:
+    that:
+      # _facts modules should never report a change
+      - "result.changed == false"
+
+      # Correct subsets are present
+      - "'config' in result.ansible_facts.ansible_net_gather_subset"
+
+      # Other facts are not present
+      - "'hardware' not in result.ansible_facts.ansible_net_gather_subset"
+      - "'interfaces' not in result.ansible_facts.ansible_net_gather_subset"
+
+      # Items from those subsets are present
+      - "result.ansible_facts.ansible_net_config is defined"
+
+- name: "nxos_facts gather config and hardware facts"
+  nxos_facts:
+    gather_subset:
+      - hardware
+      - config
+    provider: "{{ nxapi }}"
+  register: result
+
+- assert:
+    that:
+      # _facts modules should never report a change
+      - "result.changed == false"
+
+      # Correct subsets are present
+      - "'hardware' in result.ansible_facts.ansible_net_gather_subset"
+      - "'config' in result.ansible_facts.ansible_net_gather_subset"
+
+      # Other facts are not present
+      - "'interfaces' not in result.ansible_facts.ansible_net_gather_subset"
+
+      # Items from those subsets are present
+      - "result.ansible_facts.ansible_net_filesystems is defined"
+      - "result.ansible_facts.ansible_net_config is defined"
+
+      # Check that these facts not only are present, but are valid (positive integers)
+      - "result.ansible_facts.ansible_net_memfree_mb > 1"
+      - "result.ansible_facts.ansible_net_memtotal_mb > 1"
+
+- debug: msg="END TRANSPORT:NXAPI nxos_facts sanity test"