Enabling validation-modules for web_infrastructure modules (#1200)

* fixed validation-modules for apache2_mod_proxy.py

* fixed validation-modules for apache2_module.py

* fixed validation-modules for deploy_helper.py

The ignore lines were put back in place because
add_file_common_args=True is used and the module inherits a number of
options that do not show up in the documentation (nor should they).

* fixed validation-modules for ejabberd_user.py

* fixed validation-modules for gunicorn.py

* fixed validation-modules for htpasswd.py

* fixed validation-modules for jenkins_job.py

* fixed validation-modules for jenkins_job_info.py

* fixed validation-modules for jenkins_plugin.py

* fixed validation-modules for jenkins_script.py

* fixed validation-modules for jira.py

* fixed validation-modules for nginx_status_facts.py

* fixed validation-modules for rundeck_acl_policy.py

* fixed validation-modules for rundeck_project.py

* fixed validation-modules for supervisorctl.py

* fixed validation-modules for taiga_issue.py

* fixed pylint mistake in plugins/modules/web_infrastructure/jenkins_job_info.py

* removed ignore lines for almost-all web_infrastructure modules

* rolled back ignore lines for nested sophos_utm modules that were not adjusted

* Removed doc-missing-type from ignore-2.11.txt for deploy_helper and jenkins_plugin

* When adding lines back to ignore files, we added more than it was before. Removing.

* Rolled back deprecation line in ignore-2.9.txt for nginx_status_facts

* Rolled back yet another line in ignore-2.9.txt for nginx_status_facts

* Fixed argument_spec and docs for crypt_scheme parameter in htpasswd, per PR

* Added extends_documentation_fragment:files to deploy_helper and jenkins_plugin

* Removed long-deprecated option params from jenkins_plugin, removed validate-modules lines from ignore files for that module

* Update plugins/modules/web_infrastructure/htpasswd.py

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>

plugins/modules/web_infrastructure/supervisorctl.py

@@ -16,32 +16,40 @@ description:
      - Manage the state of a program or group of programs running via supervisord
 options:
   name:
+    type: str
     description:
       - The name of the supervisord program or group to manage.
       - The name will be taken as group name when it ends with a colon I(:)
       - Group support is only available in Ansible version 1.6 or later.
     required: true
   config:
+    type: path
     description:
       - The supervisor configuration file path
   server_url:
+    type: str
     description:
       - URL on which supervisord server is listening
   username:
+    type: str
     description:
       - username to use for authentication
   password:
+    type: str
     description:
       - password to use for authentication
   state:
+    type: str
     description:
       - The desired state of program/group.
     required: true
     choices: [ "present", "started", "stopped", "restarted", "absent", "signalled" ]
   signal:
+    type: str
     description:
       - The signal to send to the program/group, when combined with the 'signalled' state. Required when l(state=signalled).
   supervisorctl_path:
+    type: path
     description:
       - path to supervisorctl executable
 notes:
@@ -92,14 +100,14 @@ from ansible.module_utils.basic import AnsibleModule, is_executable
 
 def main():
     arg_spec = dict(
-        name=dict(required=True),
+        name=dict(type='str', required=True),
         config=dict(required=False, type='path'),
-        server_url=dict(required=False),
-        username=dict(required=False),
-        password=dict(required=False, no_log=True),
+        server_url=dict(type='str', required=False),
+        username=dict(type='str', required=False),
+        password=dict(type='str', required=False, no_log=True),
         supervisorctl_path=dict(required=False, type='path'),
-        state=dict(required=True, choices=['present', 'started', 'restarted', 'stopped', 'absent', 'signalled']),
-        signal=dict(required=False)
+        state=dict(type='str', required=True, choices=['present', 'started', 'restarted', 'stopped', 'absent', 'signalled']),
+        signal=dict(type='str', required=False)
     )
 
     module = AnsibleModule(argument_spec=arg_spec, supports_check_mode=True)